From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C74132862C; Wed, 29 Oct 2025 15:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761751597; cv=none; b=akKfZtf4CaToVDCuul9bE4RMs/pdlFX2rflZTV3NruECeS86ClDNVew2KOwb6kqreNLXd7t6FulUVEWCC0+i/iALyj6PJreMlbxe/aaVHMH/+AAnfTMELaDDtALYrIsnBQJdPiFWKJbtxdupyPAhnGJxGmd0B6dlTeNHARtwWec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761751597; c=relaxed/simple; bh=DOI6gyVeo4a6kw7xLiiWwg46FMQvx6VSCtZfRDcnTjc=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=d2jqfL8tu/mvZkLu07JrC91QyT5cAIXe6++/emF/7UDH2yyLZ9/iw1IQs/D0hSGibeRP9xMTSLQ1I58IINoyjT6vjrQV9R9/qB9Z8D5yQDqvCoOQlVfYCBcteXYnfn3ZYbDCCKABPzX9EQd+EQsoevVO7a9y9O/ebBlpsNJn5gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p14OK/pA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p14OK/pA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1052C4CEF7; Wed, 29 Oct 2025 15:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761751597; bh=DOI6gyVeo4a6kw7xLiiWwg46FMQvx6VSCtZfRDcnTjc=; h=Date:To:From:Subject:Cc:References:In-Reply-To:From; b=p14OK/pAxog1HFDJrJs0vo0gmUYhgqGQcPcbeoSNofB1v6oECmN/OP5xhM1Fi8l3p 2WIxf/xTZwds0sAujVxkm9LHAvP9RBIlYG8w1xccSzVIyvp2kwTsalJbW3Aapwfzf+ qtzlEGqjkC8JVRM95YcopwoEa632ZaMeu/lmd1w2PEn+GehZQO0gP3eXSKPlBLghKa bHxi7jtVm9Zw556OHI8yk8/sZ1awvekCUj51stG+qYAVxNd4wGCjUNEWvwcNFwdUs/ UBlGJrhIhdtxV4jufH+UaT+KUaj+bCpebyrjoF8eCeJNff/c/3OCJx5YCJ3n1cKbKx vEc/yUZesOZOA== Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Oct 2025 16:26:31 +0100 Message-Id: To: "Christian Brauner" From: "Danilo Krummrich" Subject: Re: [PATCH v2 1/8] rust: fs: add file::Offset type alias Cc: , , , , , , , , , , , , , , , "Alexander Viro" , "Jan Kara" References: <20251020222722.240473-1-dakr@kernel.org> <20251020222722.240473-2-dakr@kernel.org> <20251029-orgel-eishockey-44848cc46a6d@brauner> In-Reply-To: <20251029-orgel-eishockey-44848cc46a6d@brauner> On Wed Oct 29, 2025 at 1:49 PM CET, Christian Brauner wrote: > On Tue, Oct 21, 2025 at 12:26:13AM +0200, Danilo Krummrich wrote: >> Add a type alias for file offsets, i.e. bindings::loff_t. Trying to >> avoid using raw bindings types, this seems to be the better alternative >> compared to just using i64. >>=20 >> Cc: Alexander Viro >> Cc: Christian Brauner >> Cc: Jan Kara >> Signed-off-by: Danilo Krummrich >> --- >> Al, Christian: If you are okay with the patch, kindly provide an ACK, so= I can >> take it through the driver-core tree. >> --- > > Reviewed-by: Christian Brauner Thanks Christian! Based on Miguel's suggestion [1] v3 of the series introduces a new type for file::Offset rather than just a type alias. Therefore, v3 [2] is significantly different, hence I will wait for you to = reply to v3 before picking up the entire series. Thanks, Danilo [1] https://github.com/Rust-for-Linux/linux/issues/1198 [2] https://lore.kernel.org/lkml/20251022143158.64475-2-dakr@kernel.org/