From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alice Ryhl" <aliceryhl@google.com>
Cc: "Tejun Heo" <tj@kernel.org>, "Miguel Ojeda" <ojeda@kernel.org>,
"Lai Jiangshan" <jiangshanlai@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Philipp Stanner" <phasta@kernel.org>,
"Tamir Duberstein" <tamird@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Benno Lossin" <lossin@kernel.org>
Subject: Re: [PATCH v2 2/2] rust: workqueue: add creation of workqueues
Date: Fri, 14 Nov 2025 08:55:07 +1100 [thread overview]
Message-ID: <DE7WH5KQP268.1GXMZM78VIESE@kernel.org> (raw)
In-Reply-To: <20251113-create-workqueue-v2-2-8b45277119bc@google.com>
On Thu Nov 13, 2025 at 9:01 PM AEDT, Alice Ryhl wrote:
> Creating workqueues is needed by various GPU drivers.
Indeed, and of course lots of other drivers need this as well. :)
> Not only does it give you better control over execution, it also allows
> devices to ensure that all tasks have exited before the device is unbound (or
> similar) by running the workqueue destructor.
Exactly, but for this case we should fence the workqueue with devres, such that
we can guarantee a scope for a &Device<Bound> for all work items scheduled on
such a workqueue, i.e. provide a &Device<Bound> in run().
Otherwise drivers have to either access device resources with try_access() or
get themselves a &Device<Bound> with the unsafe Device::as_bound() method from
within the run() callback.
next prev parent reply other threads:[~2025-11-13 21:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 10:01 [PATCH v2 0/2] Creation of workqueues in Rust Alice Ryhl
2025-11-13 10:01 ` [PATCH v2 1/2] rust: workqueue: restrict delayed work to global wqs Alice Ryhl
2025-11-13 10:06 ` Miguel Ojeda
2025-11-13 10:08 ` Alice Ryhl
2025-11-13 11:58 ` Miguel Ojeda
2025-11-13 20:40 ` John Hubbard
2025-11-13 21:06 ` Miguel Ojeda
2025-11-13 10:01 ` [PATCH v2 2/2] rust: workqueue: add creation of workqueues Alice Ryhl
2025-11-13 19:52 ` Boqun Feng
2025-11-14 9:44 ` Alice Ryhl
2025-11-13 21:55 ` Danilo Krummrich [this message]
2025-11-14 0:26 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE7WH5KQP268.1GXMZM78VIESE@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=phasta@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tj@kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).