From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEA62303C94; Mon, 17 Nov 2025 22:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763417249; cv=none; b=sTAqX2GxGvBZix89yj26OemJrXPv8VdNI7x6GcaPmgS9+wEfQECoFwBwsRLusCeAck98v0wH9LFByXhT4Wgz1Xw6W3dvoTt7zFNFrlRQYqbYFKNfATgRS6GVTx1v6A4QqnF7awmPvqu+VGL2PV6RTZJWPcnA0lpexwiPxFQScqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763417249; c=relaxed/simple; bh=G5kP84evxJ/rHjY7X0g6Ked+OOEAmAcqeB7BBk32zYA=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=fuOS+m9PoEh0R86BFJPbQZHYhkPf+Bf/RbFuoCBFSm6gXXzIU89JPSZZhwl9TMAIhWiCJWFu3mXhq8zivwAr0L9XMGlLnN01NL+tXICBcFYxyaXUcxg5DyAP2ZEAZ8KcD4Fmmii9h4bUoJV06GDsGiGKN7OF11T7VqS7E0V8WkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OwOKcyjJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OwOKcyjJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5F50C4CEF1; Mon, 17 Nov 2025 22:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763417248; bh=G5kP84evxJ/rHjY7X0g6Ked+OOEAmAcqeB7BBk32zYA=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=OwOKcyjJTcxujuWF3/3Yx56EEAvpX/ZDrNYDGO7+UGqC+Mzt2dmylhXEQTFlYIDB6 lbqsWJy73Aj8X+tyyvgvtUXRNDXBXNrgjv3cDGOXwKgBoAsSaCm5uHs3PJ2d30/EK+ CVV7bWIwqjad3N54Mo8kjf0af2PkVwvE/nRZr+AndBt9E4haJBxRCA4TdqnhJAV+Ky ErS12PsZ07UmkZv52gbA82b0XcCD4wFsWfhAEVOO+rBceQ4rp3Tzya+CLkVH/dOLtc AzJ/UrFoidjR3pT0v29NiufNrhUxm7Y+XrmSgwPj0pzddbRSfTj4iOXHbsfj0wE0lE tw2I5mroKaLTg== Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 18 Nov 2025 11:07:18 +1300 Message-Id: Subject: Re: [PATCH v6 RESEND 6/7] rust: pci: add config space read/write support Cc: "Zhi Wang" , , , , , , , , , , , , , , , , , , , , , , , , , To: "Joel Fernandes" From: "Danilo Krummrich" References: <20251110204119.18351-1-zhiw@nvidia.com> <20251110204119.18351-7-zhiw@nvidia.com> <20251114002005.GA2384907@joelbox2> In-Reply-To: <20251114002005.GA2384907@joelbox2> On Fri Nov 14, 2025 at 1:20 PM NZDT, Joel Fernandes wrote: > Also we should have a comment on why its safe for _ret to be ignored. > Basically what guarantees that the call is really infallible? Anything we= can > do to ensure errors are not silently ignored? Let me know if I missed > something. Please also see [1]. [1] https://lore.kernel.org/all/DE8PBRC48D14.IX6FUPOLLVHR@kernel.org/