rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Zhi Wang" <zhiw@nvidia.com>, "Alice Ryhl" <aliceryhl@google.com>
Cc: <rust-for-linux@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <dakr@kernel.org>,
	<bhelgaas@google.com>, <kwilczynski@kernel.org>,
	<ojeda@kernel.org>, <alex.gaynor@gmail.com>,
	<boqun.feng@gmail.com>, <gary@garyguo.net>,
	<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
	<a.hindborg@kernel.org>, <tmgross@umich.edu>,
	<markus.probst@posteo.de>, <helgaas@kernel.org>,
	<cjia@nvidia.com>, <smitra@nvidia.com>, <ankita@nvidia.com>,
	<aniketa@nvidia.com>, <kwankhede@nvidia.com>,
	<targupta@nvidia.com>, <acourbot@nvidia.com>,
	<joelagnelf@nvidia.com>, <jhubbard@nvidia.com>,
	<zhiwang@kernel.org>
Subject: Re: [PATCH v7 3/6] rust: io: factor common I/O helpers into Io trait
Date: Mon, 24 Nov 2025 22:53:34 +0900	[thread overview]
Message-ID: <DEGZ4G00CVTI.VAQH4O4HEXGF@nvidia.com> (raw)
In-Reply-To: <20251124153218.7694b78a.zhiw@nvidia.com>

On Mon Nov 24, 2025 at 10:32 PM JST, Zhi Wang wrote:
<snip>
>> But there is another problem: Bounded only supports the case where the
>> bound is a power of two, so I don't think it's usable here. You can
>> have Io regions whose size is not a power of two.
>
> Any suggestion on this? :) Should I implement something like
> BoundedOffset? Also would like to hear some inputs from Danilo as well.

Bounded integers were written with bitfields in mind and that is
reflected in the current implementation, but provided one can devise a
way to check for upper and lower bounds that is simple and works for
both signed and unsigned ints, there should be little standing in the
way of making it more granular and accepting any valid range as the
bounds constraint.

If this proves useful here and we can keep things simple for the
bitfield use-case, then making them more flexible is definitely an
option! :)

  reply	other threads:[~2025-11-24 13:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19 11:21 [PATCH v7 0/6] rust: pci: add config space read/write support Zhi Wang
2025-11-19 11:21 ` [PATCH v7 1/6] samples: rust: rust_driver_pci: use "kernel vertical" style for imports Zhi Wang
2025-11-19 11:21 ` [PATCH v7 2/6] rust: devres: " Zhi Wang
2025-11-19 11:21 ` [PATCH v7 3/6] rust: io: factor common I/O helpers into Io trait Zhi Wang
2025-11-21 14:20   ` Alice Ryhl
2025-11-24 10:08     ` Zhi Wang
2025-11-24 10:20       ` Alice Ryhl
2025-11-24 13:32         ` Zhi Wang
2025-11-24 13:53           ` Alexandre Courbot [this message]
2025-11-25 13:44     ` Alexandre Courbot
2025-11-25 14:58       ` Alice Ryhl
2025-11-26  0:43         ` Alexandre Courbot
2025-11-26  7:52         ` Alexandre Courbot
2025-11-26  9:50           ` Alice Ryhl
2025-11-26 13:37             ` Alexandre Courbot
2025-11-26 13:39               ` Alexandre Courbot
2025-12-01 11:57               ` Alexandre Courbot
2025-12-01 12:23                 ` Alice Ryhl
2025-12-03 13:32                   ` Alexandre Courbot
2025-11-25 14:09   ` Alexandre Courbot
2025-11-25 14:14     ` Alexandre Courbot
2025-11-25 14:22       ` Alice Ryhl
2025-11-25 14:46         ` Alexandre Courbot
2025-11-25 19:19           ` John Hubbard
2025-11-19 11:21 ` [PATCH v7 4/6] rust: io: factor out MMIO read/write macros Zhi Wang
2025-11-19 11:21 ` [PATCH v7 5/6] rust: pci: add config space read/write support Zhi Wang
2025-11-25 14:20   ` Alexandre Courbot
2025-11-19 11:21 ` [PATCH v7 6/6] sample: rust: pci: add tests for config space routines Zhi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DEGZ4G00CVTI.VAQH4O4HEXGF@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=aniketa@nvidia.com \
    --cc=ankita@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=cjia@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=helgaas@kernel.org \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=kwankhede@nvidia.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=markus.probst@posteo.de \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=smitra@nvidia.com \
    --cc=targupta@nvidia.com \
    --cc=tmgross@umich.edu \
    --cc=zhiw@nvidia.com \
    --cc=zhiwang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).