From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"John Hubbard" <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
Nouveau <nouveau-bounces@lists.freedesktop.org>
Subject: Re: [PATCH v2 0/4] gpu: nova-core: Fixups for GSP message queue and bindings
Date: Mon, 08 Dec 2025 19:06:15 +0900 [thread overview]
Message-ID: <DESR20OF30KU.1DCTWADJUFIM9@nvidia.com> (raw)
In-Reply-To: <20251123-nova-fixes-v2-0-33d86092cf6a@nvidia.com>
On Sun Nov 23, 2025 at 2:12 PM JST, Alexandre Courbot wrote:
> This series contains a few fixups for the recently merged GSP
> command-queue code, by order of importance:
>
> - Some explicit padding required to safely implement `AsBytes` was
> missing in the bindings,
> - A bug in the received message length calculation results in the
> message handler being given more data than it should,
> - `MaybeZeroable` is now derived by the kernel's bindgen, but the Nova
> bindings have not been updated for that,
> - Some items in the bindings were referred to using the version module
> directly, instead of the alias we defined to limit the diff when we
> upgrade firmware versions.
>
> All of them address "bugs" (with the first two fixing actual correctness
> issues), but since Nova does not do much anyway, they are also not
> absolutely critical and can wait -rc1 if we prefer to do so.
Alice, Danilo, how would you like to proceed with this series? We could
either:
* Merge this into `drm-rust-next` if you are planning on sending another
before -rc1,
* Wait until -rc1 gets released and send it via `drm-rust-fixes` for
-rc2,
* ... or just take it for 6.20, as it is not absolutely critical.
I am not very familiar with how to do things after the merge window has
opened, so appreciate your guidance here.
next prev parent reply other threads:[~2025-12-08 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-23 5:12 [PATCH v2 0/4] gpu: nova-core: Fixups for GSP message queue and bindings Alexandre Courbot
2025-11-23 5:12 ` [PATCH v2 1/4] gpu: nova-core: bindings: Add missing explicit padding Alexandre Courbot
2025-11-25 20:54 ` Lyude Paul
2025-11-23 5:12 ` [PATCH v2 2/4] gpu: nova-core: gsp: Fix length of received messages Alexandre Courbot
2025-11-25 20:55 ` Lyude Paul
2025-11-23 5:12 ` [PATCH v2 3/4] gpu: nova-core: bindings: Derive `MaybeZeroable` Alexandre Courbot
2025-11-25 20:56 ` Lyude Paul
2025-11-23 5:12 ` [PATCH v2 4/4] gpu: nova-core: gsp: Replace firmware version with "bindings" alias Alexandre Courbot
2025-11-25 20:57 ` Lyude Paul
2025-12-08 10:06 ` Alexandre Courbot [this message]
2025-12-11 23:02 ` [PATCH v2 0/4] gpu: nova-core: Fixups for GSP message queue and bindings Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DESR20OF30KU.1DCTWADJUFIM9@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau-bounces@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).