Re: [PATCH v3 04/12] gpu: nova-core: add support for Turing/GA100 fwsignature

["Alexandre Courbot" <acourbot@nvidia.com>]

On Tue Dec 9, 2025 at 8:17 AM JST, Timur Tabi wrote:
> Turing and GA100 share the same GSP-RM firmware binary, and the
> signature ELF section is labeled ".fwsignature_tu10x".
>
> Signed-off-by: Timur Tabi <ttabi@nvidia.com>
> ---
>  drivers/gpu/nova-core/firmware/gsp.rs | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/nova-core/firmware/gsp.rs b/drivers/gpu/nova-core/firmware/gsp.rs
> index 0549805282ab..aa5a6433c377 100644
> --- a/drivers/gpu/nova-core/firmware/gsp.rs
> +++ b/drivers/gpu/nova-core/firmware/gsp.rs
> @@ -163,9 +163,14 @@ pub(crate) fn new<'a, 'b>(
>          let fw_section = elf::elf64_section(fw.data(), ".fwimage").ok_or(EINVAL)?;
>  
>          let sigs_section = match chipset.arch() {
> -            Architecture::Ampere => ".fwsignature_ga10x",
> +            Architecture::Turing | Architecture::Ampere =>
> +                if chipset > Chipset::GA100 {
> +                    ".fwsignature_ga10x"
> +                } else {
> +                    // GA100 uses the same firmware as Turing
> +                    ".fwsignature_tu10x"
> +                },

Please use the pattern discussed in [1] here as it better expresses the
exception for GA100.

[1] https://lore.kernel.org/all/0f11194b-edb4-4206-9a6c-b7ada3cba3e8@nvidia.com/