From: "Benno Lossin" <lossin@kernel.org>
To: "Lyude Paul" <lyude@redhat.com>, <rust-for-linux@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>, "Will Deacon" <will@kernel.org>,
"Waiman Long" <longman@redhat.com>
Subject: Re: [PATCH v16 15/17] rust: sync: lock/global: Add Backend parameter to GlobalGuard
Date: Mon, 22 Dec 2025 07:27:33 +0100 [thread overview]
Message-ID: <DF4J677NSJDC.3QY743918HBOI@kernel.org> (raw)
In-Reply-To: <20251215175806.102713-16-lyude@redhat.com>
On Mon Dec 15, 2025 at 6:58 PM CET, Lyude Paul wrote:
> @@ -94,11 +94,11 @@ pub fn try_lock(&'static self) -> Option<GlobalGuard<'static, G>> {
> /// A guard for a [`GlobalLock`].
> ///
> /// See [`global_lock!`] for examples.
> -pub struct GlobalGuard<'a, G: GlobalLockBackend> {
> - inner: Guard<'a, G::Item, G::Backend>,
> +pub struct GlobalGuard<'a, G: GlobalLockBackend, B: Backend> {
Could be useful to make `B` have a default value of `G::Backend`?
Reviewed-by: Benno Lossin <lossin@kernel.org>
Cheers,
Benno
> + inner: Guard<'a, G::Item, B>,
> }
>
> -impl<'a, G: GlobalLockBackend> core::ops::Deref for GlobalGuard<'a, G> {
> +impl<'a, G: GlobalLockBackend, B: Backend> core::ops::Deref for GlobalGuard<'a, G, B> {
> type Target = G::Item;
>
> fn deref(&self) -> &Self::Target {
next prev parent reply other threads:[~2025-12-22 6:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 17:57 [PATCH v16 00/17] Refcounted interrupts, SpinLockIrq for rust Lyude Paul
2025-12-15 17:57 ` [PATCH v16 01/17] preempt: Introduce HARDIRQ_DISABLE_BITS Lyude Paul
2025-12-15 17:57 ` [PATCH v16 02/17] preempt: Track NMI nesting to separate per-CPU counter Lyude Paul
2025-12-15 17:57 ` [PATCH v16 03/17] preempt: Introduce __preempt_count_{sub, add}_return() Lyude Paul
2025-12-15 17:57 ` [PATCH v16 04/17] openrisc: Include <linux/cpumask.h> in smp.h Lyude Paul
2025-12-15 21:54 ` Stafford Horne
2025-12-15 17:57 ` [PATCH v16 05/17] irq & spin_lock: Add counted interrupt disabling/enabling Lyude Paul
2025-12-15 17:57 ` [PATCH v16 06/17] irq: Add KUnit test for refcounted interrupt enable/disable Lyude Paul
2025-12-15 17:57 ` [PATCH v16 07/17] rust: Introduce interrupt module Lyude Paul
2025-12-15 17:57 ` [PATCH v16 08/17] rust: helper: Add spin_{un,}lock_irq_{enable,disable}() helpers Lyude Paul
2025-12-16 12:15 ` Gary Guo
2025-12-15 17:57 ` [PATCH v16 09/17] rust: sync: Add SpinLockIrq Lyude Paul
2025-12-16 12:20 ` Gary Guo
2025-12-22 5:50 ` Benno Lossin
2025-12-15 17:57 ` [PATCH v16 10/17] rust: sync: Introduce lock::Backend::Context Lyude Paul
2025-12-22 6:10 ` Benno Lossin
2025-12-15 17:57 ` [PATCH v16 11/17] rust: sync: lock: Add `Backend::BackendInContext` Lyude Paul
2025-12-22 6:19 ` Benno Lossin
2025-12-15 17:57 ` [PATCH v16 12/17] rust: sync: lock/global: Rename B to G in trait bounds Lyude Paul
2025-12-16 16:15 ` Dirk Behme
2025-12-17 20:33 ` Boqun Feng
2025-12-22 6:23 ` Benno Lossin
2025-12-15 17:58 ` [PATCH v16 13/17] rust: sync: Add a lifetime parameter to lock::global::GlobalGuard Lyude Paul
2025-12-22 6:28 ` Benno Lossin
2025-12-15 17:58 ` [PATCH v16 14/17] rust: sync: Expose lock::Backend Lyude Paul
2025-12-22 6:27 ` Benno Lossin
2025-12-15 17:58 ` [PATCH v16 15/17] rust: sync: lock/global: Add Backend parameter to GlobalGuard Lyude Paul
2025-12-22 6:27 ` Benno Lossin [this message]
2025-12-15 17:58 ` [PATCH v16 16/17] rust: sync: lock/global: Add BackendInContext support to GlobalLock Lyude Paul
2025-12-22 6:25 ` Benno Lossin
2025-12-15 17:58 ` [PATCH v16 17/17] locking: Switch to _irq_{disable,enable}() variants in cleanup guards Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF4J677NSJDC.3QY743918HBOI@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lyude@redhat.com \
--cc=mingo@redhat.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox