From: "Benno Lossin" <lossin@kernel.org>
To: "Tamir Duberstein" <tamird@gmail.com>,
"Benno Lossin" <benno.lossin@proton.me>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: pin_init_internal: fix rust-analyzer `mod quote`
Date: Tue, 23 Dec 2025 02:32:36 +0100 [thread overview]
Message-ID: <DF57IWUPXAHM.27OHGD93IW5W@kernel.org> (raw)
In-Reply-To: <CAJ-ks9n6wtA45+sJ2ZiL4KJ4MK0eaWomoDTN6d04oseJ-gmavw@mail.gmail.com>
On Mon Dec 22, 2025 at 1:43 PM CET, Tamir Duberstein wrote:
> On Thu, Mar 20, 2025 at 3:15 PM Tamir Duberstein <tamird@gmail.com> wrote:
>>
>> On Thu, Mar 20, 2025 at 10:10 AM Benno Lossin <benno.lossin@proton.me> wrote:
>> >
>> > On Thu Mar 20, 2025 at 2:31 PM CET, Tamir Duberstein wrote:
>> > > On Thu, Mar 20, 2025 at 8:16 AM Benno Lossin <benno.lossin@proton.me> wrote:
>> > >> I'd rather not have this change, since this will introduce a dangling
>> > >> symlink upstream [1].
>> > >>
>> > >> [1]: https://github.com/rust-for-Linux/pin-init
>> > >
>> > > I agree it's aesthetically displeasing. I'm not aware of any
>> > > alternative that fixes the development workflow of this crate in the
>> > > kernel.
>> >
>> > I don't think it's too bad, and this code is going away soon-ish
>> > anyways.
>>
>> What would Andreas say? :)
>>
>> I don't think the going away soon argument is relevant in this case -
>> the same applies to the dangling symlink.
>
> 9 months later, this code is still here. What would make it go away?
The pin-init `syn` changes will land this cycle, which removes this
code.
Cheers,
Benno
prev parent reply other threads:[~2025-12-23 1:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 1:35 [PATCH] rust: pin_init_internal: fix rust-analyzer `mod quote` Tamir Duberstein
2025-03-20 7:46 ` Alice Ryhl
2025-03-20 10:16 ` Tamir Duberstein
2025-03-20 12:16 ` Benno Lossin
2025-03-20 13:31 ` Tamir Duberstein
2025-03-20 14:10 ` Benno Lossin
2025-03-20 14:15 ` Tamir Duberstein
2025-12-22 12:43 ` Tamir Duberstein
2025-12-23 1:32 ` Benno Lossin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF57IWUPXAHM.27OHGD93IW5W@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox