From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50F152690F9; Tue, 23 Dec 2025 19:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766519424; cv=none; b=iHCwNGNc3/82XhJysA5Z4r2zdo7ZJElp7P6z1r4LeIAMGMNtp7tQPQHGV+iOAxxGIpJ5H8xqcjlIPoZkGGIoObeG/M2wEKL673NsO5w50BejRV+wSFitw48z6qv3NAl3g100vHnYheqEMlZwus29ofVaOQB4MuJ6jsltP++S7sY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766519424; c=relaxed/simple; bh=msWbe6o7wz9buRvDCWTrSNFnWDRlPCmecbHKGjIgAgs=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=oFFEX2cKaoeOeqkdgxbgegEZvc+zv7vHgFe8U+TWPcH2ynNvZ2/cXU2mgK8jks2s2jsiNGhtNliPIxU5jhA9DwXU3PD/tVNwhgreaoXsz7XjLWhc4QDWHFXuutm9ds434VvHJuh/hbVThRuSQsUkd3uhTftxfAJvcYiGHHJ1oSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KLwqTDqu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KLwqTDqu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAD8AC116D0; Tue, 23 Dec 2025 19:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766519423; bh=msWbe6o7wz9buRvDCWTrSNFnWDRlPCmecbHKGjIgAgs=; h=Date:To:Cc:Subject:From:References:In-Reply-To:From; b=KLwqTDqu73l6w1YiNRuSN0mGSgJsFE9DFpvxBnRLRtLIanySqPhA35VlQH6cgNJlN vWrYNq4EJJONFSG8BO8PU4V+tzZRtwYKfqzaVI753wAHfTWt2uWtXiyJvIkwsm7Lqj 5/wYvSVb2sGL6GEDQYaCSlyF6KHUgTQ1kLX5HtzPjMbBzduP8ccc8EfcsHAnxig+cj NRh0d+PLW7Xhf3XuNVGoHVZXmZDdEGbPYaBWXkX903bpLkiiTFP0Id5JIpxjwstNpK ASL0+WdwVHEBNh/tfDWNzBqOYL2B3Wjjr0TYNvXDpJGQX7dEihfvAWdKb7ngQw6ztZ yRIhiPBuKUoUQ== Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 23 Dec 2025 20:50:14 +0100 Message-Id: To: "Gary Guo" , "Peter Zijlstra" , "Ingo Molnar" , "Arnaldo Carvalho de Melo" , "Namhyung Kim" , "Mark Rutland" , "Alexander Shishkin" , "Jiri Olsa" , "Ian Rogers" , "Adrian Hunter" , "James Clark" , "Miguel Ojeda" , "Boqun Feng" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Danilo Krummrich" , "Nathan Chancellor" , "Nick Desaulniers" , "Bill Wendling" , "Justin Stitt" , "Andi Kleen" , "Dmitry Vyukov" , "Stephen Brennan" Cc: "Arnaldo Carvalho de Melo" , , , , Subject: Re: [PATCH] perf symbol: remove Rust symbol workarounds From: "Benno Lossin" X-Mailer: aerc 0.21.0 References: <20251223175216.1353814-1-gary@kernel.org> In-Reply-To: <20251223175216.1353814-1-gary@kernel.org> On Tue Dec 23, 2025 at 6:52 PM CET, Gary Guo wrote: > From: Gary Guo > > Due to an off-by-one error introduced in commit 73bbb94466fd ("kallsyms: > support "big" kernel symbols"), long symbols (which are currently only > produced by Rust) can have their symbol type being wrongly parsed by > kernel/kallsyms.c. > > This has been fixed in commit f3f9f42232dee5 ("kallsyms: Fix wrong "big" > kernel symbol type read from procfs"), and these symbols are now > reported correctly. > > Drop the workaround in perf symbol that filter out these symbol types. > > Specifically, '1' and 'l' can never be generated by nm -- 'u' does > indicate GNU unique, however such symbols are only generated by G++ for > C++ templates, and are never generated by LLVM (LLVM generates weak > symbols in such cases instead). Therefore, the previous occurrence of > these symbols types must be due to the off-by-error and can be safely Typo: off-by-one error Cheers, Benno > removed. > > Cc: Arnaldo Carvalho de Melo > Cc: Miguel Ojeda > Signed-off-by: Gary Guo > --- > tools/perf/util/symbol.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-)