From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Jesung Yang" <y.j3ms.n@gmail.com>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: <rust-for-linux@vger.kernel.org>, <nouveau@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] rust: add `TryFrom` and `Into` derive macros
Date: Thu, 25 Dec 2025 16:32:18 +0900 [thread overview]
Message-ID: <DF74FEXHESCV.3L0KB1DLDMFTV@nvidia.com> (raw)
In-Reply-To: <cover.1766544407.git.y.j3ms.n@gmail.com>
On Wed Dec 24, 2025 at 12:59 PM JST, Jesung Yang wrote:
> This patch series introduces derive macros for the `TryFrom` and `Into`
> traits.
>
> Primary updates in v3:
> - Adopt `syn` for improved macro parsing.
> - Allow `kernel::num::Bounded` to be specified in helper attributes,
> enabling the generation of `TryFrom` and `Into` implementations for
> types with restricted bit ranges as required by the nova-core [1].
> - Add compile-time overflow assertion to ensure that enum discriminants
> fit within the types being converted to or from, preventing silent
> overflows.
>
> Note: 1015+ insertions are purely from doctests. Most of them are kept
> private to keep the public API documentation clean and simple for
> users. This might not be the usual way of doing things, but for now I
> don't think I have a better option. Feedback and suggestions are always
> appreciated.
>
> [1] https://lore.kernel.org/rust-for-linux/DDHU4LL4GGIY.16OJMIL7ZK58P@nvidia.com/
>
> Best regards,
> Jesung
Hi Jesung,
I'm really looking forward to reviewing this one, but for some reason
patches 1 and 2 appear to not have been sent. They don't even appear on
lore: https://lore.kernel.org/all/cover.1766544407.git.y.j3ms.n@gmail.com/
next prev parent reply other threads:[~2025-12-25 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-24 3:59 [PATCH v3 0/4] rust: add `TryFrom` and `Into` derive macros Jesung Yang
2025-12-24 3:59 ` [PATCH v3 3/4] rust: macros: add private doctests for `Into` derive macro Jesung Yang
2025-12-24 3:59 ` [PATCH v3 4/4] rust: macros: add private doctests for `TryFrom` " Jesung Yang
2025-12-25 7:32 ` Alexandre Courbot [this message]
2025-12-25 7:56 ` [PATCH v3 0/4] rust: add `TryFrom` and `Into` derive macros Jesung Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF74FEXHESCV.3L0KB1DLDMFTV@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=y.j3ms.n@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox