* [PATCH v2] rust: device_id: replace incorrect word in safety documentation
@ 2025-12-28 16:53 Yilin Chen
2025-12-29 14:07 ` Danilo Krummrich
0 siblings, 1 reply; 2+ messages in thread
From: Yilin Chen @ 2025-12-28 16:53 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rafael J . Wysocki, Danilo Krummrich,
Miguel Ojeda
Cc: rust-for-linux, linux-kernel, Yilin Chen
The safety documentation incorrectly refers to `RawDeviceId` when
transmuting to `RawType`. This fixes the documentation to correctly
indicate that implementers must ensure layout compatibility with
`RawType`, not `RawDeviceId`.
Signed-off-by: Yilin Chen <1479826151@qq.com>
---
Changes in v2:
- Changed subject (Kari Argillander)
- Use real name in signed-off-by line (Kari Argillander)
- Link to v1: https://lore.kernel.org/rust-for-linux/tencent_9F74630DC16B92484463BBC055DEB1F17306@qq.com/
---
rust/kernel/device_id.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/device_id.rs b/rust/kernel/device_id.rs
index 62c42da12e9d..8e9721446014 100644
--- a/rust/kernel/device_id.rs
+++ b/rust/kernel/device_id.rs
@@ -15,7 +15,7 @@
/// # Safety
///
/// Implementers must ensure that `Self` is layout-compatible with [`RawDeviceId::RawType`];
-/// i.e. it's safe to transmute to `RawDeviceId`.
+/// i.e. it's safe to transmute to `RawType`.
///
/// This requirement is needed so `IdArray::new` can convert `Self` to `RawType` when building
/// the ID table.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] rust: device_id: replace incorrect word in safety documentation
2025-12-28 16:53 [PATCH v2] rust: device_id: replace incorrect word in safety documentation Yilin Chen
@ 2025-12-29 14:07 ` Danilo Krummrich
0 siblings, 0 replies; 2+ messages in thread
From: Danilo Krummrich @ 2025-12-29 14:07 UTC (permalink / raw)
To: Yilin Chen
Cc: Greg Kroah-Hartman, Rafael J . Wysocki, Miguel Ojeda,
rust-for-linux, linux-kernel
On Sun Dec 28, 2025 at 5:53 PM CET, Yilin Chen wrote:
> The safety documentation incorrectly refers to `RawDeviceId` when
> transmuting to `RawType`. This fixes the documentation to correctly
> indicate that implementers must ensure layout compatibility with
> `RawType`, not `RawDeviceId`.
>
Fixes: 9b90864bb42b ("rust: implement `IdArray`, `IdTable` and `RawDeviceId`")
> Signed-off-by: Yilin Chen <1479826151@qq.com>
Applied to driver-core-linus, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-29 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-28 16:53 [PATCH v2] rust: device_id: replace incorrect word in safety documentation Yilin Chen
2025-12-29 14:07 ` Danilo Krummrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox