Re: [PATCH v8 2/4] rust: kernel: Add pointer wrapper types for safe pointer formatting

["Danilo Krummrich" <dakr@kernel.org>]

On Fri Jan 2, 2026 at 1:17 PM CET, Andy Shevchenko wrote:
> On Thu, Jan 01, 2026 at 04:16:02PM +0800, Ke Sun wrote:
>> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Definitely wrong tag here. Please, do not apply random tags on behalf of
> others. You must get it explicitly.

Ke, just to avoid any confusion, it also strongly depends on the situation.

There are tags that are commonly used without getting it explicitly;
'Reported-by:' for instance.

For the 'Suggested-by:' tag it depends, if the situation is 100% clear it is not
uncommon to just add the tag, but in general - but especially if in doubt - it
is usually better to ask.

It also sometimes happens that maintainers convert a "LGTM" or "I agree with
this patch.", etc. to an 'Acked-by:'. This sometimes happens with new
contributors, but in general 'Acked-by:' is (and should be) given explicitly.

For things like 'Suggested-by:' I also recommend to add a 'Link:' tag with the
source of the suggestion.

Please also have a look at [1], which explains which tags require permission.

I hope this helps!

- Danilo

[1] https://docs.kernel.org/process/submitting-patches.html#tagging-people-requires-permission