From: "Danilo Krummrich" <dakr@kernel.org>
To: "FUJITA Tomonori" <fujita.tomonori@gmail.com>
Cc: <gregkh@linuxfoundation.org>, <ojeda@kernel.org>,
<rafael@kernel.org>, <aliceryhl@google.com>,
<a.hindborg@kernel.org>, <abdiel.janulgue@gmail.com>,
<bjorn3_gh@protonmail.com>, <boqun.feng@gmail.com>,
<daniel.almeida@collabora.com>, <gary@garyguo.net>,
<lossin@kernel.org>, <robin.murphy@arm.com>, <tmgross@umich.edu>,
<rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] rust: dma: fix broken intra-doc links
Date: Fri, 02 Jan 2026 19:08:30 +0100 [thread overview]
Message-ID: <DFEAYVOFWITO.PZZWUJNNHX60@kernel.org> (raw)
In-Reply-To: <20251231045728.1912024-1-fujita.tomonori@gmail.com>
On Wed Dec 31, 2025 at 5:57 AM CET, FUJITA Tomonori wrote:
> The `pci` module is conditional on CONFIG_PCI. When it's disabled, the
> intra-doc like to `pci::Device` cause rustdoc warnings:
>
> warning: unresolved link to `::kernel::pci::Device`
> --> rust/kernel/dma.rs:30:70
> |
> 30 | /// where the underlying bus is DMA capable, such as [`pci::Device`](::kernel::pci::Device) or
> | ^^^^^^^^^^^^^^^^^^^^^ no item named `pci` in module `kernel`
>
> Fix this by making the documentation conditional on CONFIG_PCI.
>
> Fixes: d06d5f66f549 ("rust: dma: implement `dma::Device` trait")
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
Applied to driver-core-linus, thanks!
[ Keep the "such as" part indicating a list of examples; fix typos in
commit message. - Danilo ]
prev parent reply other threads:[~2026-01-02 18:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 4:57 [PATCH v1 1/2] rust: dma: fix broken intra-doc links FUJITA Tomonori
2025-12-31 4:57 ` [PATCH v1 2/2] rust: device: " FUJITA Tomonori
2026-01-02 18:08 ` Danilo Krummrich
2025-12-31 6:08 ` [PATCH v1 1/2] rust: dma: " Dirk Behme
2025-12-31 9:07 ` FUJITA Tomonori
2025-12-31 16:13 ` Danilo Krummrich
2026-01-02 7:49 ` Dirk Behme
2026-01-02 18:08 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFEAYVOFWITO.PZZWUJNNHX60@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox