public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: 하승종 <engineer.jjhama@gmail.com>
Cc: "SeungJong Ha via B4 Relay"
	<devnull+engineer.jjhama.gmail.com@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: pci: add HeaderType enum and header_type() helper
Date: Sun, 04 Jan 2026 14:40:14 +0100	[thread overview]
Message-ID: <DFFUIKLNVQB6.3UDMOX8TB5XDQ@kernel.org> (raw)
In-Reply-To: <CAGAB6648kOCF4GZV=wKUxEptzW_91BySPMqFSjE+L-TA3ufH-g@mail.gmail.com>

On Sat Jan 3, 2026 at 4:39 PM CET, 하승종 wrote:
> 2026년 1월 4일 (일) AM 12:17, Danilo Krummrich <dakr@kernel.org>님이 작성:
>>
>> On Sat Jan 3, 2026 at 3:38 PM CET, SeungJong Ha via B4 Relay wrote:
>> > This is my first patch to the Linux kernel, specifically targeting the
>> > Rust PCI subsystem.
>>
>> Thanks for your contribution!
>>
>> > This patch introduces the HeaderType enum to represent PCI configuration
>> > space header types (Normal and Bridge) and implements the header_type()
>> > method in the Device struct.
>>
>> We usually do not add dead code in the kernel. Do you work on a user for this
>> API?
>
> Hi Danilo, Thanks for your feedback.
>
> Yes, I am currently developing a Rust-based driver for nvme and ixgbe devices,
> which requires identifying the header type to check compatibility on
> initialization.
> I sent this patch first as it provides a foundational API for the PCI
> abstraction.

As Miguel also pointed out in his reply, I'd like to see a patch series with the
driver as an RFC patch.

If it is working, not too far from an "upstreamable" state and the subsystem
maintainers of the driver's target subsystem are indicating willingness to
eventually take the driver, I'm happy to go ahead and merge any dependencies.

- Danilo

  parent reply	other threads:[~2026-01-04 13:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-03 14:38 [PATCH] rust: pci: add HeaderType enum and header_type() helper SeungJong Ha via B4 Relay
2026-01-03 15:17 ` Danilo Krummrich
2026-01-03 15:39   ` 하승종
2026-01-04 12:31     ` Miguel Ojeda
2026-01-04 13:40     ` Danilo Krummrich [this message]
2026-01-04 14:23       ` 하승종

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFFUIKLNVQB6.3UDMOX8TB5XDQ@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=devnull+engineer.jjhama.gmail.com@kernel.org \
    --cc=engineer.jjhama@gmail.com \
    --cc=gary@garyguo.net \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox