From: "Benno Lossin" <lossin@kernel.org>
To: "Tamir Duberstein" <tamird@gmail.com>, "Gary Guo" <gary@garyguo.net>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Fiona Behrens" <me@kloenk.dev>,
"Christian Schrefl" <chrisi.schrefl@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] rust: pin-init: internal: remove proc-macro[2] and quote workarounds
Date: Mon, 05 Jan 2026 09:53:23 +0100 [thread overview]
Message-ID: <DFGJ1HIK35BN.3RLLMFT1PLP0C@kernel.org> (raw)
In-Reply-To: <CAJ-ks9=Q53FX=5TdLoYnM3pgtDo23nHjFy7e7B=-02-U0vZ+Qw@mail.gmail.com>
On Sun Jan 4, 2026 at 2:35 PM CET, Tamir Duberstein wrote:
> On Thu, Dec 11, 2025 at 2:28 PM Gary Guo <gary@kernel.org> wrote:
>>
>> From: Benno Lossin <lossin@kernel.org>
>>
>> The kernel only had the `proc-macro` library available, whereas the
>> user-space version also used `proc-macro2` and `quote`. Now both are
>> available to the kernel, making it possible to remove the workarounds.
>>
>> Signed-off-by: Benno Lossin <lossin@kernel.org>
>> Co-developed-by: Gary Guo <gary@garyguo.net>
>> Signed-off-by: Gary Guo <gary@garyguo.net>
>
> This adds a dependency edge from pin-init-internal to syn, but syn is
> not actually used in pin-init or pin-init-internal.
>
> There's a comment in rust/pin-init/src/macros.rs that suggests syn
> might be used in the future, but as of this comment this is a dead
> dependency edge.
I have a patchset prepared in [1] and plan to send that this cycle.
[1]: https://github.com/Rust-for-Linux/pin-init/pull/89
Cheers,
Benno
next prev parent reply other threads:[~2026-01-05 8:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 18:56 [PATCH 00/11] refactor Rust proc macros with `syn` Gary Guo
2025-12-11 18:56 ` [PATCH 01/11] rust: pin-init: internal: remove proc-macro[2] and quote workarounds Gary Guo
2025-12-11 21:50 ` Christian Schrefl
2025-12-15 13:01 ` Gary Guo
2025-12-16 9:43 ` Benno Lossin
2026-01-04 13:35 ` Tamir Duberstein
2026-01-05 8:53 ` Benno Lossin [this message]
2025-12-11 18:56 ` [PATCH 02/11] rust: macros: use `quote!` from vendored crate Gary Guo
2025-12-16 9:47 ` Benno Lossin
2026-01-04 13:39 ` Tamir Duberstein
2025-12-11 18:56 ` [PATCH 03/11] rust: macros: convert `#[vtable]` macro to use `syn` Gary Guo
2026-01-04 23:44 ` Tamir Duberstein
2026-01-05 2:17 ` Gary Guo
2026-01-05 11:02 ` Tamir Duberstein
2026-01-05 14:27 ` Gary Guo
2026-01-05 15:19 ` Tamir Duberstein
2026-01-05 16:05 ` Gary Guo
2025-12-11 18:56 ` [PATCH 04/11] rust: macros: use `syn` to parse `module!` macro Gary Guo
2026-01-04 22:53 ` Tamir Duberstein
2026-01-05 2:20 ` Gary Guo
2025-12-11 18:56 ` [PATCH 05/11] rust: macros: use `quote!` for " Gary Guo
2026-01-04 21:34 ` Tamir Duberstein
2025-12-11 18:56 ` [PATCH 06/11] rust: macros: convert `#[export]` to use `syn` Gary Guo
2025-12-22 6:39 ` Benno Lossin
2026-01-04 22:56 ` Tamir Duberstein
2025-12-11 18:56 ` [PATCH 07/11] rust: macros: convert `concat_idents!` " Gary Guo
2025-12-22 6:34 ` Benno Lossin
2025-12-22 11:59 ` Gary Guo
2026-01-04 22:59 ` Tamir Duberstein
2025-12-11 18:56 ` [PATCH 08/11] rust: macros: convert `#[kunit_tests]` macro " Gary Guo
2026-01-04 23:38 ` Tamir Duberstein
2026-01-05 2:28 ` Gary Guo
2025-12-11 18:56 ` [PATCH 09/11] rust: macros: allow arbitrary types to be used in `module!` macro Gary Guo
2025-12-22 6:36 ` Benno Lossin
2026-01-04 23:42 ` Tamir Duberstein
2025-12-11 18:56 ` [PATCH 10/11] rust: macros: rearrange `#[doc(hidden)]` " Gary Guo
2025-12-22 6:37 ` Benno Lossin
2026-01-04 23:42 ` Tamir Duberstein
2025-12-11 18:56 ` [PATCH 11/11] rust: kunit: use `pin_init::zeroed` instead of custom null value Gary Guo
2025-12-16 12:48 ` Benno Lossin
2026-01-04 23:43 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFGJ1HIK35BN.3RLLMFT1PLP0C@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=chrisi.schrefl@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=me@kloenk.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox