Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Shankari Anand]

On Sat, Jan 03, 2026 at 05:28:31AM +0100, kernel test robot wrote:
> Hi Shankari,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on staging/staging-next staging/staging-linus rust/rust-next usb/usb-testing usb/usb-next usb/usb-linus next-20251219]
> [cannot apply to linus/master v6.16-rc1]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Shankari-Anand/rust-i2c-Update-ARef-and-AlwaysRefCounted-imports-to-use-sync-aref/20260103-061451
> base:   staging/staging-testing
> patch link:    https://lore.kernel.org/r/20260102202714.184223-5-shankari.ak0208%40gmail.com
> patch subject: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted
> config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260103/202601030523.4eFrzaYI-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260103/202601030523.4eFrzaYI-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202601030523.4eFrzaYI-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> error[E0432]: unresolved import `crate::types::ARef`
>    --> rust/kernel/device/property.rs:17:13
>    |
>    17 |     types::{ARef, Opaque},
>    |             ^^^^ no `ARef` in `types`
>    |
>    = help: consider importing this struct instead:
>    crate::sync::aref::ARef
> --


Hello Miguel and all,

> >> error[E0432]: unresolved import `crate::types::ARef`
>    --> rust/kernel/scatterlist.rs:41:13
>    |
>    41 |     types::{ARef, Opaque},
>    |             ^^^^ no `ARef` in `types`
>    |
>    = help: consider importing this struct instead:
>    crate::sync::aref::ARef
> --

This change has already been made in [1]. Probably it has showed up on the linux-next
recently which has caused the kernel bot to detect the error.


> >> error[E0405]: cannot find trait `AlwaysRefCounted` in module `crate::types`
>    --> rust/kernel/device/property.rs:362:27
>    |
>    362 | unsafe impl crate::types::AlwaysRefCounted for FwNode {
>    |                           ^^^^^^^^^^^^^^^^ not found in `crate::types`
>    |
>    help: consider importing this trait
>    |
>    7   + use crate::sync::aref::AlwaysRefCounted;
>    |
>    help: if you import `AlwaysRefCounted`, refer to it directly
>    |
>    362 - unsafe impl crate::types::AlwaysRefCounted for FwNode {
>    362 + unsafe impl AlwaysRefCounted for FwNode {
>    |
> 
> --

I haven't raised a patch for this file change I suppose. Should I do it in the same patch v3
or put up a separate patch and reference it there?
 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


Please let me know which one would be appropriate and accordingly I'll send the revised patch.
I'll try to complete this refactoring soon. Sincere apologies that this has been going since quite a while now.

Thanks a lot!

Regards,
Shankari

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Shankari Anand]

On Wed, Jan 07, 2026 at 08:09:35PM +0530, Shankari Anand wrote:
> 
> 
> Hello Miguel and all,
> 
> > >> error[E0432]: unresolved import `crate::types::ARef`
> >    --> rust/kernel/scatterlist.rs:41:13
> >    |
> >    41 |     types::{ARef, Opaque},
> >    |             ^^^^ no `ARef` in `types`
> >    |
> >    = help: consider importing this struct instead:
> >    crate::sync::aref::ARef
> > --
> 
> This change has already been made in [1]. Probably it has showed up on the linux-next
> recently which has caused the kernel bot to detect the error.
> 
> 
> > >> error[E0405]: cannot find trait `AlwaysRefCounted` in module `crate::types`
> >    --> rust/kernel/device/property.rs:362:27
> >    |
> >    362 | unsafe impl crate::types::AlwaysRefCounted for FwNode {
> >    |                           ^^^^^^^^^^^^^^^^ not found in `crate::types`
> >    |
> >    help: consider importing this trait
> >    |
> >    7   + use crate::sync::aref::AlwaysRefCounted;
> >    |
> >    help: if you import `AlwaysRefCounted`, refer to it directly
> >    |
> >    362 - unsafe impl crate::types::AlwaysRefCounted for FwNode {
> >    362 + unsafe impl AlwaysRefCounted for FwNode {
> >    |
> > 
> > --
> 
> I haven't raised a patch for this file change I suppose. Should I do it in the same patch v3
> or put up a separate patch and reference it there?
>  
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> 
> 
> Please let me know which one would be appropriate and accordingly I'll send the revised patch.
> I'll try to complete this refactoring soon. Sincere apologies that this has been going since quite a while now.
> 
> Thanks a lot!
> 
> Regards,
> Shankari


Apologies, I forgot to link [1]


[1] - https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2da67beda68776842fd0a26f2374e42a5e9b12c8

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Miguel Ojeda]

On Wed, Jan 7, 2026 at 5:37 PM Shankari Anand <shankari.ak0208@gmail.com> wrote:
>
> Hello Miguel and all,
>
> This change has already been made in [1]. Probably it has showed up on the linux-next
> recently which has caused the kernel bot to detect the error.
>
> I haven't raised a patch for this file change I suppose. Should I do it in the same patch v3
> or put up a separate patch and reference it there?

If you mean the `FwNode` one you quoted, then I see it in commit
2e2b4135d1cb ("rust: device: Update ARef and AlwaysRefCounted imports
from sync::aref") which is in -next, so that should be fine.

Thanks!

Cheers,
Miguel

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Danilo Krummrich]

On Wed Jan 7, 2026 at 3:39 PM CET, Shankari Anand wrote:
> Hello Miguel and all,
>
>> >> error[E0432]: unresolved import `crate::types::ARef`
>>    --> rust/kernel/scatterlist.rs:41:13
>>    |
>>    41 |     types::{ARef, Opaque},
>>    |             ^^^^ no `ARef` in `types`
>>    |
>>    = help: consider importing this struct instead:
>>    crate::sync::aref::ARef
>> --
>
> This change has already been made in [1]. Probably it has showed up on the linux-next
> recently which has caused the kernel bot to detect the error.

This is because the failing build was against the staging tree, which
(obviously) does not contain all the relevant patches to remove the temporary
re-export.

Now, I have no idea why the bot pulled this series to build it against the
staging tree though. But it should help to use --base when running git
format-patch.

Also, note that this patch can only be landed after all other patches went from
their corresponding subsystem trees into Linus' tree.

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Shankari Anand]

On Wed, Jan 07, 2026 at 10:42:44PM +0100, Danilo Krummrich wrote:

>  
> This is because the failing build was against the staging tree, which
> (obviously) does not contain all the relevant patches to remove the temporary
> re-export.
> 
> Now, I have no idea why the bot pulled this series to build it against the
> staging tree though. But it should help to use --base when running git
> format-patch.
>

Ah, I see. I'll ensure to include the base commit henceforth!
 
> Also, note that this patch can only be landed after all other patches went from
> their corresponding subsystem trees into Linus' tree.

Yes, agreed. Hoping other patches get picked up soon so this clean up 
will be completed soon!

Thanks everyone,
Shankari

[PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports

[Shankari Anand]

Resending the v2 patch series with changes suggested as in the 
v1 patch series [1].
Also re-worded the commit titles to refer to the target subsystem.

Have resent only the patches that haven't been picked up yet in the series.

Thanks and regards,
Shankari

[1] https://lore.kernel.org/all/20251123092438.182251-1-shankari.ak0208@gmail.com/

Shankari Anand (4):
  drivers: android: binder: Update ARef imports from sync::aref
  rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref
  rust: usb: Update AlwaysRefCounted imports to use sync::aref
  rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

 drivers/android/binder/process.rs      | 2 +-
 drivers/android/binder/thread.rs       | 3 +--
 rust/kernel/i2c.rs                     | 10 ++++------
 rust/kernel/types.rs                   | 2 --
 rust/kernel/usb.rs                     | 3 ++-
 5 files changed, 8 insertions(+), 12 deletions(-)

-- 
2.34.1

[PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Shankari Anand]

Remove the temporary re-exports of `ARef` and `AlwaysRefCounted`
from `types.rs` now that all in-tree users have been updated to
import them directly from `sync::aref`.

These re-exports were originally added to avoid breaking the
kernel build during the transition period while call sites were
incrementally migrated. With all users updated, they are no
longer needed.

Suggested-by: Benno Lossin <lossin@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1173
Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
---
v1 -> v2:

Re-worded the commit title to rust: types:

Link of v1: https://lore.kernel.org/all/20251123092438.182251-11-shankari.ak0208@gmail.com/

---
 rust/kernel/types.rs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/rust/kernel/types.rs b/rust/kernel/types.rs
index 9c5e7dbf1632..4329d3c2c2e5 100644
--- a/rust/kernel/types.rs
+++ b/rust/kernel/types.rs
@@ -11,8 +11,6 @@
 };
 use pin_init::{PinInit, Wrapper, Zeroable};
 
-pub use crate::sync::aref::{ARef, AlwaysRefCounted};
-
 /// Used to transfer ownership to and from foreign (non-Rust) languages.
 ///
 /// Ownership is transferred from Rust to a foreign language by calling [`Self::into_foreign`] and
-- 
2.34.1