From: "Gary Guo" <gary@garyguo.net>
To: "FUJITA Tomonori" <fujita.tomonori@gmail.com>,
<boqun.feng@gmail.com>, <ojeda@kernel.org>,
<peterz@infradead.org>, <will@kernel.org>
Cc: <a.hindborg@kernel.org>, <aliceryhl@google.com>,
<bjorn3_gh@protonmail.com>, <dakr@kernel.org>, <gary@garyguo.net>,
<lossin@kernel.org>, <mark.rutland@arm.com>, <tmgross@umich.edu>,
<rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] rust: sync: atomic: Add performance-optimal-integer-backed Flag for atomic booleans
Date: Thu, 15 Jan 2026 13:22:32 +0000 [thread overview]
Message-ID: <DFP7107P61DR.47FY9883FCSZ@garyguo.net> (raw)
In-Reply-To: <20260115021230.3297420-2-fujita.tomonori@gmail.com>
On Thu Jan 15, 2026 at 2:12 AM GMT, FUJITA Tomonori wrote:
> Add a new Flag enum (Clear/Set) and implement AtomicType for it, so
> users can use Atomic<Flag> for boolean flags.
>
> The backing integer type is an implementation detail; it may vary by
> architecture and change in the future.
>
> Document when Atomic<Flag> is generally preferable to Atomic<bool>: in
> particular, when RMW operations such as xchg()/cmpxchg() may be used
> and minimizing memory usage is not the top priority. On some
> architectures without byte-sized RMW instructions, Atomic<bool> can be
> slower for RMW operations.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
> ---
> rust/kernel/sync/atomic.rs | 71 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 71 insertions(+)
next prev parent reply other threads:[~2026-01-15 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 2:12 [PATCH v4 0/2] rust: sync: atomic flag helpers FUJITA Tomonori
2026-01-15 2:12 ` [PATCH v4 1/2] rust: sync: atomic: Add performance-optimal-integer-backed Flag for atomic booleans FUJITA Tomonori
2026-01-15 13:22 ` Gary Guo [this message]
2026-01-19 1:22 ` Boqun Feng
2026-01-19 3:10 ` FUJITA Tomonori
2026-01-19 23:08 ` FUJITA Tomonori
2026-01-20 2:56 ` Boqun Feng
2026-01-15 2:12 ` [PATCH v4 2/2] rust: sync: atomic: Add AtomicFlag bool wrapper for easier use FUJITA Tomonori
2026-01-15 13:22 ` Gary Guo
2026-01-15 6:41 ` [PATCH v4 0/2] rust: sync: atomic flag helpers Alice Ryhl
2026-01-15 8:59 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFP7107P61DR.47FY9883FCSZ@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=lossin@kernel.org \
--cc=mark.rutland@arm.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox