From: "Jesung Yang" <y.j3ms.n@gmail.com>
To: "Tamir Duberstein" <tamird@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Tamir Duberstein" <tamird@gmail.com>
Subject: Re: [PATCH] scripts: generate_rust_analyzer: compile quote with correct edition
Date: Fri, 16 Jan 2026 13:09:03 +0900 [thread overview]
Message-ID: <DFPPVS51UHDS.2JS7UD4HY60I0@gmail.com> (raw)
In-Reply-To: <20260115-rust-analyzer-quote-edition-v1-1-d492f880dde4@gmail.com>
On Fri Jan 16, 2026 at 1:45 AM KST, Tamir Duberstein wrote:
> From: Tamir Duberstein <tamird@gmail.com>
>
> Our copy of the quote crate uses edition 2018, thus generate the correct
> rust-analyzer configuration for it.
>
> Fixes: 88de91cc1ce7 ("rust: quote: enable support in kbuild")
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Reviewed-by: Jesung Yang <y.j3ms.n@gmail.com>
Best regards,
Jesung
> ---
> scripts/generate_rust_analyzer.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index 6061bd6e2ebd..c6a1f1660c0d 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -98,6 +98,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edit
> srctree / "rust" / "quote" / "lib.rs",
> ["alloc", "proc_macro", "proc_macro2"],
> cfg=crates_cfgs["quote"],
> + edition="2018",
> )
>
> append_crate(
>
> ---
> base-commit: 74e15ac34b098934895fd27655d098971d2b43d9
> change-id: 20260115-rust-analyzer-quote-edition-bf00e950f179
>
> Best regards,
> --
> Tamir Duberstein <tamird@gmail.com>
next prev parent reply other threads:[~2026-01-16 4:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 16:45 [PATCH] scripts: generate_rust_analyzer: compile quote with correct edition Tamir Duberstein
2026-01-15 21:23 ` Miguel Ojeda
2026-01-16 4:09 ` Jesung Yang [this message]
2026-01-16 11:54 ` Gary Guo
2026-01-18 19:43 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFPPVS51UHDS.2JS7UD4HY60I0@gmail.com \
--to=y.j3ms.n@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox