From: "Jesung Yang" <y.j3ms.n@gmail.com>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Jesung Yang" <y.j3ms.n@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Tamir Duberstein" <tamird@gmail.com>
Subject: Re: [PATCH] scripts: generate_rust_analyzer: compile sysroot with correct edition
Date: Fri, 16 Jan 2026 13:35:47 +0900 [thread overview]
Message-ID: <DFPQG929N5CE.34Y24PGBZN2ED@gmail.com> (raw)
In-Reply-To: <CANiq72kd9bHdKaAm=8xCUhSHMy2csyVed69bOc4dXyFAW4sfuw@mail.gmail.com>
On Fri Jan 16, 2026 at 6:22 AM KST, Miguel Ojeda wrote:
> On Thu, Jan 15, 2026 at 5:35 PM Tamir Duberstein <tamird@kernel.org> wrote:
>>
>> Rename `core-edition` to `sysroot-edition` to align with the naming used
>> to refer to standard library crates in `generate_rust_analyzer.py` and
>> apply it to all standard library crates rather than just core.
>
> I think, in principle, even the sysroot crates may have different
> editions, which I think I used that variable name.
>
> For instance, in the move to 2024, it seems all happened at once in
> 1.87.0 in these upstream commits, so that seems OK:
>
> 0e071c2c6a58 ("Migrate core to Rust 2024")
> f505d4e8e380 ("Migrate alloc to Rust 2024")
> 0b2489c226c3 ("Migrate proc_macro to Rust 2024")
> 993359e70112 ("Migrate std to Rust 2024")
>
> But in the previous move to 2021, `std` moved in 1.59.0, while the
> others in 1.60.0:
>
> b656384d8398 ("Update stdlib to the 2021 edition")
> 06a1c14d52a8 ("Switch all libraries to the 2021 edition")
>
> Hmm... I guess the new name is fine, but we may need to go back to
> separate naming eventually if they get updated at different times next
> time.
Perhaps we should introduce `std-edition` and `proc_macro-edition` in
`rust/Makefile`? Passing those down to the script would make things more
future-proof.
Best regards,
Jesung
next prev parent reply other threads:[~2026-01-16 4:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 16:35 [PATCH] scripts: generate_rust_analyzer: compile sysroot with correct edition Tamir Duberstein
2026-01-15 21:22 ` Miguel Ojeda
2026-01-15 21:35 ` Tamir Duberstein
2026-01-15 21:53 ` Miguel Ojeda
2026-01-16 4:35 ` Jesung Yang [this message]
2026-01-16 11:53 ` Gary Guo
2026-01-16 14:02 ` Tamir Duberstein
2026-01-16 14:43 ` Miguel Ojeda
2026-01-16 15:38 ` Tamir Duberstein
2026-01-16 19:50 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFPQG929N5CE.34Y24PGBZN2ED@gmail.com \
--to=y.j3ms.n@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox