From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alexandre Courbot" <acourbot@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>
Cc: "John Hubbard" <jhubbard@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
<nouveau@lists.freedesktop.org>, <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v6 09/11] gpu: nova-core: add FalconUCodeDescV2 support
Date: Fri, 16 Jan 2026 21:09:23 +0100 [thread overview]
Message-ID: <DFQAB2CZQ3O8.3R8RP5YJ6DXL1@kernel.org> (raw)
In-Reply-To: <DFPOX3BJZ09C.1H3K67HGP3HLP@nvidia.com>
On Fri Jan 16, 2026 at 4:23 AM CET, Alexandre Courbot wrote:
> It looks like John and I have a different opinion on which approach is
> the best to handle the v2/v3 headers (a match in each method vs a new
> trait and virtual method calls).
Unless performance is a concern (which obviously isn't the case here), I think
the dynamic dispatch is fine and leads to cleaner and more maintainable code.
> TBH I don't really mind which approach we adopt, but I would like us to
> stay consistent through the code. This patch adds the trait and
> implements `Deref`, but then the chunk above still performs matches.
Yes, please be consistent -- Alex' diff looks good to me.
next prev parent reply other threads:[~2026-01-16 20:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 19:29 [PATCH v6 00/11] gpu: nova-core: add Turing support Timur Tabi
2026-01-14 19:29 ` [PATCH v6 01/11] gpu: nova-core: rename Imem to ImemSecure Timur Tabi
2026-01-14 19:29 ` [PATCH v6 02/11] gpu: nova-core: add ImemNonSecure section infrastructure Timur Tabi
2026-01-22 12:52 ` Gary Guo
2026-01-22 19:00 ` Timur Tabi
2026-01-14 19:29 ` [PATCH v6 03/11] gpu: nova-core: support header parsing on Turing/GA100 Timur Tabi
2026-01-14 19:29 ` [PATCH v6 04/11] gpu: nova-core: add support for Turing/GA100 fwsignature Timur Tabi
2026-01-14 19:29 ` [PATCH v6 05/11] gpu: nova-core: add NV_PFALCON_FALCON_DMATRFCMD::with_falcon_mem() Timur Tabi
2026-01-14 19:29 ` [PATCH v6 06/11] gpu: nova-core: move some functions into the HAL Timur Tabi
2026-01-16 19:55 ` Danilo Krummrich
2026-01-16 20:08 ` John Hubbard
2026-01-16 20:11 ` Danilo Krummrich
2026-01-16 20:15 ` John Hubbard
2026-01-16 20:21 ` Danilo Krummrich
2026-01-16 20:27 ` John Hubbard
2026-01-14 19:29 ` [PATCH v6 07/11] gpu: nova-core: Add basic Turing HAL Timur Tabi
2026-01-14 19:29 ` [PATCH v6 08/11] gpu: nova-core: add Falcon HAL method supports_dma() Timur Tabi
2026-01-16 1:53 ` Alexandre Courbot
2026-01-16 3:00 ` Timur Tabi
2026-01-14 19:29 ` [PATCH v6 09/11] gpu: nova-core: add FalconUCodeDescV2 support Timur Tabi
2026-01-16 3:11 ` Alexandre Courbot
2026-01-16 3:23 ` Alexandre Courbot
2026-01-16 20:09 ` Danilo Krummrich [this message]
2026-01-14 19:29 ` [PATCH v6 10/11] gpu: nova-core: align LibosMemoryRegionInitArgument size to page size Timur Tabi
2026-01-14 19:29 ` [PATCH v6 11/11] gpu: nova-core: add PIO support for loading firmware images Timur Tabi
2026-01-16 15:22 ` Alexandre Courbot
2026-01-16 21:05 ` Danilo Krummrich
2026-01-17 1:55 ` Alexandre Courbot
2026-01-21 0:25 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFQAB2CZQ3O8.3R8RP5YJ6DXL1@kernel.org \
--to=dakr@kernel.org \
--cc=acourbot@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox