public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alice Ryhl" <aliceryhl@google.com>
Cc: "Timur Tabi" <ttabi@nvidia.com>,
	"Matthew Maurer" <mmaurer@google.com>,
	"Gary Guo" <gary@garyguo.net>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	<nouveau@lists.freedesktop.org>, <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v5 3/8] rust: uaccess: add UserSliceWriter::write_buffer() for raw pointer writes
Date: Sat, 17 Jan 2026 15:35:12 +0100	[thread overview]
Message-ID: <DFQXTQJSCXV5.2FSUVMTSF2OB3@kernel.org> (raw)
In-Reply-To: <aWubWE4kstGI42P9@google.com>

On Sat Jan 17, 2026 at 3:23 PM CET, Alice Ryhl wrote:
> On Sat, Jan 17, 2026 at 01:23:57PM +0000, Alice Ryhl wrote:
>> On Fri, Jan 16, 2026 at 03:49:54PM -0600, Timur Tabi wrote:
>> > +    pub unsafe fn write_buffer(
>> > +        &mut self,
>> > +        data: *const u8,
>> > +        len: usize,
>> > +        offset: usize,
>> > +        count: usize,
>> > +    ) -> Result {
>> 
>> Why not this signature?
>> 
>> 	unsafe fn write_raw_slice(&mut self, data: *const [u8]) -> Result;
>> 
>> You can implement `write_slice` in terms of it.
>
> To clarify, I think this would be a simpler signature for
> `write_buffer()`. And `write_raw_slice()` can be used both for DMA and
> to simplify the existing `write_slice`.

I.e. you can use it also to create a safe helper for DMA:

	fn write_dma(
	    &mut self,
	    data: &dma::CoherentAllocation<u8>,
	    offset: usize,
	    count: usize
	) -> Result;

  reply	other threads:[~2026-01-17 14:35 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 21:49 [PATCH v5 0/8] gpu: nova-core: expose the logging buffers via debugfs Timur Tabi
2026-01-16 21:49 ` [PATCH v5 1/8] rust: pci: add device name method Timur Tabi
2026-01-17 11:09   ` Danilo Krummrich
2026-01-27 21:04     ` Timur Tabi
2026-01-27 21:07       ` Danilo Krummrich
2026-01-16 21:49 ` [PATCH v5 2/8] rust: debugfs: add Dir::empty() for conditional debugfs usage Timur Tabi
2026-01-19 12:08   ` Gary Guo
2026-01-20 17:54   ` Matthew Maurer
2026-01-20 18:19     ` Danilo Krummrich
2026-01-16 21:49 ` [PATCH v5 3/8] rust: uaccess: add UserSliceWriter::write_buffer() for raw pointer writes Timur Tabi
2026-01-17 11:18   ` Danilo Krummrich
2026-01-17 11:19     ` Danilo Krummrich
2026-01-17 13:23   ` Alice Ryhl
2026-01-17 14:23     ` Alice Ryhl
2026-01-17 14:35       ` Danilo Krummrich [this message]
2026-01-19 12:13         ` Gary Guo
2026-01-19 12:38           ` Danilo Krummrich
2026-01-16 21:49 ` [PATCH v5 4/8] gpu: nova-core: implement BinaryWriter for LogBuffer Timur Tabi
2026-01-17 11:22   ` Danilo Krummrich
2026-01-19 12:17   ` Gary Guo
2026-01-28 20:20     ` Timur Tabi
2026-01-16 21:49 ` [PATCH v5 5/8] gpu: nova-core: Replace module_pci_driver! with explicit module init Timur Tabi
2026-01-17 11:24   ` Danilo Krummrich
2026-01-28 20:52     ` Timur Tabi
2026-01-16 21:49 ` [PATCH v5 6/8] gpu: nova-core: use pin projection in method boot() Timur Tabi
2026-01-16 21:49 ` [PATCH v5 7/8] gpu: nova-core: create debugfs root in module init Timur Tabi
2026-01-17 12:18   ` Danilo Krummrich
2026-01-17 12:29   ` Danilo Krummrich
2026-01-17 20:58     ` Timur Tabi
2026-01-17 21:35       ` Danilo Krummrich
2026-01-17 21:52         ` Timur Tabi
2026-01-17 22:00           ` Danilo Krummrich
2026-01-16 21:49 ` [PATCH v5 8/8] gpu: nova-core: create GSP-RM logging buffers debugfs entries Timur Tabi
2026-01-17 12:21   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFQXTQJSCXV5.2FSUVMTSF2OB3@kernel.org \
    --to=dakr@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=mmaurer@google.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox