From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: "Zhi Wang" <zhiw@nvidia.com>, <rust-for-linux@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<aliceryhl@google.com>, <bhelgaas@google.com>,
<kwilczynski@kernel.org>, <ojeda@kernel.org>,
<alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
<a.hindborg@kernel.org>, <tmgross@umich.edu>,
<markus.probst@posteo.de>, <helgaas@kernel.org>,
<cjia@nvidia.com>, <smitra@nvidia.com>, <ankita@nvidia.com>,
<aniketa@nvidia.com>, <kwankhede@nvidia.com>,
<targupta@nvidia.com>, <acourbot@nvidia.com>,
<joelagnelf@nvidia.com>, <jhubbard@nvidia.com>,
<zhiwang@kernel.org>, <daniel.almeida@collabora.com>
Subject: Re: [PATCH v11 4/5] rust: pci: add config space read/write support
Date: Wed, 21 Jan 2026 18:12:11 +0100 [thread overview]
Message-ID: <DFUFO3WUQL1K.3JH3SS0J1Y0CQ@kernel.org> (raw)
In-Reply-To: <DFUDN05YDH4W.1VXNXWWZST0C6@garyguo.net>
On Wed Jan 21, 2026 at 4:36 PM CET, Gary Guo wrote:
>> +/// The PCI configuration space of a device.
>> +///
>> +/// Provides typed read and write accessors for configuration registers
>> +/// using the standard `pci_read_config_*` and `pci_write_config_*` helpers.
>> +///
>> +/// The generic const parameter `SIZE` can be used to indicate the
>> +/// maximum size of the configuration space (e.g. `ConfigSpaceSize::Normal`
>> +/// or `ConfigSpaceSize::Extended`).
>> +pub struct ConfigSpace<'a, const SIZE: usize = { ConfigSpaceSize::Extended as usize }> {
>
> This is quite long to write. Given that it'll either be normal or extended, can
> we just have two marker types instead? So you have
>
> ConfigSpace<Normal> and ConfigSpace<Extended>
I think in practice users don't have the need to write it anyways. You'd access
the config space with either
let config = pdev.config_space()?;
or
let config = pdev.config_space_extended()?;
i.e. there is no need to store an instance of the struct anywhere.
Should it turn out that we do need it for some reason in the future we can do
this as follow-up, I think.
next prev parent reply other threads:[~2026-01-21 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 14:23 [PATCH v11 0/5] rust: pci: add config space read/write support Zhi Wang
2026-01-21 14:23 ` [PATCH v11 1/5] rust: devres: style for imports Zhi Wang
2026-01-21 14:54 ` Gary Guo
2026-01-21 18:53 ` Zhi Wang
2026-01-21 14:23 ` [PATCH v11 2/5] rust: io: separate generic I/O helpers from MMIO implementation Zhi Wang
2026-01-21 15:10 ` Gary Guo
2026-01-21 18:54 ` Zhi Wang
2026-01-21 14:23 ` [PATCH v11 3/5] rust: io: factor out MMIO read/write macros Zhi Wang
2026-01-21 14:23 ` [PATCH v11 4/5] rust: pci: add config space read/write support Zhi Wang
2026-01-21 15:36 ` Gary Guo
2026-01-21 17:12 ` Danilo Krummrich [this message]
2026-01-21 17:40 ` Gary Guo
2026-01-21 14:23 ` [PATCH v11 5/5] sample: rust: pci: add tests for config space routines Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFUFO3WUQL1K.3JH3SS0J1Y0CQ@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=cjia@nvidia.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=helgaas@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox