From: "Gary Guo" <gary@garyguo.net>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Gary Guo" <gary@garyguo.net>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Tamir Duberstein" <tamird@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: disallow use of `CStr::as_ptr`
Date: Wed, 21 Jan 2026 17:33:09 +0000 [thread overview]
Message-ID: <DFUG45Y0U7IS.32I4NMAV9NHT6@garyguo.net> (raw)
In-Reply-To: <CANiq72n7PTiAMHy5cM0H3GGNdn8BZic9MAyJCD2KRnPa2MM6Hg@mail.gmail.com>
On Wed Jan 21, 2026 at 5:04 PM GMT, Miguel Ojeda wrote:
> On Wed, Jan 21, 2026 at 5:58 PM Gary Guo <gary@kernel.org> wrote:
>>
>> +#[expect(clippy::disallowed_methods, reason = "internal implementation")]
>
> Should we hide them too?
These are the methods that we want people to use? The "internal implementation"
means that the use of `CStr::as_char()` is the internal implementation detail of
`as_char_ptr` so it's okay. But nobody else should use it.
Best,
Gary
>
> Cheers,
> Miguel
next prev parent reply other threads:[~2026-01-21 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 16:58 [PATCH] rust: disallow use of `CStr::as_ptr` Gary Guo
2026-01-21 17:04 ` Miguel Ojeda
2026-01-21 17:33 ` Gary Guo [this message]
2026-01-21 18:11 ` Miguel Ojeda
2026-01-21 17:55 ` Tamir Duberstein
2026-01-21 18:19 ` Gary Guo
2026-01-21 19:45 ` Tamir Duberstein
2026-01-21 20:01 ` Gary Guo
2026-01-21 20:01 ` Tamir Duberstein
2026-01-21 20:47 ` Miguel Ojeda
2026-01-22 8:28 ` Alice Ryhl
2026-01-22 10:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFUG45Y0U7IS.32I4NMAV9NHT6@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox