From: "Jesung Yang" <y.j3ms.n@gmail.com>
To: "SeungJong Ha" <engineer.jjhama@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts: generate_rust_analyzer.py: better pin-init macro resolvea
Date: Fri, 23 Jan 2026 21:23:44 +0900 [thread overview]
Message-ID: <DFVYSCDHP5UA.2RX1AU34POA3M@gmail.com> (raw)
In-Reply-To: <20260123-fix-pin-init-crate-dependecies-v1-1-1c6cfe9aa352@gmail.com>
Hi SeungJong,
I think I could give you some background on where things stand :)
On Fri Jan 23, 2026 at 7:02 PM KST, SeungJong Ha wrote:
[...]
> scripts/generate_rust_analyzer.py | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index 147d0cc94068..0c6c0444917f 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -123,10 +123,18 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edit
> append_crate(
> "pin_init_internal",
> srctree / "rust" / "pin-init" / "internal" / "src" / "lib.rs",
> - [],
> + ["std", "proc_macro"],
As Miguel pointed out, this fix has already landed on the `rust-fixes`
branch as commit "scripts: generate_rust_analyzer: Add pin_init_internal
deps" [1].
> cfg=["kernel"],
> is_proc_macro=True,
> )
> + # pin_init_internal uses #[path = "../../../macros/quote.rs"] to include quote.rs
> + crates[-1]["source"] = {
> + "include_dirs": [
> + str(srctree / "rust" / "pin-init" / "internal" / "src"),
> + str(srctree / "rust" / "macros"),
> + ],
> + "exclude_dirs": [],
> + }
AFAIK, the `#[path = "../../../macros/quote.rs"]` part was removed
recently by this series [2], which is set to land in this cycle.
So I would recommend checking if the problem is still present even after
rebasing on `rust-fixes` with the new pin-init update applied (or simply
checking the `linux-next` tree as I think it has already picked up the
relevant changes).
Thanks!
[1] https://github.com/Rust-for-Linux/linux/commit/74e15ac34b098934895fd27655d098971d2b43d9
[2] https://lore.kernel.org/rust-for-linux/20260116105514.3794384-4-lossin@kernel.org/
Best regards,
Jesung
next prev parent reply other threads:[~2026-01-23 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 10:02 [PATCH] scripts: generate_rust_analyzer.py: better pin-init macro resolvea SeungJong Ha via B4 Relay
2026-01-23 10:26 ` Miguel Ojeda
2026-01-23 13:14 ` 하승종
2026-01-23 12:23 ` Jesung Yang [this message]
2026-01-23 13:15 ` 하승종
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFVYSCDHP5UA.2RX1AU34POA3M@gmail.com \
--to=y.j3ms.n@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=engineer.jjhama@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox