Re: [PATCH v2] rust: dma: allow drivers to tune max segment size

["Gary Guo" <gary@garyguo.net>]

On Fri Jan 23, 2026 at 4:39 PM GMT, Dirk Behme wrote:
> On 23.01.26 14:13, Beata Michalska wrote:
>> Make dma_set_max_seg_size() available to Rust so drivers can perform
>> standard DMA setup steps.
>> 
>> Signed-off-by: Beata Michalska <beata.michalska@arm.com>
>> ---
>> 
>> v2:
>> - Aligned safety requirements
>> 
>>  rust/helpers/dma.c |  5 +++++
>>  rust/kernel/dma.rs | 17 +++++++++++++++++
>>  2 files changed, 22 insertions(+)
>> 
>> diff --git a/rust/helpers/dma.c b/rust/helpers/dma.c
>> index 2afa32c21c94..220b9308830f 100644
>> --- a/rust/helpers/dma.c
>> +++ b/rust/helpers/dma.c
>> @@ -40,3 +40,8 @@ size_t rust_helper_dma_max_mapping_size(struct device *dev)
>>  {
>>  	return dma_max_mapping_size(dev);
>>  }
>> +
>> +void rust_helper_dma_set_max_seg_size(struct device *dev, unsigned int size)
>> +{
>> +	dma_set_max_seg_size(dev, size);
>> +}
>
> I was about to ask "please add __rust_helper" [1]. But looking into
> driver-core-next it looks like some of the function in dma.c have
> __rust_helper (from [1]) and some don't (from [2]). Is this by
> intention or was this an omission in [2]?

This is an omission. It's an also a relatively new addition which means that
it's not covered in Alice's series.

Best,
Gary