From: "Danilo Krummrich" <dakr@kernel.org>
To: "Timur Tabi" <ttabi@nvidia.com>
Cc: "gary@garyguo.net" <gary@garyguo.net>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"mmaurer@google.com" <mmaurer@google.com>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v6 7/7] gpu: nova-core: create GSP-RM logging buffers debugfs entries
Date: Sat, 31 Jan 2026 01:35:20 +0100 [thread overview]
Message-ID: <DG2CQBAM6SG8.1116LCW3IIT3N@kernel.org> (raw)
In-Reply-To: <f723d517b943b9f4c10764daee9ff711e15b6834.camel@nvidia.com>
On Sat Jan 31, 2026 at 1:26 AM CET, Timur Tabi wrote:
> On Sat, 2026-01-31 at 01:10 +0100, Danilo Krummrich wrote:
>> > One idea is to create types that look exactly like `Dir` but always ZST and
>> > no-op regardless whether CONFIG_DEBUG_FS is enabled... But that feel a bit..
>> > weird. Matthew, what do you think?
>>
>> There is no need for CONFIG_NOVA_CORE_DEBUGFS in the first place. The only
>> Kconfig we need is for retaining the GSP log buffers after driver unbind.
>
> Danilo, I'm confused. You told me to add this Kconfig:
>
> https://lore.kernel.org/rust-for-linux/DFR6RWROWBYA.1Q9JKH8UDSXOX@kernel.org/
Maybe a misunderstanding due to my type? I.e.
"I think it's OK to always have the entries on keeping them beyond device unbind
has to be behind a Kconfig option."
vs.
"I think it's OK to always have the entries, only keeping them beyond device unbind
has to be behind a Kconfig option."
next prev parent reply other threads:[~2026-01-31 0:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 2:28 [PATCH v6 0/7] gpu: nova-core: expose the logging buffers via debugfs Timur Tabi
2026-01-29 2:28 ` [PATCH v6 1/7] rust: device: add device name method Timur Tabi
2026-01-29 2:28 ` [PATCH v6 2/7] rust: uaccess: add write_dma() for copying from DMA buffers to userspace Timur Tabi
2026-01-29 17:24 ` Gary Guo
2026-01-31 0:14 ` Danilo Krummrich
2026-01-29 2:28 ` [PATCH v6 3/7] gpu: nova-core: implement BinaryWriter for CoherentAllocation<u8> Timur Tabi
2026-01-30 8:31 ` Alice Ryhl
2026-01-30 18:53 ` Timur Tabi
2026-01-29 2:28 ` [PATCH v6 4/7] gpu: nova-core: Replace module_pci_driver! with explicit module init Timur Tabi
2026-01-29 2:28 ` [PATCH v6 5/7] gpu: nova-core: use pin projection in method boot() Timur Tabi
2026-01-29 2:28 ` [PATCH v6 6/7] gpu: nova-core: create debugfs root in module init Timur Tabi
2026-01-30 8:34 ` Alice Ryhl
2026-01-30 14:59 ` Timur Tabi
2026-01-29 2:28 ` [PATCH v6 7/7] gpu: nova-core: create GSP-RM logging buffers debugfs entries Timur Tabi
2026-01-30 23:36 ` Timur Tabi
2026-01-30 23:58 ` Gary Guo
2026-01-31 0:07 ` John Hubbard
2026-01-31 0:10 ` Danilo Krummrich
2026-01-31 0:16 ` John Hubbard
2026-01-31 0:20 ` Danilo Krummrich
2026-01-31 0:24 ` John Hubbard
2026-01-31 4:11 ` Timur Tabi
2026-01-31 0:26 ` Timur Tabi
2026-01-31 0:35 ` Danilo Krummrich [this message]
2026-01-31 0:51 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG2CQBAM6SG8.1116LCW3IIT3N@kernel.org \
--to=dakr@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=mmaurer@google.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox