[PATCH] rust: pci: export ConfigSpace

[PATCH] rust: pci: export ConfigSpace

[Zijing Zhang]

Re-export ConfigSpace from kernel::pci so users can name the returned
type from Device::config_space*().

Fixes: 4dc0bacb1d3c ("rust: pci: add config space read/write support")
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Zijing Zhang <zijing.zhang@ry.rs>
---
 rust/kernel/pci.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
index f347c2f7c3a6..af74ddff6114 100644
--- a/rust/kernel/pci.rs
+++ b/rust/kernel/pci.rs
@@ -42,6 +42,7 @@
 };
 pub use self::io::{
     Bar,
+    ConfigSpace,
     ConfigSpaceKind,
     ConfigSpaceSize,
     Extended,
-- 
2.52.0

Re: [PATCH] rust: pci: export ConfigSpace

[Alexandre Courbot]

On Sat Jan 31, 2026 at 1:02 PM JST, Zijing Zhang wrote:
> Re-export ConfigSpace from kernel::pci so users can name the returned
> type from Device::config_space*().
>
> Fixes: 4dc0bacb1d3c ("rust: pci: add config space read/write support")
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Zijing Zhang <zijing.zhang@ry.rs>

There was probably no need to resend, but since you did, the title
should have contained "[PATCH v2]".

No need to resend again. :)

Re: [PATCH] rust: pci: export ConfigSpace

[Gary Guo]

On Sat Jan 31, 2026 at 4:02 AM GMT, Zijing Zhang wrote:
> Re-export ConfigSpace from kernel::pci so users can name the returned
> type from Device::config_space*().
>
> Fixes: 4dc0bacb1d3c ("rust: pci: add config space read/write support")
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Zijing Zhang <zijing.zhang@ry.rs>

Please reference the initial bug report in tags:

Reported-by: Gary Guo <gary@garyguo.net>
Closes: https://lore.kernel.org/rust-for-linux/DG2D5ONS18FE.TC7K3O8V8SU1@garyguo.net/

Best,
Gary

> ---
>  rust/kernel/pci.rs | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
> index f347c2f7c3a6..af74ddff6114 100644
> --- a/rust/kernel/pci.rs
> +++ b/rust/kernel/pci.rs
> @@ -42,6 +42,7 @@
>  };
>  pub use self::io::{
>      Bar,
> +    ConfigSpace,
>      ConfigSpaceKind,
>      ConfigSpaceSize,
>      Extended,

[PATCH v2] rust: pci: export ConfigSpace

[Zijing Zhang]

Re-export ConfigSpace from kernel::pci so users can name the returned
type from Device::config_space*().

Fixes: 4dc0bacb1d3c ("rust: pci: add config space read/write support")
Reported-by: Gary Guo <gary@garyguo.net>
Closes: https://lore.kernel.org/rust-for-linux/DG2D5ONS18FE.TC7K3O8V8SU1@garyguo.net/
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Zijing Zhang <zijing.zhang@ry.rs>
---
 rust/kernel/pci.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
index f347c2f7c3a6..af74ddff6114 100644
--- a/rust/kernel/pci.rs
+++ b/rust/kernel/pci.rs
@@ -42,6 +42,7 @@
 };
 pub use self::io::{
     Bar,
+    ConfigSpace,
     ConfigSpaceKind,
     ConfigSpaceSize,
     Extended,
-- 
2.52.0

Re: [PATCH v2] rust: pci: export ConfigSpace

[Miguel Ojeda]

On Sat, Jan 31, 2026 at 5:47 PM Zijing Zhang <zijing.zhang@ry.rs> wrote:
>
> Re-export ConfigSpace from kernel::pci so users can name the returned
> type from Device::config_space*().
>
> Fixes: 4dc0bacb1d3c ("rust: pci: add config space read/write support")
> Reported-by: Gary Guo <gary@garyguo.net>
> Closes: https://lore.kernel.org/rust-for-linux/DG2D5ONS18FE.TC7K3O8V8SU1@garyguo.net/
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Zijing Zhang <zijing.zhang@ry.rs>

Generally, there is no need to resend to add tags (especially within
the same week) -- maintainers should pick them up for you from the
thread if they apply the patch (otherwise, you should pick them
yourself when sending a new version like you did here).

In addition, I would suggest sending new versions in a new thread;
otherwise, things can get too nested in e.g. lore.kernel.org and other
readers (especially when patch series have discussion involved and/or
are long). Instead, what I recommend is adding in the changelog a
lore.kernel.org link back to the previous versions (or at least the
previous one).

Thanks!

Cheers,
Miguel

Re: [PATCH v2] rust: pci: export ConfigSpace

[Danilo Krummrich]

On Sat Jan 31, 2026 at 5:42 PM CET, Zijing Zhang wrote:
> Re-export ConfigSpace from kernel::pci so users can name the returned
> type from Device::config_space*().
>
> Fixes: 4dc0bacb1d3c ("rust: pci: add config space read/write support")
> Reported-by: Gary Guo <gary@garyguo.net>
> Closes: https://lore.kernel.org/rust-for-linux/DG2D5ONS18FE.TC7K3O8V8SU1@garyguo.net/
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Zijing Zhang <zijing.zhang@ry.rs>

    [ Slightly reworded commit message. - Danilo ]

Applied to driver-core-testing, thanks!