Re: [PATCH v2] rust: Makefile: bound rustdoc workaround to affected versions

["Gary Guo" <gary@garyguo.net>]

On Mon Feb 2, 2026 at 4:00 PM GMT, Miguel Ojeda wrote:
> On Mon, Feb 2, 2026 at 4:21 PM HeeSu Kim <mlksvender@gmail.com> wrote:
>>
>> This bug was fixed in Rust 1.90.0 (rust-lang/rust#144523). Restrict
>
> Normally these references should be full links (i.e. a tag), since we
> do not have "autolinking" like GitHub e.g.
>
>   Link: https://........ [1]
>
> Then you can use [1] above instead of the parenthesis.
>
>> are affected by the bug, avoiding unnecessary flags on newer compiler
>
> To clarify a bit: avoiding the flags is good, but I think avoiding the
> skipping of the checks that the flag does is what is more important
> (i.e. if it were just the former advantage, I would say it is not
> worth the complexity of the added tests).

I think skipping workarounds when possible is in general good, as it serves a
good reference that it can be removed whenever the toolchain minimum version is
bumped above that (and with the help with LKP, it means that it's also been
actually widely tested that the workaround is indeed not necessary).

Best,
Gary