From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alexandre Courbot" <acourbot@nvidia.com>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Yury Norov" <yury.norov@gmail.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"Dirk Behme" <dirk.behme@de.bosch.com>,
"Steven Price" <steven.price@arm.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Zhi Wang" <zhiw@nvidia.com>
Subject: Re: [PATCH v5 6/7] sample: rust: pci: use `register!` macro
Date: Fri, 06 Feb 2026 19:57:04 +0100 [thread overview]
Message-ID: <DG83X51TV560.26VQQD3B7WJL9@kernel.org> (raw)
In-Reply-To: <20260129-register-v5-6-c4587c902514@nvidia.com>
On Thu Jan 29, 2026 at 2:32 PM CET, Alexandre Courbot wrote:
> Convert the direct IO accesses to properly defined registers.
>
> Tested-by: Zhi Wang <zhiw@nvidia.com>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
I think you forgot the address my comment from [1].
Changing the config space is nice, but I think it would be even nicer to replace
the raw register writes and reads of the pci::Bar.
[1] https://lore.kernel.org/all/DG2DEH4ELYHK.2KUOIDQAILZHT@kernel.org/
next prev parent reply other threads:[~2026-02-06 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 13:32 [PATCH v5 0/7] rust: add `register!` macro Alexandre Courbot
2026-01-29 13:32 ` [PATCH v5 1/7] rust: enable the `generic_arg_infer` feature Alexandre Courbot
2026-01-29 13:32 ` [PATCH v5 2/7] rust: num: add `shr` and `shl` methods to `Bounded` Alexandre Courbot
2026-02-06 18:23 ` Daniel Almeida
2026-01-29 13:32 ` [PATCH v5 3/7] rust: num: add `as_bool` method to `Bounded<_, 1>` Alexandre Courbot
2026-02-06 18:28 ` Daniel Almeida
2026-02-12 12:55 ` Alexandre Courbot
2026-01-29 13:32 ` [PATCH v5 4/7] rust: num: add `into_inner` method to `Bounded` Alexandre Courbot
2026-02-06 18:29 ` Daniel Almeida
2026-01-29 13:32 ` [PATCH v5 5/7] rust: io: add `register!` macro Alexandre Courbot
2026-02-06 19:02 ` Danilo Krummrich
2026-02-06 21:11 ` Daniel Almeida
2026-01-29 13:32 ` [PATCH v5 6/7] sample: rust: pci: use " Alexandre Courbot
2026-02-06 18:57 ` Danilo Krummrich [this message]
2026-01-29 13:32 ` [PATCH FOR REFERENCE v5 7/7] gpu: nova-core: use the kernel " Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG83X51TV560.26VQQD3B7WJL9@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=dirk.behme@de.bosch.com \
--cc=ecourtney@nvidia.com \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=yury.norov@gmail.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox