[PATCH] rust: dma: add missing __rust_helper annotations

[PATCH] rust: dma: add missing __rust_helper annotations

[Dirk Behme]

The commit d8932355f8c5 ("rust: dma: add helpers for architectures
without CONFIG_HAS_DMA") missed adding the __rust_helper annotations.
Add them.

Fixes: d8932355f8c5 ("rust: dma: add helpers for architectures without CONFIG_HAS_DMA")
Closes: https://lore.kernel.org/rust-for-linux/DFW4F5OSDO7A.TBUOX6RCN8G7@garyguo.net/
Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
---
Note: This is against linux-next.git next-20260123

 rust/helpers/dma.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/rust/helpers/dma.c b/rust/helpers/dma.c
index e7defeecda71b..6514ce1647950 100644
--- a/rust/helpers/dma.c
+++ b/rust/helpers/dma.c
@@ -23,23 +23,23 @@ __rust_helper int rust_helper_dma_set_mask_and_coherent(struct device *dev,
 	return dma_set_mask_and_coherent(dev, mask);
 }
 
-int rust_helper_dma_set_mask(struct device *dev, u64 mask)
+__rust_helper int rust_helper_dma_set_mask(struct device *dev, u64 mask)
 {
 	return dma_set_mask(dev, mask);
 }
 
-int rust_helper_dma_set_coherent_mask(struct device *dev, u64 mask)
+__rust_helper int rust_helper_dma_set_coherent_mask(struct device *dev, u64 mask)
 {
 	return dma_set_coherent_mask(dev, mask);
 }
 
-int rust_helper_dma_map_sgtable(struct device *dev, struct sg_table *sgt,
+__rust_helper int rust_helper_dma_map_sgtable(struct device *dev, struct sg_table *sgt,
 				enum dma_data_direction dir, unsigned long attrs)
 {
 	return dma_map_sgtable(dev, sgt, dir, attrs);
 }
 
-size_t rust_helper_dma_max_mapping_size(struct device *dev)
+__rust_helper size_t rust_helper_dma_max_mapping_size(struct device *dev)
 {
 	return dma_max_mapping_size(dev);
 }
-- 
2.48.0

Re: [PATCH] rust: dma: add missing __rust_helper annotations

[Alice Ryhl]

On Mon, Jan 26, 2026 at 08:17:38AM +0100, Dirk Behme wrote:
> The commit d8932355f8c5 ("rust: dma: add helpers for architectures
> without CONFIG_HAS_DMA") missed adding the __rust_helper annotations.
> Add them.
> 
> Fixes: d8932355f8c5 ("rust: dma: add helpers for architectures without CONFIG_HAS_DMA")
> Closes: https://lore.kernel.org/rust-for-linux/DFW4F5OSDO7A.TBUOX6RCN8G7@garyguo.net/
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>

Thanks

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Re: [PATCH] rust: dma: add missing __rust_helper annotations

[Gary Guo]

On Mon Jan 26, 2026 at 7:17 AM GMT, Dirk Behme wrote:
> The commit d8932355f8c5 ("rust: dma: add helpers for architectures
> without CONFIG_HAS_DMA") missed adding the __rust_helper annotations.
> Add them.
> 
> Fixes: d8932355f8c5 ("rust: dma: add helpers for architectures without CONFIG_HAS_DMA")
> Closes: https://lore.kernel.org/rust-for-linux/DFW4F5OSDO7A.TBUOX6RCN8G7@garyguo.net/
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
> Note: This is against linux-next.git next-20260123
> 
>  rust/helpers/dma.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH] rust: dma: add missing __rust_helper annotations

[Danilo Krummrich]

On Mon Jan 26, 2026 at 8:17 AM CET, Dirk Behme wrote:
> The commit d8932355f8c5 ("rust: dma: add helpers for architectures
> without CONFIG_HAS_DMA") missed adding the __rust_helper annotations.
> Add them.
>
> Fixes: d8932355f8c5 ("rust: dma: add helpers for architectures without CONFIG_HAS_DMA")

I think we don't need a Fixes: tag for this, but given the Closes: tag below,
I'd add:

Reported-by: Gary Guo <gary@garyguo.net>

(No need to resend, I can change it when I pick this one up.)

> Closes: https://lore.kernel.org/rust-for-linux/DFW4F5OSDO7A.TBUOX6RCN8G7@garyguo.net/
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>

Re: [PATCH] rust: dma: add missing __rust_helper annotations

[Danilo Krummrich]

On Mon Jan 26, 2026 at 8:17 AM CET, Dirk Behme wrote:
> The commit d8932355f8c5 ("rust: dma: add helpers for architectures
> without CONFIG_HAS_DMA") missed adding the __rust_helper annotations.
> Add them.
>
> Fixes: d8932355f8c5 ("rust: dma: add helpers for architectures without CONFIG_HAS_DMA")
> Closes: https://lore.kernel.org/rust-for-linux/DFW4F5OSDO7A.TBUOX6RCN8G7@garyguo.net/
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>

Applied to driver-core-testing, thanks!

    [ Fix minor checkpatch.pl warning. - Danilo ]