public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Joel Fernandes" <joelagnelf@nvidia.com>
Cc: <linux-kernel@vger.kernel.org>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Arun Pravin" <arunpravin.paneerselvam@amd.com>,
	"Christian Koenig" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Dave Airlie" <airlied@redhat.com>,
	"Miguel Ojeda" <ojeda@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Koen Koning" <koen.koning@linux.intel.com>,
	<dri-devel@lists.freedesktop.org>,
	<nouveau@lists.freedesktop.org>, <rust-for-linux@vger.kernel.org>,
	<intel-xe@lists.freedesktop.org>,
	"Peter Senna Tschudin" <peter.senna@linux.intel.com>
Subject: Re: [PATCH v10 3/8] gpu: Fix uninitialized buddy for built-in drivers
Date: Thu, 19 Feb 2026 11:09:42 +0100	[thread overview]
Message-ID: <DGIUUFLC31D5.2OZBF5FWQJWMZ@kernel.org> (raw)
In-Reply-To: <20260218205507.689429-4-joelagnelf@nvidia.com>

On Wed Feb 18, 2026 at 9:55 PM CET, Joel Fernandes wrote:
> From: Koen Koning <koen.koning@linux.intel.com>
>
> Use subsys_initcall instead of module_init for the GPU buddy allocator,
> so its initialization code runs before any gpu drivers.
> Otherwise, a built-in driver that tries to use the buddy allocator will
> run into a kernel NULL pointer dereference because slab_blocks is
> uninitialized.
>
> Specifically, this fixes drm/xe (as built-in) running into a kernel
> panic during boot, because it uses buddy during device probe.
>
> Fixes: ba110db8e1bc ("gpu: Move DRM buddy allocator one level up (part two)")

This Fixes: tag seems wrong. How is this code move related to this problem?

This should rather be:

Fixes: 6387a3c4b0c4 ("drm: move the buddy allocator from i915 into common drm")

Also, please add:

Cc: stable@vger.kernel.org

> Cc: Joel Fernandes <joelagnelf@nvidia.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: intel-xe@lists.freedesktop.org
> Cc: Peter Senna Tschudin <peter.senna@linux.intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Koen Koning <koen.koning@linux.intel.com>
> Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
> Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>

I also think this patch should be sent separately and go through drm-misc-fixes.

  reply	other threads:[~2026-02-19 10:09 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 20:54 [PATCH v10 0/8] Preparatory patches for nova-core memory management Joel Fernandes
2026-02-18 20:54 ` [PATCH v10 1/8] gpu: Move DRM buddy allocator one level up (part one) Joel Fernandes
2026-02-18 20:55 ` [PATCH v10 2/8] gpu: Move DRM buddy allocator one level up (part two) Joel Fernandes
2026-02-19  3:18   ` Alexandre Courbot
2026-02-19 15:31     ` Joel Fernandes
2026-02-18 20:55 ` [PATCH v10 3/8] gpu: Fix uninitialized buddy for built-in drivers Joel Fernandes
2026-02-19 10:09   ` Danilo Krummrich [this message]
2026-02-19 15:31     ` Joel Fernandes
2026-02-19 16:24       ` Joel Fernandes
2026-02-18 20:55 ` [PATCH v10 4/8] rust: ffi: Convert pub use to pub mod and create ffi module Joel Fernandes
2026-02-19  3:18   ` Alexandre Courbot
2026-02-18 20:55 ` [PATCH v10 5/8] rust: clist: Add support to interface with C linked lists Joel Fernandes
2026-02-19  4:26   ` Alexandre Courbot
2026-02-19 15:27     ` Joel Fernandes
2026-02-19  9:58   ` Danilo Krummrich
2026-02-19 15:28     ` Joel Fernandes
2026-02-19 11:21   ` Danilo Krummrich
2026-02-19 14:37     ` Gary Guo
2026-02-19 15:27     ` Joel Fernandes
2026-02-19 15:44       ` Joel Fernandes
2026-02-19 16:24         ` Danilo Krummrich
2026-02-19 18:07           ` Joel Fernandes
2026-02-19 18:38             ` Miguel Ojeda
2026-02-19 19:28               ` Joel Fernandes
2026-02-19 22:55                 ` Miguel Ojeda
2026-02-20  4:00                   ` Joel Fernandes
2026-02-20  1:56             ` Alexandre Courbot
2026-02-20  1:09           ` Gary Guo
2026-02-20  1:19             ` Miguel Ojeda
2026-02-20 16:48             ` Danilo Krummrich
2026-02-23  0:54               ` Joel Fernandes
2026-02-24 16:15                 ` Miguel Ojeda
2026-02-25 19:48               ` Boqun Feng
2026-02-25 20:20                 ` Joel Fernandes
2026-02-26  0:32                   ` Joel Fernandes
2026-02-20  8:16   ` Eliot Courtney
2026-02-23  1:13     ` Joel Fernandes
2026-02-24  2:08       ` Eliot Courtney
2026-02-24  7:28       ` Alice Ryhl
2026-02-24 16:00         ` Joel Fernandes
2026-02-24 16:11           ` Miguel Ojeda
2026-02-21  8:59   ` Alice Ryhl
2026-02-23  0:41     ` Joel Fernandes
2026-02-23  9:38       ` Alice Ryhl
2026-02-24  0:32         ` Joel Fernandes
2026-02-18 20:55 ` [PATCH v10 6/8] rust: gpu: Add GPU buddy allocator bindings Joel Fernandes
2026-02-19  5:13   ` Alexandre Courbot
2026-02-19  8:54     ` Miguel Ojeda
2026-02-19 15:31       ` Joel Fernandes
2026-03-01 13:23         ` Gary Guo
2026-03-01 17:53           ` Miguel Ojeda
2026-02-19 15:31     ` Joel Fernandes
2026-02-20  1:56       ` Alexandre Courbot
2026-02-23  1:02         ` Joel Fernandes
2026-02-19 13:18   ` Danilo Krummrich
2026-02-19 15:31     ` Joel Fernandes
2026-02-20  8:22   ` Eliot Courtney
2026-02-20 14:54     ` Joel Fernandes
2026-02-20 15:50       ` Joel Fernandes
2026-02-20 15:53       ` Danilo Krummrich
2026-02-20 21:20         ` Joel Fernandes
2026-02-20 23:43           ` Danilo Krummrich
2026-02-23  0:34             ` Joel Fernandes
2026-02-18 20:55 ` [PATCH v10 7/8] nova-core: mm: Select GPU_BUDDY for VRAM allocation Joel Fernandes
2026-02-19  0:44   ` Alexandre Courbot
2026-02-19  1:14     ` John Hubbard
2026-02-19 15:31       ` Joel Fernandes
2026-02-19  2:06     ` Joel Fernandes
2026-02-19 15:31     ` Joel Fernandes
2026-02-18 20:55 ` [PATCH v10 8/8] nova-core: Kconfig: Sort select statements alphabetically Joel Fernandes
2026-02-18 20:59 ` [PATCH v10 0/8] Preparatory patches for nova-core memory management Joel Fernandes
2026-02-18 22:24 ` Danilo Krummrich
2026-02-18 23:46   ` Joel Fernandes
2026-02-18 23:59     ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGIUUFLC31D5.2OZBF5FWQJWMZ@kernel.org \
    --to=dakr@kernel.org \
    --cc=airlied@gmail.com \
    --cc=airlied@redhat.com \
    --cc=arunpravin.paneerselvam@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joelagnelf@nvidia.com \
    --cc=koen.koning@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.auld@intel.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ojeda@kernel.org \
    --cc=peter.senna@linux.intel.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox