From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010010.outbound.protection.outlook.com [52.101.46.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6210C352C5B; Wed, 4 Mar 2026 03:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772593829; cv=fail; b=JMn74XFpm1LEqFXdM0J6Q4FsYbix4j/PFB0Xanr0ibxm8GY9WY8phRvUiNI7spRIQfftKmyvr4HW3u/fm7fj5T0hafrfnMZZpBRSLG7qplYg4bpOaljkgeMExdxp0R0bI4zmk1aAoczW6F7czRws7bh1aQarDnr9AaxcdO0qWOw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772593829; c=relaxed/simple; bh=crC4gaHxmI43ZfiR2DmZwEESjl8mO1nlS9oZb045pe4=; h=Content-Type:Date:Message-Id:Subject:From:To:Cc:References: In-Reply-To:MIME-Version; b=L6N4e+HSekINJMoNM20Ihg/K0x72D1KinRSqaUS4WM8JFtVZseUSbip4p/ous5HHcLW/F7b5BoC4DTcVitQMgX0MqUGRghz/giD/zaKDpoAUrICC7VMtvoVpEuUKgqSHr+Tys4zDpU4yzGEokf01Ri0QvHUCB5FXl150ih1FFjo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QSRJEGxD; arc=fail smtp.client-ip=52.101.46.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QSRJEGxD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q5koqflrXR0DhHs+3sQu20fTRkrwidssN3cIvMVLIdMma3hFIYdlg7Qu8poxNjTLCfVOgEcdinDTDofgqz50aDqUj0I6zq36Ey9JngZim9hs5wQrQTSD1VHzavRoAXfq7yF15YcyPAa2scHX20IyC7ciN77K/W4cfp3GsRMW1aD0RZ0qc4pjjWQ0xH0NV09STohtK5RPk5bc6Q7xKD52fPEz2GxfuboauDwG0MC2TTvasA8edTsEAr0jXCLludUg6deW2G2kghns2PF4JGtVdxeky5RSeyajFTk4619CgPUrvblGufjSCO7vpF9KU661tBXqWLRncisphQ+ZU4BW+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DqoNz3abuTG70pQr00srstsF0Jc3y7QiCCDniVEY3/g=; b=VWVqWMgVE09zuKCPre55rZReTK4kqnh4M+77YXECug0el1bOl6j7OJurJ3WlnKzMYArxuGjzQDMzAi5zBqimPQgSJt1pJWYx3PoOCoOBmTNZJCXqbK+iYzGZjwvrXZoVl4TlR2UlWHDYQvoXj0w9/1YdLIb1T2t003triCPJqhdVZtnGBLSj4m71YBDP+wkokjLiW509WWJ/3/7zRBYi59h0WlhOCoGhiqEzKpHATRlzI0JZAMsPh1TetlakPTqNDL12VO3h6paHOUQzbZFEbdXON92RGclcNWqfRAUkWj8Bk1yG4ehqJQsrSxSfLJnH+9kdbXzn8E5zzAYJBV55FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DqoNz3abuTG70pQr00srstsF0Jc3y7QiCCDniVEY3/g=; b=QSRJEGxD/qz6GlykCr77v70p+s/OPIW+zbyfZ5mKDT387dCqLg4emIhEHl4PWFDc0ZNyd0Jf9P6y4eBKdUSZ04Ffpa+tK9Xzd67n3z4xa5JkhmERYmgqGSNXR1htlvpSlq7DbXfS+CCd49HiPjaHlfWhD0oODjS9mODeVn2CyroDG/6Qg20HSMgBB0diXHf2pJXBuTe92DQHJYlr+1w2XNlgMH8ZTZDJ5OrzgKZdPPLI9CM8z5375+bNpL5o72JOHF809MxFY7RFuOuSxv3XERbav/jJPyf4iS+cMI3qkMmxIRbp2cedttN+aiO81YQLXu/lEQjWuBqHEFX8n6Glvg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by CH3PR12MB8354.namprd12.prod.outlook.com (2603:10b6:610:12f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.17; Wed, 4 Mar 2026 03:10:22 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Wed, 4 Mar 2026 03:10:22 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 04 Mar 2026 12:10:18 +0900 Message-Id: Subject: Re: [PATCH v5 7/9] gpu: nova-core: gsp: add `size_in_bytes` helper to `CommandToGsp` From: "Eliot Courtney" To: "Alexandre Courbot" , "Eliot Courtney" Cc: "Danilo Krummrich" , "Alice Ryhl" , "David Airlie" , "Simona Vetter" , "Miguel Ojeda" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Trevor Gross" , "Zhi Wang" , "Alistair Popple" , "Joel Fernandes" , , , , , "dri-devel" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260304-cmdq-continuation-v5-0-3f19d759ed93@nvidia.com> <20260304-cmdq-continuation-v5-7-3f19d759ed93@nvidia.com> In-Reply-To: X-ClientProxiedBy: TYCP286CA0103.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b4::16) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|CH3PR12MB8354:EE_ X-MS-Office365-Filtering-Correlation-Id: 7942f4df-91d3-4d47-23a7-08de799b92c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|10070799003|366016; X-Microsoft-Antispam-Message-Info: F8WDqXUaEXLeN7Hhd1g3vLu3YViydREPM8nnLHwRsRHl97rIS63lKm1xJZTq4Onyu+xkvnDZ6gngcfr3disxUAPLuBitlXtIq6eBi38QblnRxU4cPYdy36ieWi3sq2rw7sTssGEhsgyCwUebhQV8p3yKxjbj9cssGA7L2GsaBV2joN+28WowCH6eWX003j/fvrM60ENLiooXZ1SEKyQyItE8k6jQg8pY62yLQIVyZeKoUXOyu9jE4UXQyg9CAYFJrz3lWhI52j9brltuTGwHrewTC/wt+qa2y+5ZXa21Vj+auA6+kviZYUZ5hiaoOI1kSnq9WqBHmjd1/DoNucaPpMGpV9asCTutJWBFB50DIxFpIrbeDvilMy/tBU3ovTTlFCxTM/KHCKHYAIT/SVY3KZTB3v24oxBGP4eHsjZPoEb5PHO+BkU+z8DZ7kEnmXCyLzYpRm0kzX3dBIQ/EMyfJHW60HxG2jGNeS5ITX543R46g42SVVACdp+UQ0TWds0WYIkcE40AZGy2tLqp5W5PCDzZTk7Vymv2kAHyNrt1Wlfjsv34UF47t7U0nAVCRJUxvaKE4p9JeG4jKIcqjTYvtUSyvxhI/72xYgxF5qgOyl63k1dhEMVeaWrpcT+qH76LuGhRctbRunMKg6DMbjWcAitUljpFw45Qr/SLHoSAEsifigtNHzujOlSbIIdN9pR0D92oCE4s9DGnyuIHKf+cKfV9C2IfeIS61rZYuDWCYIg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(10070799003)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWxnVmwzT05yajlDT3FtbUNtUXp3U0VqekFjUHE5c0dPdFdWaFdHNE05cU5j?= =?utf-8?B?bko3dzlBbXhZWGNSNTUvNWVmMHZRSVFWSnBxTVYrbTJSd3pwNVVHNm0vaVky?= =?utf-8?B?SWZaQzJHK0F4ZXBWRE4zQlJlem9ycVdTU1FnT3JraXZyYkI4U05PSW9IbGhF?= =?utf-8?B?YXZ6T0NNUG1mY1lYRk95a3dVWXRISFd3cXJ4alhtNXdSZElsZVFpdXp6TXlQ?= =?utf-8?B?RzRTMHJnbGc4WlZoRU9rUXFIc21wdWRFQ3JRZzRYbkVTbXc5RmU3cTl0MTJH?= =?utf-8?B?NzRPTVJTY3E0bE8xZTRVSlRwYnJWS3k2bUFTbHFKYXhVSFplbktwM21kbVhB?= =?utf-8?B?QUR2VTI1TDh2SFFHVEpXbHB2NzhiWHZjSU0zNnZMY3ZJeHc0Rmgza3o5NDFz?= =?utf-8?B?NmxqM3cya1pkRUF2M29wMEhVa3N4ZmM5ZXJ2c1gwK1AzeFN6d0Z5NEJpWmVp?= =?utf-8?B?Z3plRFN5S1ZPdkNSTG1XeFMwVktxNzhvaFRsMkQ1RjJsekdtRGFIcUJBTEFk?= =?utf-8?B?RVJ3K052ZHdaclpMVi96RXU0SHdKekszU2lDTXFQa05PN3dmOVVKSWtteDhv?= =?utf-8?B?UldhczQrVEFhQldiWW1Dc1Zkb0JJQWZMcmNrY1A4TnZWaFVMZEpXMGZTa2Mv?= =?utf-8?B?VzE3QzQybE1jRHp6L1RmTkkvZlpFWURUR3hKcDJUZloyc1FxY0YwM20rWG5h?= =?utf-8?B?WTgzQlZjYXVxdmh1WHc1akR6WUZ0eG1wblJSUU1hVVVvdFhYTFdMbExHdjQw?= =?utf-8?B?MFNUSnQzV0g5dC90SUpVekNZNjRycGVwbk9HSTVPRGcyZSthbmNBMzIxd3dw?= =?utf-8?B?NzNjOGRWN2wxSzQvMXpnT3p4bW5YRm01T1BuRUJ6SUlIRjJiano4SkJGdys0?= =?utf-8?B?MWZ6L3Fic2JrdFZlcWhyWFlJVFNLdkk1VXhxSXVKWkdIMVlWdWsyYmRHaWhF?= =?utf-8?B?ZWdSdVdDZFY3cjRTdHovcU8yT2RDdEpYUDhNeGc5RkIvazBKR0VrUXlKVlJS?= =?utf-8?B?NDE4RnRzVU9BenVQMHMwY05YclVSUC9oUnI4clJYM3ozQlBMVmVuUnhLNFF6?= =?utf-8?B?a0RmV2YrbHduT3U0aUJudGZjUnl6VEJIZk8yMEYrTzBYU1VFcytqUlI1TWFm?= =?utf-8?B?M3o2UUhjc2p6Ukt5U29GRDNTdkxRQjQyYnNEWHd4dmVNSjVDekZ6VXZSNWR6?= =?utf-8?B?RXAwYkR5VEh5NWhKTXVGRG5EbSthTzRIS1JUaVUzTDQzWHdpaEdScFNYZHFs?= =?utf-8?B?eXBjUXczL3ByekROQlBRdWxBYkozakZ0SS9ueWVma3hlT0dDaTlqQmNwSnlt?= =?utf-8?B?MGZQZlNFZm8xZFlBcXQ0Zy9uSlEzTjJyeDNwNEpjMVVhV2NwUFdkazFsSTc0?= =?utf-8?B?MFNHc3hKMlhnUk11Kzl4WDFKL0p0ZkpBajlUVDh6aGFNVmIxcnF4QW5PeXVh?= =?utf-8?B?anhZZlo3T3Zxbm0xcUMzbSs2UXlOSmRxa0trZHRJbUNPTlVRTHptZ0J0RUk5?= =?utf-8?B?TzFtME5aMUgxZTFWRVJIcm9aek4xajdmR2hKRGUveVdLUUhKNFp5SUJZVGdQ?= =?utf-8?B?WkQwYmJjUkhyVCsvbGdaRWpNUkVUbk1CSmRKTGZrNndXR3NOdzV2ZUdUZEhH?= =?utf-8?B?aGhNT0ZnREJ4RXF4MTQyUE4wM3F1aC9iNUJKNzZkSHlwUFEvTlFRUzFubmhU?= =?utf-8?B?b3BZWEZVK3RaeWNnWHlZWUxOTElza1R3K08yaEx2ZW5RazR6UnQ5aUt4ZnNC?= =?utf-8?B?S204SGZGQ2Z2OXdOdGlNMkQzMCtYZ0FNM05USzJ6WU0wWFRocEI4TWhsWHQv?= =?utf-8?B?U3ZHcnAwdmR4NEZTY0JjM2I1MDlQQnZONHU5aEVyWmZOekNKL0pFRUlxSkcy?= =?utf-8?B?UDM0SlZvSTRpVTRyTk55Z1REd3hSdGlkbFlJRWtJKzVBb0VTaFBod3psamIr?= =?utf-8?B?eHVVZlZLbkhqdFlxS242enZGN2dKd1F1V1VQNCsvYWh1emhSamhJRklzRTE3?= =?utf-8?B?Ui9JTUR5ZGRiSkJpOUNMYThjWG5ERjVidWFSMElrKzl6ZzJQNjQ2OVN6ODcx?= =?utf-8?B?R2xEVmdUNTZuMHZQVTRrOTJZS3F0R09sWElHNXdqaEhrV3lqMExjVFdRalhp?= =?utf-8?B?cElLVllYWERIY1VGSXBLQkt2V3VVa1VCaVRWRW00N1FUMmN4L1krOW1YbEVj?= =?utf-8?B?Yi80aEFZTWpHbFg5TDUyRWZ4MEZ3SlpFZlJCaVVjZ2RPTVRHNFhWNUpTd1ZZ?= =?utf-8?B?aVRwdytobjI4VWRZTlFVRDJPcGlucUlQVmhzVytXbWtmWTlLY1FCenloMmVB?= =?utf-8?B?anBwSi83Tm1OMkpoNHY2Q1cyWThJbUpBTGNXUmYzdFptVmVpeGpEZVhsaEs0?= =?utf-8?Q?e5oXZcUZdhekaFtIEQxqcZ/AYqHMlXLyFFism4c2Ct2VO?= X-MS-Exchange-AntiSpam-MessageData-1: 6xQ/aYureh84zQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7942f4df-91d3-4d47-23a7-08de799b92c5 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2026 03:10:22.3365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xOhVGW/2EXuxP7LVJUOBjU3VxMn7+S+yLGFhbchc39HNVJEKsbGFk8l7qKhBB7tBFM+U3UjtUGydL5ARpzwZvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8354 On Wed Mar 4, 2026 at 11:53 AM JST, Alexandre Courbot wrote: > On Wed Mar 4, 2026 at 10:42 AM JST, Eliot Courtney wrote: >> Add a default method to `CommandToGsp` which computes the size of a >> command. >> >> Tested-by: Zhi Wang >> Signed-off-by: Eliot Courtney >> --- >> drivers/gpu/nova-core/gsp/cmdq.rs | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/g= sp/cmdq.rs >> index 48cf28b41f39..3424be4e15f8 100644 >> --- a/drivers/gpu/nova-core/gsp/cmdq.rs >> +++ b/drivers/gpu/nova-core/gsp/cmdq.rs >> @@ -94,6 +94,12 @@ fn init_variable_payload( >> ) -> Result { >> Ok(()) >> } >> + >> + /// Total size of the command (including its variable-length payloa= d) without the >> + /// [`GspMsgElement`] header. >> + fn size_in_bytes(&self) -> usize { > > We usually don't specify the unit in the method name (the doccomment is > a better place for that). I can fix this when applying. Thanks, I will make a note of this so I don't make this mistake again. I wanted to clarify this since size for a command could mean a few things.