From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010009.outbound.protection.outlook.com [52.101.46.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B0AB3909AD; Wed, 4 Mar 2026 12:03:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.9 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772625787; cv=fail; b=V1yMzPIsIX3j/nrnsuzSzBskitbck6/VeYXN/0lzuaJOYAMxkrxCz/0sjw7G2K8P64AakmYw2Ota7rpuTG2LSVAvqjrUnviY9rkAaXVsGyURaOXB5j+5wWHNrPoMXbxAE3cYWVPt8kRJ+n4FujJ/Tcv9UDK2/pFJdNJzF+ehijk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772625787; c=relaxed/simple; bh=6syZumwyiZ/zEYN2lwzSfGqRZdcGn2HF/PaUdUNkdh8=; h=Content-Type:Date:Message-Id:Cc:Subject:From:To:References: In-Reply-To:MIME-Version; b=MjE1WCmVl1v35PUKQk1V28vhfnQK24HApqnl37utk2PU72Yw3jDKW8js5vDXFod+UWI8ybXi2bDvpz144Drh2CtpjHmC5eN/BCFxuRWakSbUnLit3epwt+PZ9CBOvDl5BSbRJj7psLKMyxHxXcrafDvcLF8UcbSGyNRp2c0XRrg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=bfqkkNzp; arc=fail smtp.client-ip=52.101.46.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="bfqkkNzp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=atk6PIZRRg5IABGrtZXEzmDWs8T0B0EAY8nCd1yaqlSShl2f4D6OsiOBfRjybYxkhvrlEN614NgUi0uK6TAjb8ztHms3X7rcH3d1iZ5I+1IpDjP7l1YfenESLGrNTLF3H9JlfUwobFiDq9JWLA/+aldK1HdU59NB1LxZlBFTRekCunfv81uSC5evV0RIG13kGvaV/TCYvSiAGl50GGEjNC83UFUpUlHRSEKflJKnTi9leRlNE7LB0uy4wE55tW6AP5oFFB7iSoaziVyGi8pbH1FANo/N2jy7m3+JL0VlICEJ22luTy7vwY5RzHI8IObvYJZkCE+p/jGxe9vQUkyD7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wyqAcTUTpgzYd7tdXeRkaPWfYJOiN1Fc+hFiCJ47WIo=; b=Q9Z7n20ELEPENCpuH+dG7v2uaW4/kOkQPKpamfa6SOz2BwzJG2ayOIaKGI8yS7hTkCeBlqk7Gx/h+npaN/VsBCZ+gZnld2x6KKyTNvsRfrl0t2GTqNk6R1ugjYbn4hxqbPkAMl8+iYNw9xp6wx5g6zcbZ6f+jgx2zqmNL4n9e2EEdoMry3D27xpshKN2Yz6HGIuuUvnfjyhqYuA3VB2W8cVzmVMchiRHhNB8uRw2A8gKQFqFprayDLIRj18/vZaPGcAETUiMn/cwyr+Bdst/NRvx3bUpPysBRBr1994xKdKkbBFA0Lb4seQb/882mW9tu5rcJhDv+UDliQmcupHnDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wyqAcTUTpgzYd7tdXeRkaPWfYJOiN1Fc+hFiCJ47WIo=; b=bfqkkNzp7eoeI+y7xCso/z6HJqw6AWmArgnOpIgSN3qDOdKG+g1dA0j7jOjKeCIcg/0dqzV6tXQBPT1rr2lQPyt49KRsLjKoZUNN3WL7xieIZLQ3dH4nC9TWRXE0wKMxomuw3rv5okCBXF0q2Vnl1CHJG0qTlj+d9D71/kbBaB0UF7NvN5LPZ8UtlKUa8OXrzDq1HUonwCImB5zJ06Fk5Habm2sW5guGX/NY8ypcGeR166BvWut0XDIXlulZKbfKpuUv2tXBfqKlDmrZSJUS4rk8g4JU2pG4709xxYSoZw2Uiw3AeGHwzSZKJ4eTKPS5gulUdx2fHWs9FgC0dFqX4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB6389.namprd12.prod.outlook.com (2603:10b6:8:cf::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.17; Wed, 4 Mar 2026 12:02:58 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9678.016; Wed, 4 Mar 2026 12:02:58 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 04 Mar 2026 21:02:54 +0900 Message-Id: Cc: "Danilo Krummrich" , "Alice Ryhl" , "David Airlie" , "Simona Vetter" , "Benno Lossin" , "Gary Guo" , "Alistair Popple" , "Joel Fernandes" , , , , , "Zhi Wang" Subject: Re: [PATCH v3 5/5] gpu: nova-core: gsp: add mutex locking to Cmdq From: "Alexandre Courbot" To: "Eliot Courtney" References: <20260304-cmdq-locking-v3-0-a6314b708850@nvidia.com> <20260304-cmdq-locking-v3-5-a6314b708850@nvidia.com> In-Reply-To: <20260304-cmdq-locking-v3-5-a6314b708850@nvidia.com> X-ClientProxiedBy: TYCPR01CA0038.jpnprd01.prod.outlook.com (2603:1096:405:1::26) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB6389:EE_ X-MS-Office365-Filtering-Correlation-Id: 9080d2bb-57df-419a-d0cb-08de79e5fa0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: J8tpzK7DxMe8q3Z3OJCAHf/qSSWxkE9sNj3SM7/dB7ucMibzrTspMPVDa9aPdo6YDnquiSk1UfRHuBoYno1Ap4PuSPVBrdM14dnUhqAV9OejaZHNbou2nv9E3fvs2/GjItinoq54hBFwXIDuG+EHqRjzeV/AnW8AKBWooYs7XrkEdpej9pLX92+NdB23PCw2PcLkzA3ytjjzspDzt0gI4TnBIEdh4dQduAyh6zfPLkMWra75w9kEJNxUv6PETnm7QYXkUcVRoq21fgkwV7g0fBgWQ1bKUWUiZfpObXSjxTEURlfj3HA432vB2OWnnXKya6ZS2b8uM3jxS3rT/oBO3RP0Gsy6VFbnrtLi5JLU2JKZlvijUJ5vbE8OMMEJ0adfKrfZqpj+YglnpxT43z6rsToxGYp0v//ChLobgSSQL/jLg65cWQiAQQgYfV/lwTv7d0G/l2jKKctMSnrXBJCYNqsS2bfh8hQeej3y9Fmt33VfZeVKNQZqDlY9JcJ2CMFcEg5w0240e0YcOtih69mpimXM8WahbwQUBkfJNtJfq56MMUtCCXsKaWhAd7nM2j/Lc3Qqf93g2YYFGKQut+Mxor05ZAN/IzDpaorT01wLgR9Tlc+aQnL9ZoZU7fkvflOgkkMmLNSf6WxG/KYjq5+4bd/uK5xCCDoL3Rp4ABSfJ3+219oi70XjxahZFa0vYcIwZYOuh3Y1R1akEsB5p71S43PhgSK48cY/XytOL+kzgwQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWZFUkoyVDJnV1gxVjVac1YzU3NNYjJ3Vk9vN0tnczYreGUvOS8xVS9HUUhW?= =?utf-8?B?UkVSanFUakNjNjdXWnZ2RHNrZitmL2Z2RGh0cjBpTzNOcVhpd2JhaWthM1VC?= =?utf-8?B?Y2w2UGk5aGx6amZQbW5yVUpJVExBN2c3MmlMLzNxS1J6Q1J4Nkl4blJicEU3?= =?utf-8?B?aVA0RE54S1k3RS9IM3o5c1JMWHhRMTFrdnFCbGlPaHltZGlSdEc0a3BGdnNC?= =?utf-8?B?NTlTZ2tlRm91czhoWENWQW9EL0FCLzBvTkZ4aU56V0s1NGdXM2k3bmpPcTVK?= =?utf-8?B?SXVjd1RiUzBrY2c2ck9VcXl2T1huWkJEUzUydCt4NHpYREZKckpTYnFsdjBS?= =?utf-8?B?ZXR1OWpGUWwxVklLL3NySTJFR2tlODRpRURsV0JBc2Q0bVZhM1ozM0R5bEQ2?= =?utf-8?B?Vm9KTXZ0VEc1MWRncWhhK2hHUy9STGxyU2JiamNNa0pqb3RITjJZZ3Z1U252?= =?utf-8?B?cXBMTWlKM2NMcU93OXJsbjcwMzB5Lzh4MnEwSmUzR1Y5RnRDbXdXV0RSQ1pt?= =?utf-8?B?YUorVmlZV2tVak43RjZvcFQ0eGovZXFBNkxzaS9lcjN6VEUwRVVCelFyekVP?= =?utf-8?B?QTBkckJ2c3ZwSGFtd2c1WFBMOWVXbXFDVGNLb0k4VmRRVlBKd1o5bUtGMjJt?= =?utf-8?B?S2x1aWpmRnR6b0kwekZsbGdjUVpaYjdFVnMzdFRRcm5rOW0wSGp5SHdmM0VH?= =?utf-8?B?elRIVGpxakxlV3M3d2xxWmF2aTlxT3A0cXhBa2dNbkNjQWI0UWx0L2FaSk9w?= =?utf-8?B?YjhDUFdVZ0dhUGVSeVl6eEkxN3ViaEpaa1FxdDlqSG9RQzdPcVVOUUtmdUxl?= =?utf-8?B?M0ZwcWUrd3UvSzYvL1Qwd0hMNzZ6cWhLckQ3MDZ1Q3VFbUdrZkdBTHdXK2Ro?= =?utf-8?B?Si9NR0EwNmJodlVBSldYTTZ3T2U2TGI4T0twSjM5dG5YSmdjbENYM3ZFVm9i?= =?utf-8?B?WHBzNTRaRDU1V0dpdGRMdXBtV2ppWUxaOEc1SWV2UjZzaVhRVTB3ZGxzV2Np?= =?utf-8?B?U3hnQUJUbU42S25jOU1wVkZWRU03WGcxdldJNDlvQllsVWhab0hvbHRtL2ph?= =?utf-8?B?QjRremRQTmZkZUpXdUF2WWVOY0U5VjJSaTBWdFNRallUWml2QTNXZi82enFR?= =?utf-8?B?Y3NZWFhhRVlYWkpYNFJOdzB1K2FnMGRtN0tlV0RETkcvYVFtNWg5bmdOaU9I?= =?utf-8?B?bHArbm5xbWJWSTdrejVkb05vcmVaTzV4LzFweHRpTmxtY0g2aWczeDBsZUdH?= =?utf-8?B?aUdBSjFIcUtuYklPN3N4NnhuSUlyOThQS3A1RlZxelgxTk9NSkptNld6WlZY?= =?utf-8?B?NXp2Q3l3alBRelZ0Rk03aVNaTFBJVHoxQkpTNmluSGZueW1Ta1pHOTVJTkE5?= =?utf-8?B?UitCaEV0N3loSWdSVG44bFIxTDNNMHF4TkpZeVRIWUF3T0VicU9KZWZkYngy?= =?utf-8?B?WU1VZDZFaVp5TFB3ekxOdHhRaEc0blYwL1oxbFVNNTFydXFtRlJISUpTN0Jj?= =?utf-8?B?T0ZuSmdYS2NReUtPQ0RDanZ1bm9Qd3Y3alliSi92ZVljTDJNeDhCYkwzcU0w?= =?utf-8?B?WnhXVWJTZG1JVHliS3lJbndjOE9VS2NuNWxyQ0dJMXB4VXMrbmhpajNoT1M1?= =?utf-8?B?YkppSE1mVkd0T0t6RUhJOVJNWEhmRkpGMmdsbFBZM2pPTFJ5WjdzTVpZOUxt?= =?utf-8?B?VjA4d1ZIRHdIL0lwSjNLMjFaSWVZNmtuaGNzV0JxTVBqa2JTRFdHK0pENEpj?= =?utf-8?B?ZndWL0ZUejZhTkJYZzhxMFhPKzdFNEFjRFVGa1lydk5JLzlYSnlOQnMvbHl4?= =?utf-8?B?a2JXVW5XUW80YUlWZ01NeW5TZ0drTlQ2dkRPNy9YMGlvaGNwWnZwUVZjTnFB?= =?utf-8?B?RU56MHY4UGxvVDJ5NGViakN3ZzQrL2hxRzE2eEtDV3BUTDdWNVBDdnJDQnBa?= =?utf-8?B?WE1WS1FlTDNEZmFVTFp3TlJCY0o1MUsra1pJVDhHNWxFaXRFRUNOT1p4Rk40?= =?utf-8?B?Q3VTSkxJdnYzWGNjTXZ1aHhta0RrbVd5MlBROWpYMjY0ZVZoc2NLWHJHcmll?= =?utf-8?B?Zi9JSWo3SWhrZXl5Mm5lYUxMcmtzTnFyU3BQQnNrREpiUUNFNWVKTmRyelZ0?= =?utf-8?B?YnYwMno5bzZ1RU9OU21tYTlTcW5QNTA3TGwzdkE2bTdpQmIvcklIdTJTaExu?= =?utf-8?B?VUp2d0ZhT252R2x6cWw2OEtaaTBPSlhUaDE3V0NwRGw5OXkzbzM2V0cybXk1?= =?utf-8?B?dzJDVlpRUmc1a2V0aTBVTU9GQTNGOS9LbjZsOUZWRUV6VzdENmhOQWh4UUww?= =?utf-8?B?cXNVdk5EVk1PcDgyc1BRK0dQK0xxdW5XeEZmKzhRNkdoY0VXd0V2ZnZnN1ha?= =?utf-8?Q?97dNZrPC3xlohTABRJxZTseB41WE/Hp59hc9pNXn3+qFJ?= X-MS-Exchange-AntiSpam-MessageData-1: IXCsWSGvdvkICQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9080d2bb-57df-419a-d0cb-08de79e5fa0c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2026 12:02:58.7440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1z3EoDkb/Bqh+u777O8AiopSQWCdOTEK1oTjQ53ZWg3DYrG2McC0rmWvBNnjbp14ETE298s/SKtYMJ/BZJuu8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6389 On Wed Mar 4, 2026 at 11:46 AM JST, Eliot Courtney wrote: > diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gs= p/cmdq.rs > index de84a298909f..94cb2aa6568d 100644 > --- a/drivers/gpu/nova-core/gsp/cmdq.rs > +++ b/drivers/gpu/nova-core/gsp/cmdq.rs > @@ -18,8 +18,12 @@ > }, > dma_write, > io::poll::read_poll_timeout, > + new_mutex, > prelude::*, > - sync::aref::ARef, > + sync::{ > + aref::ARef, > + Mutex, // > + }, > time::Delta, > transmute::{ > AsBytes, > @@ -57,8 +61,8 @@ > =20 > /// Trait implemented by types representing a command to send to the GSP= . > /// > -/// The main purpose of this trait is to provide [`Cmdq::send_command`] = with the information it > -/// needs to send a given command. > +/// The main purpose of this trait is to provide [`Cmdq`] with the infor= mation it needs to send > +/// a given command. This looks unrelated - should this chunk be merged with the reply/no_reply = patch?