From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01AF22EA171; Sat, 7 Mar 2026 21:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772919666; cv=none; b=B3XrGyFHBwIEuSpm7GzuLiMjQG2rbDvElhR2JvscMY62SE94LBjJ+giVEsUqey8LdqjvlX/dEBvU/qrM2NzXRQC98AzG/uIqSa6SVsO7+jYlEAcNs2U1g7fbwuOBAwMX1EIQVicdt8tB8pd48rafOp7Hyg0l9ULLeZGVHvF+0lA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772919666; c=relaxed/simple; bh=La9CHRdOrLzZLDPTAtAarkgvYs/tV6l4hovAURiSbWs=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=Rz9B1q8oARzNpI7L0+8mMDikmfE5D9skLP6SV6AC64NnwJW6FP8eQVceqQHLUZuTXPNWoQAoYi3IHq8k3/TGvcGtl4ayGxu5NxztExyzZPMii+synGtqfDsPloQEzfFTr28oL1nBjJ8ThoaFE8xYFMB+TjW+LZnRqaEOzliqSpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H95SauM8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H95SauM8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F11D8C19422; Sat, 7 Mar 2026 21:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772919665; bh=La9CHRdOrLzZLDPTAtAarkgvYs/tV6l4hovAURiSbWs=; h=Date:To:From:Subject:Cc:References:In-Reply-To:From; b=H95SauM8cMdRQfmSjJluEq8aC2rl46kqs9CmLlS3flPDGexJ5R4xuif9BMgpdsbV2 pZrp5gzJAJQ8LY9vJti5i6kN3kLq4bYGtkwsa+wqufxMOnam3N0RBCtW5c/V7UeSJv RORBiaElmYpn1Z18xNhoDrFmEa3w3v95O2PPcf3WHGKy8JcLZ42wBSsZRdwqA7Kl8l eN/Uuw+K6x+vNiVwwDQ0fcDNaXH5BRi3b5Ek9xuWhfKneyG/1ClMFKfeUKL873VUBl nOK/n8U4i3TcAtmHss+HGbLrhkFQEdhXUVlnQipuZW45KSMJ/viqZZzdiEmWLghvsl 1wwTD6KoxVTMw== Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 07 Mar 2026 22:40:58 +0100 Message-Id: To: "Gary Guo" From: "Danilo Krummrich" Subject: Re: [PATCH v7 05/10] rust: io: add IoLoc and IoWrite types Cc: "Alexandre Courbot" , "Alice Ryhl" , "Daniel Almeida" , "Miguel Ojeda" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Trevor Gross" , "Boqun Feng" , "Yury Norov" , "John Hubbard" , "Alistair Popple" , "Joel Fernandes" , "Timur Tabi" , "Edwin Peer" , "Eliot Courtney" , "Dirk Behme" , "Steven Price" , , References: <20260224-register-v7-0-aad44f760f33@nvidia.com> <20260224-register-v7-5-aad44f760f33@nvidia.com> In-Reply-To: On Sat Mar 7, 2026 at 10:10 PM CET, Gary Guo wrote: >> But if we can agree on >> >> bar.put(Reg::foo()); >> >> or even >> >> bar.write_val(Reg::foo()); > > I'm okay with either. write_val() or something similar please; put() is not a good choice for something that does not release a reference count in the kernel. (As for write_val(), I'm generally fine with the name, but I want to note t= hat it also may be slightly confusing as it is the two-argument write() method = which distinguishes between location and value, whereas this one combines the two= .)