public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Markus Probst" <markus.probst@posteo.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mfd: Add initial synology microp driver
Date: Mon, 09 Mar 2026 14:32:41 +0100	[thread overview]
Message-ID: <DGYAFNSJ7576.1E0JZ2W499ZQ7@kernel.org> (raw)
In-Reply-To: <7f8d979a881b29398f524f526f52ba9727d95a7c.camel@posteo.de>

On Mon Mar 9, 2026 at 1:52 PM CET, Markus Probst wrote:
> Yes. I will split it into multiple drivers using the aux bus in the
> next revision.

Independent of the other discussion whether this belongs into the kernel in the
first place, reading over the cover letter and commit message I understood the
following.

  "Synology uses a microcontroller in their NAS devices connected to a serial
  port [...]" controlling LEDs, fan speeds, a beeper, etc.

  I.e. it muliplexes several physical functions that belong to different
  subsystems, such as hwmon, input, etc. over a single serial port.

This sounds like a textbook candidate for MFD to me.

I.e. there is a very loose coupling of the different functions that make up for
entirely independent drivers, except that they share the same serial port
connection.

Whereas the auxiliary bus is more for very complicated devices to be broken down
into more managable (sometimes optional) sub-domains, where the corresponding
drivers usually have driver specific APIs to interact with each other.

- Danilo

  parent reply	other threads:[~2026-03-09 13:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 18:41 [PATCH v2 0/2] Introduce Synology Microp driver Markus Probst
2026-03-08 18:41 ` [PATCH v2 1/2] dt-bindings: mfd: Add synology,microp device Markus Probst
2026-03-09  7:17   ` Krzysztof Kozlowski
2026-03-08 18:41 ` [PATCH v2 2/2] mfd: Add initial synology microp driver Markus Probst
2026-03-08 18:55   ` Greg Kroah-Hartman
2026-03-08 19:15     ` Markus Probst
2026-03-09  5:56       ` Greg Kroah-Hartman
2026-03-09  9:43         ` Lee Jones
2026-03-09 12:52         ` Markus Probst
2026-03-09 13:07           ` Greg Kroah-Hartman
2026-03-09 13:34             ` Markus Probst
2026-03-09 13:32           ` Danilo Krummrich [this message]
2026-03-09 13:38             ` Markus Probst
2026-03-09 15:15               ` Lee Jones
2026-03-09 15:20                 ` Markus Probst
2026-03-09 15:27                   ` Lee Jones
2026-03-09 15:37                 ` Danilo Krummrich
2026-03-09 15:50                   ` Lee Jones
2026-03-08 18:56   ` Greg Kroah-Hartman
2026-03-08 19:23     ` Markus Probst
2026-03-09  5:55       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGYAFNSJ7576.1E0JZ2W499ZQ7@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=markus.probst@posteo.de \
    --cc=ojeda@kernel.org \
    --cc=robh@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox