From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Timur Tabi" <ttabi@nvidia.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Gary Guo" <gary@garyguo.net>, <mmaurer@google.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
<rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v10 0/6] gpu: nova-core: expose the logging buffers via debugfs
Date: Thu, 19 Mar 2026 11:28:42 +0900 [thread overview]
Message-ID: <DH6EKPTX3M0Q.Z1TLBFDVOFAF@nvidia.com> (raw)
In-Reply-To: <20260317235403.1094713-1-ttabi@nvidia.com>
On Wed Mar 18, 2026 at 8:53 AM JST, Timur Tabi wrote:
> GSP-RM writes its printf messages to "logging buffers", which are blocks
> of memory allocated by the driver. The messages are encoded, so exposing
> the buffers as debugfs entries allows the buffers to be extracted and
> decoded by a special application.
>
> When the driver loads, a /sys/kernel/debug/nova_core root entry is
> created. To do this, the normal module_pci_driver! macro call is
> replaced with an explicit initialization function, as this allows
> that debugfs entry to be created once for all GPUs.
>
> Then in each GPU's initialization, a subdirectory based on the PCI
> BDF name is created, and the logging buffer entries are created under
> that.
>
> This series depends on Eliot Courtney's Cmdq patch set [1].
The series now applies nicely by itself on drm-rust-next! I'll let
Danilo coordinate its merging with the rest of the I/O related stuff
(hence my Reviewed-bys on the nova-core patches).
I think it looks great now, thanks!
prev parent reply other threads:[~2026-03-19 2:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 23:53 [PATCH v10 0/6] gpu: nova-core: expose the logging buffers via debugfs Timur Tabi
2026-03-17 23:53 ` [PATCH v10 1/6] rust: device: add device name method Timur Tabi
2026-03-17 23:53 ` [PATCH v10 2/6] rust: uaccess: add write_dma() for copying from DMA buffers to userspace Timur Tabi
2026-03-17 23:54 ` [PATCH v10 3/6] rust: dma: implement BinaryWriter for CoherentAllocation<u8> Timur Tabi
2026-03-17 23:54 ` [PATCH v10 4/6] gpu: nova-core: Replace module_pci_driver! with explicit module init Timur Tabi
2026-03-19 2:24 ` Alexandre Courbot
2026-03-17 23:54 ` [PATCH v10 5/6] gpu: nova-core: create debugfs root in " Timur Tabi
2026-03-19 2:26 ` Alexandre Courbot
2026-03-17 23:54 ` [PATCH v10 6/6] gpu: nova-core: create GSP-RM logging buffers debugfs entries Timur Tabi
2026-03-19 1:11 ` John Hubbard
2026-03-19 2:28 ` Alexandre Courbot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH6EKPTX3M0Q.Z1TLBFDVOFAF@nvidia.com \
--to=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=mmaurer@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox