From: "Gary Guo" <gary@garyguo.net>
To: "John Hubbard" <jhubbard@nvidia.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>
Cc: "Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"Shashank Sharma" <shashanks@nvidia.com>,
"Zhi Wang" <zhiw@nvidia.com>, "David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 01/31] gpu: nova-core: Hopper/Blackwell: basic GPU identification
Date: Wed, 25 Mar 2026 15:36:17 +0000 [thread overview]
Message-ID: <DHBZ30B3HVTR.1VYA64MM8C4JO@garyguo.net> (raw)
In-Reply-To: <20260325035242.368661-2-jhubbard@nvidia.com>
On Wed Mar 25, 2026 at 3:52 AM GMT, John Hubbard wrote:
> Hopper (GH100) and Blackwell identification, including ELF
> .fwsignature_* items.
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> drivers/gpu/nova-core/falcon/hal.rs | 3 ++-
> drivers/gpu/nova-core/fb/hal.rs | 5 ++---
> drivers/gpu/nova-core/firmware/gsp.rs | 9 +++++++--
> drivers/gpu/nova-core/gpu.rs | 22 ++++++++++++++++++++++
> 4 files changed, 33 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs
> index 8579d632e717..3b4ccc3d18b9 100644
> --- a/drivers/gpu/nova-core/gpu.rs
> +++ b/drivers/gpu/nova-core/gpu.rs
> @@ -83,12 +83,22 @@ fn try_from(value: u32) -> Result<Self, Self::Error> {
> GA104 = 0x174,
> GA106 = 0x176,
> GA107 = 0x177,
> + // Hopper
> + GH100 = 0x180,
> // Ada
> AD102 = 0x192,
> AD103 = 0x193,
> AD104 = 0x194,
> AD106 = 0x196,
> AD107 = 0x197,
> + // Blackwell
> + GB100 = 0x1a0,
> + GB102 = 0x1a2,
> + GB202 = 0x1b2,
> + GB203 = 0x1b3,
> + GB205 = 0x1b5,
> + GB206 = 0x1b6,
> + GB207 = 0x1b7,
Sashiko asks if it'll be problematic that 0x1a and 0x1b are both Blackwell.
https://sashiko.dev/#/patchset/20260325035242.368661-1-jhubbard%40nvidia.com
Can you confirm that it is indeed actually okay and is a false positive?
Best,
Gary
> [snip]
>
> @@ -139,7 +157,9 @@ pub(crate) enum Architecture {
> #[default]
> Turing = 0x16,
> Ampere = 0x17,
> + Hopper = 0x18,
> Ada = 0x19,
> + Blackwell = 0x1b,
> }
>
> impl TryFrom<u8> for Architecture {
> @@ -149,7 +169,9 @@ fn try_from(value: u8) -> Result<Self> {
> match value {
> 0x16 => Ok(Self::Turing),
> 0x17 => Ok(Self::Ampere),
> + 0x18 => Ok(Self::Hopper),
> 0x19 => Ok(Self::Ada),
> + 0x1b => Ok(Self::Blackwell),
> _ => Err(ENODEV),
> }
> }
next prev parent reply other threads:[~2026-03-25 15:36 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 3:52 [PATCH v8 00/31] gpu: nova-core: firmware: Hopper/Blackwell support John Hubbard
2026-03-25 3:52 ` [PATCH v8 01/31] gpu: nova-core: Hopper/Blackwell: basic GPU identification John Hubbard
2026-03-25 15:36 ` Gary Guo [this message]
2026-03-25 21:34 ` John Hubbard
2026-03-25 3:52 ` [PATCH v8 02/31] gpu: nova-core: factor .fwsignature* selection into a new find_gsp_sigs_section() John Hubbard
2026-03-25 10:45 ` Alexandre Courbot
2026-03-25 21:56 ` John Hubbard
2026-03-25 3:52 ` [PATCH v8 03/31] gpu: nova-core: use GPU Architecture to simplify HAL selections John Hubbard
2026-03-25 3:52 ` [PATCH v8 04/31] gpu: nova-core: add Copy/Clone to Spec and Revision, add chipset() accessor John Hubbard
2026-03-25 10:47 ` Alexandre Courbot
2026-03-26 1:21 ` John Hubbard
2026-03-25 15:42 ` Gary Guo
2026-03-26 1:21 ` John Hubbard
2026-03-25 3:52 ` [PATCH v8 05/31] gpu: nova-core: set DMA mask width based on GPU architecture John Hubbard
2026-03-25 10:53 ` Alexandre Courbot
2026-03-26 1:22 ` John Hubbard
2026-03-25 11:31 ` Danilo Krummrich
2026-03-25 11:45 ` Alexandre Courbot
2026-03-25 13:38 ` Danilo Krummrich
2026-03-25 13:56 ` Alexandre Courbot
2026-03-26 1:22 ` John Hubbard
2026-03-25 3:52 ` [PATCH v8 06/31] gpu: nova-core: Hopper/Blackwell: skip GFW boot waiting John Hubbard
2026-03-25 10:53 ` Alexandre Courbot
2026-03-26 1:22 ` John Hubbard
2026-03-25 15:45 ` Gary Guo
2026-03-26 1:23 ` John Hubbard
2026-03-25 3:52 ` [PATCH v8 07/31] gpu: nova-core: move firmware image parsing code to firmware.rs John Hubbard
2026-03-25 3:52 ` [PATCH v8 08/31] gpu: nova-core: factor out an elf_str() function John Hubbard
2026-03-25 3:52 ` [PATCH v8 09/31] gpu: nova-core: don't assume 64-bit firmware images John Hubbard
2026-03-25 3:52 ` [PATCH v8 10/31] gpu: nova-core: add support for 32-bit " John Hubbard
2026-03-25 3:52 ` [PATCH v8 11/31] gpu: nova-core: add auto-detection of 32-bit, 64-bit " John Hubbard
2026-03-25 3:52 ` [PATCH v8 12/31] gpu: nova-core: Hopper/Blackwell: add FMC firmware image, in support of FSP John Hubbard
2026-03-25 15:52 ` Gary Guo
2026-03-26 1:23 ` John Hubbard
2026-03-25 3:52 ` [PATCH v8 13/31] gpu: nova-core: Hopper/Blackwell: add FSP falcon engine stub John Hubbard
2026-03-25 3:52 ` [PATCH v8 14/31] gpu: nova-core: Hopper/Blackwell: add FSP falcon EMEM operations John Hubbard
2026-03-25 3:52 ` [PATCH v8 15/31] gpu: nova-core: Hopper/Blackwell: add FSP message infrastructure John Hubbard
2026-03-25 3:52 ` [PATCH v8 16/31] rust: ptr: add const_align_up() John Hubbard
2026-03-25 8:22 ` Alice Ryhl
2026-03-25 15:52 ` Gary Guo
2026-03-25 3:52 ` [PATCH v8 17/31] gpu: nova-core: Hopper/Blackwell: calculate reserved FB heap size John Hubbard
2026-03-25 3:52 ` [PATCH v8 18/31] gpu: nova-core: add MCTP/NVDM protocol types for firmware communication John Hubbard
2026-03-25 3:52 ` [PATCH v8 19/31] gpu: nova-core: Hopper/Blackwell: add FSP secure boot completion waiting John Hubbard
2026-03-25 3:52 ` [PATCH v8 20/31] gpu: nova-core: Hopper/Blackwell: add FMC signature extraction John Hubbard
2026-03-25 3:52 ` [PATCH v8 21/31] gpu: nova-core: Hopper/Blackwell: add FSP send/receive messaging John Hubbard
2026-03-25 3:52 ` [PATCH v8 22/31] gpu: nova-core: Hopper/Blackwell: add FspCotVersion type John Hubbard
2026-03-25 3:52 ` [PATCH v8 23/31] gpu: nova-core: Hopper/Blackwell: larger non-WPR heap John Hubbard
2026-03-25 3:52 ` [PATCH v8 24/31] gpu: nova-core: Hopper/Blackwell: add FSP Chain of Trust boot John Hubbard
2026-03-25 3:52 ` [PATCH v8 25/31] gpu: nova-core: Blackwell: use correct sysmem flush registers John Hubbard
2026-03-25 3:52 ` [PATCH v8 26/31] gpu: nova-core: make WPR heap sizing fallible John Hubbard
2026-03-25 3:52 ` [PATCH v8 27/31] gpu: nova-core: Hopper/Blackwell: larger WPR2 (GSP) heap John Hubbard
2026-03-25 3:52 ` [PATCH v8 28/31] gpu: nova-core: refactor SEC2 booter loading into BooterFirmware::run() John Hubbard
2026-03-25 3:52 ` [PATCH v8 29/31] gpu: nova-core: Hopper/Blackwell: add GSP lockdown release polling John Hubbard
2026-03-25 3:52 ` [PATCH v8 30/31] gpu: nova-core: Hopper/Blackwell: new location for PCI config mirror John Hubbard
2026-03-25 3:52 ` [PATCH v8 31/31] gpu: nova-core: Hopper/Blackwell: integrate FSP boot path into boot() John Hubbard
2026-03-25 15:08 ` [PATCH v8 00/31] gpu: nova-core: firmware: Hopper/Blackwell support Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHBZ30B3HVTR.1VYA64MM8C4JO@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=shashanks@nvidia.com \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox