From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "John Hubbard" <jhubbard@nvidia.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"Shashank Sharma" <shashanks@nvidia.com>,
"Zhi Wang" <zhiw@nvidia.com>, "David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 16/31] rust: ptr: add const_align_up()
Date: Tue, 31 Mar 2026 11:21:17 +0900 [thread overview]
Message-ID: <DHGLXL0DVBAJ.2M58T9RSK5OO7@nvidia.com> (raw)
In-Reply-To: <20260326013902.588242-17-jhubbard@nvidia.com>
On Thu Mar 26, 2026 at 10:38 AM JST, John Hubbard wrote:
> Add const_align_up() to kernel::ptr as the const-compatible equivalent
> of Alignable::align_up().
>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Suggested-by: Gary Guo <gary@garyguo.net>
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Reviewed-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> rust/kernel/ptr.rs | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/rust/kernel/ptr.rs b/rust/kernel/ptr.rs
> index bdc2d79ff669..7e99f129543b 100644
> --- a/rust/kernel/ptr.rs
> +++ b/rust/kernel/ptr.rs
> @@ -253,3 +253,27 @@ fn size(p: *const Self) -> usize {
> p.len() * size_of::<T>()
> }
> }
> +
> +/// Aligns `value` up to `align`.
> +///
> +/// This is the const-compatible equivalent of [`Alignable::align_up`].
> +///
> +/// Returns [`None`] on overflow.
> +///
> +/// # Examples
> +///
> +/// ```
> +/// use kernel::ptr::{const_align_up, Alignment};
IIUC we use the one-import-per-line style (minus the unneeded `//`) in
examples as well (I suppose this can be fixed when applying).
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
next prev parent reply other threads:[~2026-03-31 2:21 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 1:38 [PATCH v9 00/31] gpu: nova-core: firmware: Hopper/Blackwell support John Hubbard
2026-03-26 1:38 ` [PATCH v9 01/31] gpu: nova-core: Hopper/Blackwell: basic GPU identification John Hubbard
2026-03-26 1:38 ` [PATCH v9 02/31] gpu: nova-core: factor .fwsignature* selection into a new find_gsp_sigs_section() John Hubbard
2026-03-30 14:29 ` Alexandre Courbot
2026-03-30 17:51 ` John Hubbard
2026-03-26 1:38 ` [PATCH v9 03/31] gpu: nova-core: use GPU Architecture to simplify HAL selections John Hubbard
2026-03-26 1:38 ` [PATCH v9 04/31] gpu: nova-core: add Copy/Clone to Spec and Revision, add chipset() accessor John Hubbard
2026-03-26 1:38 ` [PATCH v9 05/31] gpu: nova-core: set DMA mask width based on GPU architecture John Hubbard
2026-03-30 14:32 ` Alexandre Courbot
2026-03-30 21:31 ` John Hubbard
2026-03-26 1:38 ` [PATCH v9 06/31] gpu: nova-core: Hopper/Blackwell: skip GFW boot waiting John Hubbard
2026-03-30 14:52 ` Alexandre Courbot
2026-03-30 15:20 ` Gary Guo
2026-03-30 18:33 ` Joel Fernandes
2026-03-30 19:15 ` John Hubbard
2026-03-31 0:18 ` Alexandre Courbot
2026-03-31 16:17 ` Joel Fernandes
2026-03-26 1:38 ` [PATCH v9 07/31] gpu: nova-core: move firmware image parsing code to firmware.rs John Hubbard
2026-03-26 1:38 ` [PATCH v9 08/31] gpu: nova-core: factor out an elf_str() function John Hubbard
2026-03-26 1:38 ` [PATCH v9 09/31] gpu: nova-core: don't assume 64-bit firmware images John Hubbard
2026-03-26 1:38 ` [PATCH v9 10/31] gpu: nova-core: add support for 32-bit " John Hubbard
2026-03-26 1:38 ` [PATCH v9 11/31] gpu: nova-core: add auto-detection of 32-bit, 64-bit " John Hubbard
2026-03-26 1:38 ` [PATCH v9 12/31] gpu: nova-core: Hopper/Blackwell: add FMC firmware image, in support of FSP John Hubbard
2026-03-26 1:38 ` [PATCH v9 13/31] gpu: nova-core: Hopper/Blackwell: add FSP falcon engine stub John Hubbard
2026-03-26 1:38 ` [PATCH v9 14/31] gpu: nova-core: Hopper/Blackwell: add FSP falcon EMEM operations John Hubbard
2026-03-26 1:38 ` [PATCH v9 15/31] gpu: nova-core: Hopper/Blackwell: add FSP message infrastructure John Hubbard
2026-03-26 1:38 ` [PATCH v9 16/31] rust: ptr: add const_align_up() John Hubbard
2026-03-27 9:33 ` Miguel Ojeda
2026-03-30 21:41 ` John Hubbard
2026-03-31 0:03 ` Miguel Ojeda
2026-03-31 2:23 ` Alexandre Courbot
2026-03-31 10:26 ` Miguel Ojeda
2026-03-31 2:21 ` Alexandre Courbot [this message]
2026-03-31 2:36 ` John Hubbard
2026-03-31 10:24 ` Miguel Ojeda
2026-03-31 11:53 ` Danilo Krummrich
2026-04-03 10:01 ` Miguel Ojeda
2026-04-03 10:02 ` Miguel Ojeda
2026-03-26 1:38 ` [PATCH v9 17/31] gpu: nova-core: Hopper/Blackwell: calculate reserved FB heap size John Hubbard
2026-03-26 1:38 ` [PATCH v9 18/31] gpu: nova-core: add MCTP/NVDM protocol types for firmware communication John Hubbard
2026-03-26 1:38 ` [PATCH v9 19/31] gpu: nova-core: Hopper/Blackwell: add FSP secure boot completion waiting John Hubbard
2026-03-26 1:38 ` [PATCH v9 20/31] gpu: nova-core: Hopper/Blackwell: add FMC signature extraction John Hubbard
2026-03-26 1:38 ` [PATCH v9 21/31] gpu: nova-core: Hopper/Blackwell: add FSP send/receive messaging John Hubbard
2026-03-26 1:38 ` [PATCH v9 22/31] gpu: nova-core: Hopper/Blackwell: add FspCotVersion type John Hubbard
2026-03-26 1:38 ` [PATCH v9 23/31] gpu: nova-core: Hopper/Blackwell: larger non-WPR heap John Hubbard
2026-03-26 1:38 ` [PATCH v9 24/31] gpu: nova-core: Hopper/Blackwell: add FSP Chain of Trust boot John Hubbard
2026-03-30 15:11 ` Alexandre Courbot
2026-03-30 22:54 ` John Hubbard
2026-03-26 1:38 ` [PATCH v9 25/31] gpu: nova-core: Blackwell: use correct sysmem flush registers John Hubbard
2026-03-26 1:38 ` [PATCH v9 26/31] gpu: nova-core: make WPR heap sizing fallible John Hubbard
2026-03-26 1:38 ` [PATCH v9 27/31] gpu: nova-core: Hopper/Blackwell: larger WPR2 (GSP) heap John Hubbard
2026-03-26 1:38 ` [PATCH v9 28/31] gpu: nova-core: refactor SEC2 booter loading into BooterFirmware::run() John Hubbard
2026-03-26 1:39 ` [PATCH v9 29/31] gpu: nova-core: Hopper/Blackwell: add GSP lockdown release polling John Hubbard
2026-03-26 1:39 ` [PATCH v9 30/31] gpu: nova-core: Hopper/Blackwell: new location for PCI config mirror John Hubbard
2026-03-26 1:39 ` [PATCH v9 31/31] gpu: nova-core: Hopper/Blackwell: integrate FSP boot path into boot() John Hubbard
2026-03-30 5:10 ` [PATCH v9 00/31] gpu: nova-core: firmware: Hopper/Blackwell support Alexandre Courbot
2026-03-30 22:47 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHGLXL0DVBAJ.2M58T9RSK5OO7@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=shashanks@nvidia.com \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox