From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Eliot Courtney" <ecourtney@nvidia.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Lyude Paul" <lyude@redhat.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>, <rust-for-linux@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] gpu: nova-core: bitfield: fix broken Default implementation
Date: Wed, 01 Apr 2026 13:26:37 +0900 [thread overview]
Message-ID: <DHHJ82YDW7FP.2ZFKZUQUZZ2H7@nvidia.com> (raw)
In-Reply-To: <20260401-fix-bitfield-v2-1-2fa68c98114a@nvidia.com>
On Wed Apr 1, 2026 at 10:42 AM JST, Eliot Courtney wrote:
> The current implementation does not actually set the default values for
> the fields in the bitfield.
>
> Fixes: 3fa145bef533 ("gpu: nova-core: register: generate correct `Default` implementation")
> Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
Don't forget to collect the tags you received on v1 (I use b4 which will
do it anyway so no biggie, but not everybody does).
> ---
> It doesn't actually set the default values for each field. I know that
> bitfields are being moved soon, so maybe this fix is unnecessary but I
> saw it and it's a simple fix.
Fixing it is the correct course imho - the common bitfield macro still
needs to undergo extensive review, and we might hit some hard-to-debug
issue in Nova because of this bug. I'll apply it as soon as
drm-rust-next reopens, thanks!
next prev parent reply other threads:[~2026-04-01 4:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 1:42 [PATCH v2] gpu: nova-core: bitfield: fix broken Default implementation Eliot Courtney
2026-04-01 4:26 ` Alexandre Courbot [this message]
2026-04-01 15:35 ` Gary Guo
2026-04-01 15:44 ` Danilo Krummrich
2026-04-02 1:02 ` Eliot Courtney
2026-04-03 17:37 ` Danilo Krummrich
2026-04-04 0:09 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHHJ82YDW7FP.2ZFKZUQUZZ2H7@nvidia.com \
--to=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ecourtney@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox