Re: [PATCH v2] gpu: nova-core: bitfield: fix broken Default implementation

Gary Guo
2026-04-01T15:35:21Z

On Wed Apr 1, 2026 at 5:26 AM BST, Alexandre Courbot wrote:
> On Wed Apr 1, 2026 at 10:42 AM JST, Eliot Courtney wrote:
>> The current implementation does not actually set the default values for
>> the fields in the bitfield.
>>
>> Fixes: 3fa145bef533 ("gpu: nova-core: register: generate correct `Default` implementation")
>> Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
>
> Don't forget to collect the tags you received on v1 (I use b4 which will
> do it anyway so no biggie, but not everybody does).
>
>> ---
>> It doesn't actually set the default values for each field. I know that
>> bitfields are being moved soon, so maybe this fix is unnecessary but I
>> saw it and it's a simple fix.
>
> Fixing it is the correct course imho - the common bitfield macro still
> needs to undergo extensive review, and we might hit some hard-to-debug
> issue in Nova because of this bug. I'll apply it as soon as
> drm-rust-next reopens, thanks!

This could go via drm-rust-fixes?

Best,
Gary