Re: [PATCH net-next] eth: remove the driver for acenic / tigon1&2

["Gary Guo" <gary@garyguo.net>]

On Thu Apr 2, 2026 at 7:30 PM BST, Jakub Kicinski wrote:
> The entire git history for this driver looks like tree-wide
> and automated cleanups. There's even more coming now with
> AI, so let's try to delete it instead.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: jes@trained-monkey.org
> CC: chenhuacai@kernel.org
> CC: kernel@xen0n.name
> CC: tsbogend@alpha.franken.de
> CC: James.Bottomley@HansenPartnership.com
> CC: deller@gmx.de
> CC: maddy@linux.ibm.com
> CC: mpe@ellerman.id.au
> CC: npiggin@gmail.com
> CC: chleroy@kernel.org
> CC: hca@linux.ibm.com
> CC: gor@linux.ibm.com
> CC: agordeev@linux.ibm.com
> CC: borntraeger@linux.ibm.com
> CC: svens@linux.ibm.com
> CC: bhelgaas@google.com
> CC: dakr@kernel.org
> CC: kwilczynski@kernel.org
> CC: ojeda@kernel.org
> CC: boqun@kernel.org
> CC: gary@garyguo.net
> CC: bjorn3_gh@protonmail.com
> CC: lossin@kernel.org
> CC: a.hindborg@kernel.org
> CC: aliceryhl@google.com
> CC: tmgross@umich.edu
> CC: ebiggers@google.com
> CC: ardb@kernel.org
> CC: tiwai@suse.de
> CC: tytso@mit.edu
> CC: enelsonmoore@gmail.com
> CC: martin.petersen@oracle.com
> CC: jirislaby@kernel.org
> CC: gregkh@linuxfoundation.org
> CC: geert@linux-m68k.org
> CC: herbert@gondor.apana.org.au
> CC: vineethr@linux.ibm.com
> CC: lirongqing@baidu.com
> CC: kshk@linux.ibm.com
> CC: vadim.fedorenko@linux.dev
> CC: dong100@mucse.com
> CC: wangruikang@iscas.ac.cn
> CC: hkallweit1@gmail.com
> CC: kees@kernel.org
> CC: loongarch@lists.linux.dev
> CC: linux-mips@vger.kernel.org
> CC: linux-parisc@vger.kernel.org
> CC: linuxppc-dev@lists.ozlabs.org
> CC: linux-s390@vger.kernel.org
> CC: linux-pci@vger.kernel.org
> CC: rust-for-linux@vger.kernel.org
> ---
>  MAINTAINERS                                 |    6 -
>  drivers/net/ethernet/Kconfig                |    1 -
>  drivers/net/ethernet/alteon/Kconfig         |   47 -
>  drivers/net/ethernet/Makefile               |    1 -
>  drivers/net/ethernet/alteon/Makefile        |    6 -
>  drivers/net/ethernet/alteon/acenic.h        |  791 -----
>  include/linux/pci_ids.h                     |    2 -
>  drivers/net/ethernet/alteon/acenic.c        | 3178 -------------------
>  arch/loongarch/configs/loongson32_defconfig |    1 -
>  arch/loongarch/configs/loongson64_defconfig |    1 -
>  arch/mips/configs/cavium_octeon_defconfig   |    1 -
>  arch/mips/configs/loongson2k_defconfig      |    1 -
>  arch/mips/configs/loongson3_defconfig       |    1 -
>  arch/mips/configs/malta_qemu_32r6_defconfig |    1 -
>  arch/mips/configs/maltaaprp_defconfig       |    1 -
>  arch/mips/configs/maltasmvp_defconfig       |    1 -
>  arch/mips/configs/maltasmvp_eva_defconfig   |    1 -
>  arch/mips/configs/maltaup_defconfig         |    1 -
>  arch/mips/configs/mtx1_defconfig            |    1 -
>  arch/parisc/configs/generic-32bit_defconfig |    1 -
>  arch/parisc/configs/generic-64bit_defconfig |    1 -
>  arch/powerpc/configs/44x/akebono_defconfig  |    1 -
>  arch/powerpc/configs/g5_defconfig           |    2 -
>  arch/powerpc/configs/powernv_defconfig      |    2 -
>  arch/powerpc/configs/ppc64_defconfig        |    2 -
>  arch/powerpc/configs/ppc64e_defconfig       |    2 -
>  arch/powerpc/configs/ppc6xx_defconfig       |    1 -
>  arch/powerpc/configs/skiroot_defconfig      |    2 -
>  arch/s390/configs/debug_defconfig           |    1 -
>  arch/s390/configs/defconfig                 |    1 -
>  rust/kernel/pci/id.rs                       |    1 -
>  31 files changed, 4060 deletions(-)
>  delete mode 100644 drivers/net/ethernet/alteon/Kconfig
>  delete mode 100644 drivers/net/ethernet/alteon/Makefile
>  delete mode 100644 drivers/net/ethernet/alteon/acenic.h
>  delete mode 100644 drivers/net/ethernet/alteon/acenic.c
>
> [...]
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 406abf629be2..8608361fac95 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -1809,8 +1809,6 @@
>  /* formerly Platform Tech */
>  #define PCI_DEVICE_ID_ESS_ESS0100	0x0100
>  
> -#define PCI_VENDOR_ID_ALTEON		0x12ae
> -
>  #define PCI_SUBVENDOR_ID_CONNECT_TECH			0x12c4
>  #define PCI_SUBDEVICE_ID_CONNECT_TECH_BH8_232		0x0001
>  #define PCI_SUBDEVICE_ID_CONNECT_TECH_BH4_232		0x0002
>
> [...]
>
> diff --git a/rust/kernel/pci/id.rs b/rust/kernel/pci/id.rs
> index 50005d176561..dc2035a4c175 100644
> --- a/rust/kernel/pci/id.rs
> +++ b/rust/kernel/pci/id.rs
> @@ -428,7 +428,6 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
>      TRANSMETA                = bindings::PCI_VENDOR_ID_TRANSMETA,                // 0x1279
>      ROCKWELL                 = bindings::PCI_VENDOR_ID_ROCKWELL,                 // 0x127A
>      ITE                      = bindings::PCI_VENDOR_ID_ITE,                      // 0x1283
> -    ALTEON                   = bindings::PCI_VENDOR_ID_ALTEON,                   // 0x12ae
>      NVIDIA_SGS               = bindings::PCI_VENDOR_ID_NVIDIA_SGS,               // 0x12d2
>      PERICOM                  = bindings::PCI_VENDOR_ID_PERICOM,                  // 0x12D8
>      AUREAL                   = bindings::PCI_VENDOR_ID_AUREAL,                   // 0x12eb

Does the PCI ID needs to be removed? There was a similar change that I recalled
and the discussion eventually leads to ID not being removed.
https://lore.kernel.org/all/20260123033233.16906-1-enelsonmoore@gmail.com/

That said, if the decision is to remove the IDs, then the Rust change is okay to
me

Acked-by: Gary Guo <gary@garyguo.net> # Rust

Best,
Gary