From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alexandre Courbot" <acourbot@nvidia.com>
Cc: "John Hubbard" <jhubbard@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"Shashank Sharma" <shashanks@nvidia.com>,
"Zhi Wang" <zhiw@nvidia.com>, "David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] gpu: nova-core: fb: fix clippy::precedence warning in read_sysmem_flush_page_ga100()
Date: Sun, 05 Apr 2026 14:32:27 +0200 [thread overview]
Message-ID: <DHL828PQQVVP.3H1SIQV8XK43B@kernel.org> (raw)
In-Reply-To: <DHL6ZYVYIHI3.2SXJQ5VWKIU5T@nvidia.com>
On Sun Apr 5, 2026 at 1:42 PM CEST, Alexandre Courbot wrote:
> On Sun Apr 5, 2026 at 6:35 AM JST, John Hubbard wrote:
>> On 4/4/26 2:28 PM, John Hubbard wrote:
>>> Clippy warns when shifts and bitwise-OR are mixed without parentheses,
>>> because the relative precedence of << and | is easy to misread.
>>>
>>> Add explicit parentheses to silence the warning.
>>
>> Please disregard (drop) this patch 2/3, because Miguel is removing
>> the associated lint, so we won't need it.
>
> I'm tempted to consider it anyway, because it is a readability
> improvement. Any objection?
I'd rather not. If we have the lint disabled - and I think having it enabled is
a bit too much - then I don't want to set a precedence for unnecessary churn
like adding or removing unnecessary braces.
- Danilo
next prev parent reply other threads:[~2026-04-05 12:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 21:28 [PATCH v2 0/3] Fix all clippy warnings in drm-rust-next John Hubbard
2026-04-04 21:28 ` [PATCH v2 1/3] gpu: nova-core: vbios: use from_le_bytes() for PCI ROM header parsing John Hubbard
2026-04-04 21:28 ` [PATCH v2 2/3] gpu: nova-core: fb: fix clippy::precedence warning in read_sysmem_flush_page_ga100() John Hubbard
2026-04-04 21:35 ` John Hubbard
2026-04-05 11:42 ` Alexandre Courbot
2026-04-05 12:13 ` Miguel Ojeda
2026-04-05 12:32 ` Danilo Krummrich [this message]
2026-04-06 0:38 ` Alexandre Courbot
2026-04-04 21:28 ` [PATCH v2 3/3] rust: ptr: allow clippy::incompatible_msrv for slice_ptr_len John Hubbard
2026-04-04 21:46 ` Miguel Ojeda
2026-04-04 21:49 ` John Hubbard
2026-04-05 23:22 ` Miguel Ojeda
2026-04-06 5:43 ` John Hubbard
2026-04-04 22:09 ` Gary Guo
2026-04-05 23:22 ` Miguel Ojeda
2026-04-05 15:16 ` [PATCH v2 0/3] Fix all clippy warnings in drm-rust-next Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHL828PQQVVP.3H1SIQV8XK43B@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=shashanks@nvidia.com \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox