public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: "Eliot Courtney" <ecourtney@nvidia.com>
To: "Danilo Krummrich" <dakr@kernel.org>,
	"Eliot Courtney" <ecourtney@nvidia.com>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>, <rust-for-linux@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] gpu: nova: require little endian
Date: Wed, 08 Apr 2026 15:47:51 +0900	[thread overview]
Message-ID: <DHNKM16OK896.3I9B3CRMZGRL8@nvidia.com> (raw)
In-Reply-To: <DHMZN9TEXQT5.3FIWZRAQKUO9T@kernel.org>

On Tue Apr 7, 2026 at 11:22 PM JST, Danilo Krummrich wrote:
> On Tue Apr 7, 2026 at 5:59 AM CEST, Eliot Courtney wrote:
>> The driver already assumes little endian in a lot of locations. For
>> example, all the code that reads RPCs out of the command queue just
>> directly interprets the bytes.
>>
>> Make this explicit in Kconfig.
>>
>> Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
>> ---
>> The current code assumes little endian in a bunch of places. I think we
>> should either explicitly decide to be generic on endianness or explicitly
>> decide not to - having some handling sprinkled around in various
>> locations seems confusing to me.
>>
>> I believe that currently e.g. `RUST` transitively depends on
>> !CPU_BIG_ENDIAN, so this is more about making the decision explicit for
>> nova-core rather than fixing any kind of hole.
>> ---
>> Changes in v2:
>> - Also add to nova-drm (Thanks Danilo)
>> - Did not take Reviewed-by + Acked-by because commit changed
>>   substantively
>> - Link to v1: https://patch.msgid.link/20260406-fix-kconfig-v1-1-8f634499f7f0@nvidia.com
>
> Thanks for the new version -- I have one additional question in [1]. Otherwise,
> going to pick up once -rc1 is out.
>
> [1] https://lore.kernel.org/all/DHMVA3S2MZWV.1JN7WUBZLRWLV@kernel.org/

Thanks. I think others have answered the question (Thanks Timur and Joel)
so hopefully all good.

  reply	other threads:[~2026-04-08  6:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  3:59 [PATCH v2] gpu: nova: require little endian Eliot Courtney
2026-04-07  5:09 ` John Hubbard
2026-04-07 11:57 ` Gary Guo
2026-04-07 14:11 ` Joel Fernandes
2026-04-07 14:22 ` Danilo Krummrich
2026-04-08  6:47   ` Eliot Courtney [this message]
2026-04-08  7:12 ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHNKM16OK896.3I9B3CRMZGRL8@nvidia.com \
    --to=ecourtney@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox