From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011039.outbound.protection.outlook.com [40.93.194.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 276C43A5E82; Fri, 10 Apr 2026 07:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.39 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775807715; cv=fail; b=BqB2abCS2JF3d8a8k9ve9Tm5wGuHcUmoIDHN8L6+3mH3v4HNiEKhCwOyNVcr9MkzwrMdx7ECaNl3gux5e0AXpop/vTRWRy/3/vYBKceMJkeU4TyuA4vzoE6rALNVRq47Bg6cOhULCZ89cFYjir0RF7Jo5RoR+UUx17/Wfbl6CVI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775807715; c=relaxed/simple; bh=KKwGgGN9qutxUNNra13tbc1+JqO5bl4qpCgFyBbKo7w=; h=Content-Type:Date:Message-Id:Cc:Subject:From:To:References: In-Reply-To:MIME-Version; b=rEkjad7h75bsXHWuAvyzyvB85MsSNj/5ategEhUnEx2N5RXhxIgpkWQFVHqfGNWrv5fMNzm3YcZ2DX+EUXCq3q72m/l5nP7mPxIMisCvNkTx5LGggEJKfiz4Mx9sXLK5aLELCJ0cEk6XJUGqrpebCZIQYPwfzDso46vLKc3Ck4w= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=NrfttNV9; arc=fail smtp.client-ip=40.93.194.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="NrfttNV9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qAPZE2lrgKiQug8u6u64THoMJ6CK+EhjMbLhNf0h4oY//E39CNgRCdVfCcduliI9Wkeg+V5dDhWm+mdiXufRISRqYxcQMbj66PRgBaMsJgtqhOSt4O6xXjJLKGtjs50xb4ypg/qQhG7r803dbSrvjdFJIW/wM8FDX3xzYzkh8nobx/jgWWaS0CLc81TqdQb+R3DIoIwl+Wo3fp2m7mlpGXLyLR0E/L+ONc1sVE8DKcW3FssycXWJw8DJwGiQ/Hv7U8VtBvWNCrHZQqc6oCbwFCxNevFzZaLMwrgfCOsbCT7Igi01D+Kpv2Sa0pmXVcuIGDNYsk07dIcsHrQFAaV0bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T+tRLy47TPGBNhcYYlRDu8gYBXmi+6VZHjytvWYzG9Q=; b=IwUP1kWTjcao8WXic2z+nPr4I7V6K8WEbV0LddkM1D/IcYicHywsdz2ERKdplBsLGUoXM2DDfNe2lP3yJQCAAYfZYWabI6FdqLXULQNK52YwUF67p657VmPiu/HybstiKnMBPtGxHa14yQEprmRzvLeAmJ1VoGN6UpFjBiGuW+19jm51xikTWXjbsWBf6cUuvBtvhqLR4PDdJNinknPK0FmJHSTWytkPwttEE0SADQch0iRr/oIpOik/Ax1uSPoatxGMhpVtYJ62d10Weto3Yq7YfOA89VIb0r3kNdOcouJRppyHK9dPwkp+aMVVVW+7dLFJDsbjSMIbjrsEK8fV2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T+tRLy47TPGBNhcYYlRDu8gYBXmi+6VZHjytvWYzG9Q=; b=NrfttNV96jjJabNfj8hIU9kl5x4zZmprgj5szmhzxCfd6jllrzNlvgEEKnfO9uRDqeAejduycPL6H82P8imb0WYAKzwUsDxoVUuA1oTHMD9/hUHSl0AYCPXWRztxLU0UHrHzxT7J06zrN9fkjpK1q3eJDyhKYgoNy6guWsQeFo1O/SO9an6YvSJ8ahugAZdKdBe+SJT7BkOrCXdBBW7jH8ZGcpHDoAysCtaZNjlz9iPmlahpqv0yRrQ2EqpifqIIfT0QjDx4iKZMEwaLHWyRtp8jK48MiR7q+SbcvPJHo+p9Qrr+fTOtoIWszYFnRFJGVrUa29yDdNijkQFYTnXdXg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by PH7PR12MB8156.namprd12.prod.outlook.com (2603:10b6:510:2b5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9791.34; Fri, 10 Apr 2026 07:55:10 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%4]) with mapi id 15.20.9769.041; Fri, 10 Apr 2026 07:55:10 +0000 Content-Type: text/plain; charset=UTF-8 Date: Fri, 10 Apr 2026 16:55:05 +0900 Message-Id: Cc: , "Gary Guo" , "Daniel Almeida" , , "Danilo Krummrich" , , "Matthew Maurer" , "FUJITA Tomonori" , "Lorenzo Stoakes" , , "Asahi Lina" , "Miguel Ojeda" , "Andreas Hindborg" , "Simona Vetter" , "Alice Ryhl" , "Boqun Feng" , "Sumit Semwal" , "Krishna Ketan Rai" , , "Shankari Anand" , "David Airlie" , "Benno Lossin" , "Viresh Kumar" , , "Asahi Lina" , "Greg Kroah-Hartman" , Subject: Re: [PATCH v10 3/5] drm/gem/shmem: Export drm_gem_shmem_get_pages_sgt_locked() From: "Alexandre Courbot" To: "Lyude Paul" Content-Transfer-Encoding: quoted-printable References: <20260409001559.622026-1-lyude@redhat.com> <20260409001559.622026-4-lyude@redhat.com> In-Reply-To: <20260409001559.622026-4-lyude@redhat.com> X-ClientProxiedBy: TY4P286CA0125.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:37c::15) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|PH7PR12MB8156:EE_ X-MS-Office365-Filtering-Correlation-Id: cac5277c-bd91-46d9-c3c8-08de96d67c9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|10070799003|366016|1800799024|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: QR2havHlOfqJ1KkYWn5Jj2Dc0mj0/qIkeu1Pt7SXDtrNExrDMUlsquQGUwzype5J6BaTk7ZGhwREsQ3mI/xV9hyjwLMRqL1bsYEN1l9Kg2lNiny9mPPXL3Cff8Wsv9/5rRWNyCN6SAqlgp3sGmel5ww0CBfmR0RDkp8oXXd/JzWpJ+qsMSbWr89YYAXB30lTSBjo6FBVDCqcKmzg+bCelJYJ/2hE6DJbvIXD0/zTz3lbjR2ocPiMnE3M8/2DgVQ+VKFjPWHOlu0YrsA6uE4jITQCw+UpQXSH3xu6PpU5wXulDNJ0++l+O8/pseWxz9592NBqsNJUXw35tcmgl20OB5kkMMqBTSoQ5shd/b5eQosm+zvluMTruwhIVncEB74gIoOJQ3gTB88I9lIAwWFFkwTu0Flt4x+gPGr3N9teqlbuwFweozLYnsmgtL1B45+0MfR/P8S7vHWz+FZ1x/6a4/Hfsci18y1PkMsPmcuzo3Wb4+MWeMQHM4y6HyfTHi+YloOjUayi6tu7znCqdcbINIFYm8Kc+mjFA6Fo4Qpy/Nb2KBrwIPK4GgtiMjgojW/Xj1v2M1P1QuScg1aJPHTBQd9t1GfLpC/lWYCpBzmHrH4iO5yCci1BIszio2Lj5UXpmkMEU9eljgkpD0YN5Dlsr9/Y8p4CAlPhgB1CW3AWe67PXBLypzH1UUVkJgfMBwzCklCdAIGb+ra9FBM+sUP0udUhS+4lLLMemcO98eZRlPY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(10070799003)(366016)(1800799024)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dk5PQzRPZDFhQ0JJZE9uTzZXN2Vjdnh2M3hicWUxWVJhZ1BuT05PaVo2SlJr?= =?utf-8?B?OUlBL0Z0QmJ6ZnR1Q09SUllRc0ZPc1U3Qy9PRXZhVDNjbzdRRFRxc3hxM1ZL?= =?utf-8?B?dllVRmNsNHdNRkxGT24zVVEyUmVuQUxTTVNsQmNOVzJIMUZrK0s4dHgvTVZi?= =?utf-8?B?NEFJMVRESGdTa1Y2Z0MrQWxGNEhpUHJjelhVQ2twQkxlTWdlb3BxZjQrN2Fm?= =?utf-8?B?TzdmV1FERzQwR2Z5TURWT3pzbjIxZHM4NHV2T3ExZWZaZm4vZGh3SU80Tk5p?= =?utf-8?B?MW1KYUlQUm9ZWmU2RFJZcjVWTVcxSWM1V2NYMnJ4RE14cUVvYVdJMkFCbnV5?= =?utf-8?B?eEFOWGZodzhtNE5VaHBoMlFTU1MwZ3dMd2hHSUlRUThUWGl4VzVZT0EraGp2?= =?utf-8?B?dXFyc2M4UW9zNFhxTjM5b08zL2tEYUpCdXlULzlscWM4RStnYkRZWTlXZ2s5?= =?utf-8?B?OHZkbEd3bE5GVzY1eFM5WjhDWkRnaGVwdXZYcXJObGxnU2VZVmVuTExGVGty?= =?utf-8?B?SXNVdFMyMnBnc3NsY3J0aEYxMlZkMTl4Q2ZsbWxOOUZxWDlwMG5lcUo1TFdo?= =?utf-8?B?dnR5TkUxUUR6Q1A4ci8rcWFYTU1kM3oxdHJIWU1GZjhuUlVLbkNUY3N2QUQy?= =?utf-8?B?NmJWbTZOZTRjQVNHNEVHUmxBVUNtc1UzdUNRQjZZdVFCUHo1aklTTGpORUpa?= =?utf-8?B?aWJPM0N5VGx1THJ0SEgzMDJUQU1HdndTNlpjUG1mQllqd3lNN3NEWlhFRzNT?= =?utf-8?B?SmhoN2xoRHIyeVZLSEN5Y1ZRZ3NnODhqQ1A2cnVrVi9ldzlOeHhScFFsY25Q?= =?utf-8?B?QUNMSmJhUWFnWFQ1M1JENld3UUJYSG55NzNiYzFhRlh2NmQ2a3JmcGg3bUtI?= =?utf-8?B?S3g1UFNOZ3ZMWWVUNVJtK0szRWNFVEkxTWM0SHdDdnlsaitCYmptYmw2Mzl0?= =?utf-8?B?cDJ1eHNKM1p6RjBZM2NFTXRPYjh6R3I1MUFLSURxTWtOd2xrV2ZKeVYvQUgx?= =?utf-8?B?QjVVUXFCQlMvVlNqYTJXRVhldCtBSVpoRmlVWUdMSlI4ajdKdFVIZzdVRkph?= =?utf-8?B?cnFIa1pOZzQ5eXRNYk02UVJhTGViYkoyeWtpNWNYY1gvdHBOd2ZzaFpCUEtx?= =?utf-8?B?Q1RqZFBkV2ZMdFNid2Rmd0JDVmR2WExJU2VZckZhbm1JUmRITExCN01DS3J2?= =?utf-8?B?dk5UZmxMWkFjb0dHOCtDNXl1OGNrMUVjOUY2a1VPRTZnWUk1NGZWdVoxNjRv?= =?utf-8?B?NUVBSjhaNG9XMFZjUmRPc0lHRnFnWlhBMVBkU0NycTM5Y090S0NoUzB5ZWtv?= =?utf-8?B?RzZLWG80VVovV0toOWcvcCtIY2M3WTFBOHpOM0EyMHh5TC93UGJRTFphY1RN?= =?utf-8?B?ZUxlTE5KT2lqODN6QnlEV0M4a1NkZjlIUkJ0SzJtbjNObjhhZ1lNQlB2cnJU?= =?utf-8?B?dUhIem5NWGtRZnhlcElPd1BEVlA4cWZOajZzMWU0dVd3NThIZDFZdWcwd1RD?= =?utf-8?B?YUxoRXNnY0RhM0NrQ2EyR3cySUh0c2VZMU1yZUxIMjV3WCtwcnN1M1NpeW93?= =?utf-8?B?V2VwaFNUWVdYS01RQnBGb2IvTysxQ0tKOWdwZFdZSEdubWZPUWVIbU04TitT?= =?utf-8?B?MjhDUXhiVERxKzFvODgxaXR0ZGFSTWdiZ0dYUUhYUWhRMjhzanFsVE9xKzBG?= =?utf-8?B?UGFtd0t1SE40WU5uZWpHVTZhWjRGNDVpMExaMGZEZmd1Ump2SjhtMkNRNDRF?= =?utf-8?B?N2x3cmVmYWNGUnpsUGJXWXYrYXFBKzg2K010bnVHRERJTkEybTM2U09uUm1n?= =?utf-8?B?RUJhRjk4UkZuQ1ZneE1uS3lwNWl2TGFndmNSS2ZTbW1wTExkUmpBamdVN0JV?= =?utf-8?B?M2VjRHBaeXJXQVVKbnYxMDRWcmdTcVhHRWNZN1ExM3A1d0ROemxqbVFiL2ts?= =?utf-8?B?VjlQOXlDVzBiMFhDOUFVdTRBaTRTN0pSbUZWczlsbGI1WmlKUDlLYVllMVBU?= =?utf-8?B?K1RSTWRsZTRTeml2cnNOaTdaUnVuMTVpbjI0Qnh4b1VWdUM2a0NkS1JBRHZK?= =?utf-8?B?ZHhyNVYrRkxPcHdZaUJmdHh4SHdVR2RraEY0elZ4MW84NURwY2R5d1FFNlc2?= =?utf-8?B?Q01LWk91bXBSdjJHUHlibUdkSnM4MWdaOXMvR2FmSFdsNXdhaFFaQ29jYUhv?= =?utf-8?B?MHlvVmVIZ2dFdnNZdnJPWmVwb0FSZk9RS09RSVB3NnQ4cXMrSkt1Y3NTWUlN?= =?utf-8?B?UnMrbWh1cXlVUVQxR2FCcDdscEwrRFpINk51dTlxUGtLSFh5U1pDekdBUG1R?= =?utf-8?B?bEhTR2sxOEVrMWRLbXZtV1VVcUZ4ZjEvZVUwZng3Q1hEeDlybFV2enVweEtG?= =?utf-8?Q?MG1DzF76vj4RzS8qrm2O+wqwnph+plKuotgDbJzU2FOSr?= X-MS-Exchange-AntiSpam-MessageData-1: IHL4wvmaC2qQMA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: cac5277c-bd91-46d9-c3c8-08de96d67c9b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2026 07:55:10.6395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aett+p+DS/36s4jp4nl6bMUCuv9QBCI8FKlqcHvLgcMWh2m+LsHj/AEDS9/YmK5Un9pJ3I6/9kj/XUyxCyXbTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8156 On Thu Apr 9, 2026 at 9:12 AM JST, Lyude Paul wrote: > We will need this for implementing a set of SGTable bindings in Rust for > gem shmem objects, so that we can use the dma_resv lock to protect > additional resources in the shmem object. > > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/drm_gem_shmem_helper.c | 16 +++++++++++++++- > include/drm/drm_gem_shmem_helper.h | 1 + > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm= _gem_shmem_helper.c > index addf8c1e5341e..15de7f6cc4981 100644 > --- a/drivers/gpu/drm/drm_gem_shmem_helper.c > +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c > @@ -786,12 +786,25 @@ struct sg_table *drm_gem_shmem_get_sg_table(struct = drm_gem_shmem_object *shmem) > } > EXPORT_SYMBOL_GPL(drm_gem_shmem_get_sg_table); > =20 > -static struct sg_table *drm_gem_shmem_get_pages_sgt_locked(struct drm_ge= m_shmem_object *shmem) > +/** > + * drm_gem_shmem_get_sg_table - Under dma_resv lock, provide a scatter/g= ather table of The function name looks incorrect. > + * pinned pages for an shmem GEM object. > + * @shmem: shmem GEM object > + * > + * This function is the same as drm_gem_shmem_get_pages_sgt, except that= the caller is expected to > + * already hold the dma_resv lock for @shmem. > + * > + * Returns: > + * A poitner to the scatter/gather table of pinned pages, or error point= er on failure. nit: s/poitner/pointer. Otherwise, Reviewed-by: Alexandre Courbot