public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Hsiu Che Yu" <yu.whisper.personal@gmail.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
	"Lorenzo Stoakes" <ljs@kernel.org>,
	"Vlastimil Babka" <vbabka@kernel.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"Uladzislau Rezki" <urezki@gmail.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: alloc: add doc test for `Vec::from_elem`
Date: Sun, 26 Apr 2026 22:11:01 +0900	[thread overview]
Message-ID: <DI3417MXPI5F.1DMTUFZULXTUF@nvidia.com> (raw)
In-Reply-To: <69ed9422.a70a0220.2a0a5f.f624@mx.google.com>

On Sun Apr 26, 2026 at 1:27 PM JST, Hsiu Che Yu wrote:
> On Sun, Apr 26, 2026 at 01:05:36PM +0900, Alexandre Courbot wrote:
>>Received just as I had finished testing your other series. :) So while
>>I'm at it:
>
> On Sun, Apr 26, 2026 at 01:00:06PM +0900, Alexandre Courbot wrote:
>>Looking good - just one thing, when sending a new revision of a
>>patchset, please start a new thread instead of replying to the previous
>>one. Otherwise things can get pretty hard to follow once we arrive at,
>>say, v10. :)
>
> I just realized — should I have grouped the tests targeting the same 
> module into a single patch series (like the one that was split into
> two recently)?
> Would that make the review process easier? If so, I'll start batching
> small doc-test patches together before sending.

I don't think there is any hard rule, but usually a patch series implies
a dependency between the patches, i.e. patch 2 cannot build without
patch 1. For what you sent so far this is not the case, so separate
patches is fine and maybe even preferable as they can be applied
individually whereas maintainers tend to consider series as "all or
nothing" (there are exceptions of course).

>
> Also, as you pointed out in your other reply, 
> I had confused `link:` and `in-reply-to`. 
> I'll make sure to use `link:` to reference context for v2 onwards.

No worries. If I may recommend b4 [1] for managing your patch series, it
ususally just does the right thing for you.

[1] https://b4.docs.kernel.org/en/latest/

      reply	other threads:[~2026-04-26 13:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26  3:46 [PATCH] rust: alloc: add doc test for `Vec::from_elem` Hsiu Che Yu
2026-04-26  4:05 ` Alexandre Courbot
2026-04-26  4:27   ` Hsiu Che Yu
2026-04-26 13:11     ` Alexandre Courbot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DI3417MXPI5F.1DMTUFZULXTUF@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=urezki@gmail.com \
    --cc=vbabka@kernel.org \
    --cc=yu.whisper.personal@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox