From: "Gary Guo" <gary@garyguo.net>
To: "Danilo Krummrich" <dakr@kernel.org>, <aliceryhl@google.com>,
<daniel.almeida@collabora.com>, <boris.brezillon@collabora.com>,
<deborah.brouwer@collabora.com>, <gary@garyguo.net>
Cc: <dri-devel@lists.freedesktop.org>, <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH 1/2] gpu: drm: tyr: separate driver type from driver data
Date: Thu, 28 May 2026 13:56:06 +0100 [thread overview]
Message-ID: <DIUBR87B0MIL.1DQDI5WUOBM0P@garyguo.net> (raw)
In-Reply-To: <20260525230152.277820-2-dakr@kernel.org>
On Tue May 26, 2026 at 12:01 AM BST, Danilo Krummrich wrote:
> Introduce TyrPlatformDriver as a unit struct for the platform::Driver
> trait implementation and keep TyrPlatformDriverData for the private
> driver data.
>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Reviewed-by: Gary Guo <gary@garyguo.net>
> ---
> drivers/gpu/drm/tyr/driver.rs | 10 ++++++----
> drivers/gpu/drm/tyr/tyr.rs | 4 ++--
> 2 files changed, 8 insertions(+), 6 deletions(-)
next prev parent reply other threads:[~2026-05-28 12:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 23:01 [PATCH 0/2] drm: tyr: use lifetime-bound IoMem Danilo Krummrich
2026-05-25 23:01 ` [PATCH 1/2] gpu: drm: tyr: separate driver type from driver data Danilo Krummrich
2026-05-26 1:17 ` Eliot Courtney
2026-05-26 6:43 ` Boris Brezillon
2026-05-27 22:56 ` Deborah Brouwer
2026-05-28 12:56 ` Gary Guo [this message]
2026-05-25 23:01 ` [PATCH 2/2] gpu: drm: tyr: use IoMem directly instead of Devres Danilo Krummrich
2026-05-26 1:30 ` Alexandre Courbot
2026-05-26 2:43 ` Eliot Courtney
2026-05-27 23:03 ` Deborah Brouwer
2026-05-27 23:31 ` Danilo Krummrich
2026-05-28 12:58 ` Gary Guo
2026-05-28 21:51 ` Deborah Brouwer
2026-05-27 22:56 ` Deborah Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIUBR87B0MIL.1DQDI5WUOBM0P@garyguo.net \
--to=gary@garyguo.net \
--cc=aliceryhl@google.com \
--cc=boris.brezillon@collabora.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=deborah.brouwer@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox