Rust for Linux List
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] rust: device: avoid trailing ; in printing macros
Date: Thu, 16 Jul 2026 20:45:52 +0200	[thread overview]
Message-ID: <DK07VQ14YCY4.13KSVBNXSSA5J@kernel.org> (raw)
In-Reply-To: <CANiq72=OKHJo0Shzb_h1OuzmTVLqn6qPJsA_AhJAWOfQATbYDQ@mail.gmail.com>

On Thu Jul 16, 2026 at 4:28 PM CEST, Miguel Ojeda wrote:
> Thanks, no worries, I will take it -- this kind of fix makes more
> sense in `rust-fixes` since they are treewide, i.e. it could have
> triggered in more places at the same time since they changer the
> compiler, and I have other few in the branch accumulated for Rust
> 1.99.0.
>
> (An Acked-by is always nice of course!)

I don't understand the rationale about being treewide. This patch only touches
rust/kernel/device.rs.

(Even if there would have been other subsystems running into the same condition,
it would have produced independent patches, which could be - but don't have to
be - sent in a treewide series.)

I'm obviously fine with the patch and I also don't mind if you take it if you
prefer to, thus:

	Acked-by: Danilo Krummrich <dakr@kernel.org>

But, if I may be honest, the way this is presented feels as if the driver-core
maintainers never had a say in the logistics in the first place, which doesn't
feel right.

Also what makes this patch urgent in a way that waiting for an ACK to be given
before applying wasn't an option?

  reply	other threads:[~2026-07-16 18:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 10:22 [PATCH] rust: device: avoid trailing ; in printing macros Alice Ryhl
2026-07-16 12:17 ` Miguel Ojeda
2026-07-16 13:48   ` Danilo Krummrich
2026-07-16 14:28     ` Miguel Ojeda
2026-07-16 18:45       ` Danilo Krummrich [this message]
2026-07-16 14:00 ` Gary Guo
2026-07-16 14:28   ` Miguel Ojeda
2026-07-16 16:32 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DK07VQ14YCY4.13KSVBNXSSA5J@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=driver-core@lists.linux.dev \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox