From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: <gregkh@linuxfoundation.org>, <arve@android.com>,
<tkjos@android.com>, <brauner@kernel.org>, <cmllamas@google.com>,
<aliceryhl@google.com>, <boqun@kernel.org>, <lyude@redhat.com>,
<daniel.almeida@collabora.com>, <work@onurozkan.dev>,
<juri.lelli@redhat.com>, <vincent.guittot@linaro.org>,
<dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
<bsegall@google.com>, <mgorman@suse.de>, <vschneid@redhat.com>,
<kprateek.nayak@amd.com>, <ojeda@kernel.org>,
<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
<a.hindborg@kernel.org>, <tmgross@umich.edu>, <tamird@kernel.org>,
<acourbot@nvidia.com>, <peterz@infradead.org>, <mingo@redhat.com>,
<will@kernel.org>, <longman@redhat.com>,
<viro@zeniv.linux.org.uk>, <jack@suse.cz>, <tj@kernel.org>,
<jiangshanlai@gmail.com>, <linux-kernel@vger.kernel.org>,
<rust-for-linux@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 3/5] rust: sync: add WaitQueue infrastructure
Date: Mon, 27 Jul 2026 14:46:32 +0200 [thread overview]
Message-ID: <DK9D4LAND3I8.1CXI8473PG88M@kernel.org> (raw)
In-Reply-To: <DK9C6KISAMX3.H10297T645RT@garyguo.net>
On Mon Jul 27, 2026 at 2:02 PM CEST, Gary Guo wrote:
>> @@ -0,0 +1,388 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +
>> +//! Wait queue.
>> +//!
>> +//! C header: [`include/linux/wait.h`](srctree/include/linux/wait.h)
>> +
>> +use super::LockClassKey;
>> +use crate::{
>> + prelude::*,
>> + str::CStr,
>> + task::{
>> + self,
>> + TASK_INTERRUPTIBLE,
>> + TASK_NORMAL,
>> + TASK_UNINTERRUPTIBLE, //
>
> Hmm, I am not sure why we are exposing these as constants from kernel::task.
> Regardless, Given that you're using them for bindings, you should probably get
> them from bindings::TASK_* instead.
See commit f090f0d0eea9 ("rust: sync: update integer types in CondVar");
personally I don't mind either way.
next prev parent reply other threads:[~2026-07-27 12:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 22:36 [PATCH 0/5] rust: sync: add WaitQueue infrastructure Danilo Krummrich
2026-07-26 22:36 ` [PATCH 1/5] rust: task: add safe schedule_timeout() wrapper Danilo Krummrich
2026-07-26 22:36 ` [PATCH 2/5] rust: workqueue: replace deprecated system_wq with system_{percpu,dfl}_wq Danilo Krummrich
2026-07-27 11:53 ` Gary Guo
2026-07-26 22:36 ` [PATCH 3/5] rust: sync: add WaitQueue infrastructure Danilo Krummrich
2026-07-27 12:02 ` Gary Guo
2026-07-27 12:46 ` Danilo Krummrich [this message]
2026-07-27 13:21 ` Gary Guo
2026-07-26 22:36 ` [PATCH 4/5] rust: sync: convert CondVar and PollCondVar to use WaitQueue Danilo Krummrich
2026-07-26 22:36 ` [PATCH 5/5] rust: sync: condvar: use task::schedule_timeout() Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK9D4LAND3I8.1CXI8473PG88M@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=cmllamas@google.com \
--cc=daniel.almeida@collabora.com \
--cc=dietmar.eggemann@arm.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jiangshanlai@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tj@kernel.org \
--cc=tkjos@android.com \
--cc=tmgross@umich.edu \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox