From: "Gary Guo" <gary@garyguo.net>
To: "Andreas Hindborg" <a.hindborg@kernel.org>,
"FUJITA Tomonori" <tomo@flapping.org>, <gary@garyguo.net>
Cc: <aliceryhl@google.com>, <arve@android.com>, <boqun@kernel.org>,
<brauner@kernel.org>, <cmllamas@google.com>,
<gregkh@linuxfoundation.org>, <ojeda@kernel.org>,
<tkjos@android.com>, <acourbot@nvidia.com>,
<anna-maria@linutronix.de>, <bjorn3_gh@protonmail.com>,
<dakr@kernel.org>, <daniel.almeida@collabora.com>,
<frederic@kernel.org>, <jstultz@google.com>, <lossin@kernel.org>,
<lyude@redhat.com>, <sboyd@kernel.org>, <tamird@kernel.org>,
<tglx@kernel.org>, <tmgross@umich.edu>, <work@onurozkan.dev>,
<rust-for-linux@vger.kernel.org>, <fujita.tomonori@gmail.com>
Subject: Re: [PATCH v4 0/7] rust: use Delta instead of raw jiffies for timeouts and delays
Date: Wed, 05 Aug 2026 15:15:18 +0100 [thread overview]
Message-ID: <DKH2NGL7W29L.2K5MVFFHP84JX@garyguo.net> (raw)
In-Reply-To: <87v79o7myg.fsf@t14s.mail-host-address-is-not-set>
On Wed Aug 5, 2026 at 1:48 PM BST, Andreas Hindborg wrote:
> "FUJITA Tomonori" <tomo@flapping.org> writes:
>
>> On Thu, 30 Jul 2026 14:09:59 +0100
>> "Gary Guo" <gary@garyguo.net> wrote:
>>
>>> On Wed Jul 22, 2026 at 10:49 PM BST, FUJITA Tomonori wrote:
>>>> From: FUJITA Tomonori <fujita.tomonori@gmail.com>
>>>>
>>>> CondVar::wait_interruptible_timeout() and Queue::enqueue_delayed() use
>>>> a raw jiffies count (a plain c_ulong alias with no type
>>>> safety). Callers have to know on their own that the value meant
>>>> jiffies and convert to/from it themselves, which is easy to get wrong
>>>> (e.g. passing a millisecond value where a jiffies value is expected).
>>>>
>>>> Both APIs just take a span of time so, they can use the Delta type
>>>> instead.
>>>>
>>>> This series makes Delta generic over its time unit with Nsec and Jiffy
>>>> types, switches CondVar and Queue to use Delta instead of raw jiffies
>>>> (updating binder's ioctl_freeze(), the only caller of
>>>> wait_interruptible_timeout()), and then removes the now-unused Jiffies
>>>> and Msecs type aliases.
>>>
>>> There are more jiffy users being added so we should take this sooner than later:
>>> https://lore.kernel.org/rust-for-linux/20260726223613.1242940-1-dakr@kernel.org/#t
>>>
>>> Andreas, any plan on taking this via timekeeping-next? I suppose Boqun
>>> could also be taken via rust-sync tree if you give an ack?
>>
>> Agreed. Getting this into the next merge window would be great.
>
> I was on vacation, back now.
>
> Getting this in the merge window for v7.3 is probably a little tight. We
> should aim for v7.4.
>
> I will take closer look this week.
Ideally we can still take them this cycle so we can add users in the next one.
I suppose otherwise we might want a topic branch early next cycle.
I think if you can pick timekeeping patches today or tomorrow then they'll still
have a round or two in linux-next before rc7. Or perhaps Miguel can pick these
instead?
Best,
Gary
next prev parent reply other threads:[~2026-08-05 14:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 21:49 [PATCH v4 0/7] rust: use Delta instead of raw jiffies for timeouts and delays FUJITA Tomonori
2026-07-22 21:49 ` [PATCH v4 1/7] rust: time: make Delta generic over its time unit FUJITA Tomonori
2026-07-22 21:49 ` [PATCH v4 2/7] rust: time: add jiffies time unit for Delta FUJITA Tomonori
2026-07-22 21:49 ` [PATCH v4 3/7] rust: time: add Delta::as_millis_ceil() FUJITA Tomonori
2026-08-05 12:47 ` Andreas Hindborg
2026-08-06 7:41 ` FUJITA Tomonori
2026-07-22 21:49 ` [PATCH v4 4/7] rust: time: add Delta::to_jiffies() for timeout conversion FUJITA Tomonori
2026-07-22 21:49 ` [PATCH v4 5/7] rust: workqueue: take a Delta<Jiffy> for the enqueue delay FUJITA Tomonori
2026-07-22 21:49 ` [PATCH v4 6/7] rust: sync: condvar: use Delta<Jiffy> for timeout and result FUJITA Tomonori
2026-07-23 13:42 ` Gary Guo
2026-07-22 21:49 ` [PATCH v4 7/7] rust: time: remove unused Jiffies/Msecs helpers FUJITA Tomonori
2026-07-23 13:43 ` [PATCH v4 0/7] rust: use Delta instead of raw jiffies for timeouts and delays Gary Guo
2026-07-30 13:09 ` Gary Guo
2026-07-31 13:48 ` FUJITA Tomonori
2026-08-05 12:48 ` Andreas Hindborg
2026-08-05 14:15 ` Gary Guo [this message]
2026-08-05 14:21 ` Miguel Ojeda
2026-08-05 14:22 ` Miguel Ojeda
2026-08-05 19:41 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKH2NGL7W29L.2K5MVFFHP84JX@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=arve@android.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jstultz@google.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tamird@kernel.org \
--cc=tglx@kernel.org \
--cc=tkjos@android.com \
--cc=tmgross@umich.edu \
--cc=tomo@flapping.org \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox