Rust for Linux List
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Miguel Ojeda" <ojeda@kernel.org>, <gary@kernel.org>,
	"Mark Brown" <broonie@kernel.org>
Cc: <linux-next@vger.kernel.org>, <a.hindborg@kernel.org>,
	<acourbot@nvidia.com>, <aliceryhl@google.com>,
	<bjorn3_gh@protonmail.com>, <boqun@kernel.org>, <dakr@kernel.org>,
	<daniel.almeida@collabora.com>, <gary@garyguo.net>,
	<lossin@kernel.org>, <rust-for-linux@vger.kernel.org>,
	<tamird@kernel.org>, <tmgross@umich.edu>, <work@onurozkan.dev>
Subject: Re: [GIT PULL] pin-init changes for v7.3-rc1
Date: Thu, 06 Aug 2026 19:19:05 +0100	[thread overview]
Message-ID: <DKI2GNME8JEU.27LL7M7GZHZKQ@garyguo.net> (raw)
In-Reply-To: <20260806170101.67544-1-ojeda@kernel.org>

On Thu Aug 6, 2026 at 6:01 PM BST, Miguel Ojeda wrote:
> On Wed, 05 Aug 2026 20:00:07 +0100 Gary Guo <gary@kernel.org> wrote:
>>
>> Still more of refactors this cycle and not much feature updates. Tuple struct
>> still doesn't made it as there are some complexity related to `#[cfg]`s, but
>> the cfg-related internal refactoring are picked so hopefully we can land it the
>> next one.
>>
>> I did a late rebase today to rename the API based on Benno's feedback. It does
>> made it into today's linux-next (2026-08-05). Feel free to wait for a few more
>> rounds before pulling if you see fit.
>
> Thanks Gary -- we will need this on the merge commit in linux-next due
> to the changes from driver-core-next (Cc'ing Mark):
>
> diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs
> index c0cd24481ee3..a4927452016e 100644
> --- a/rust/kernel/serdev.rs
> +++ b/rust/kernel/serdev.rs
> @@ -197,7 +197,7 @@ extern "C" fn probe_callback(sdev: *mut bindings::serdev_device) -> kernel::ffi:
>              // SAFETY:
>              // - `driver.as_mut_ptr()` is a valid pointer to uninitialized data.
>              // - `private_data.driver` is pinned.
> -            let result = unsafe { data.__pinned_init(driver.as_mut_ptr()) };
> +            let result = unsafe { pin_init::raw_try_init(driver.as_mut_ptr(), data) };
>
>              *active = result.is_ok();
>
> Cheers,
> Miguel

Thanks Miguel, the semantic conflict resolution looks correct to me.

Best,
Gary

      parent reply	other threads:[~2026-08-06 18:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05 19:00 [GIT PULL] pin-init changes for v7.3-rc1 Gary Guo
2026-08-06 17:01 ` Miguel Ojeda
2026-08-06 17:05   ` Mark Brown
2026-08-06 17:09     ` Miguel Ojeda
2026-08-06 17:22       ` Mark Brown
2026-08-06 17:53         ` Miguel Ojeda
2026-08-06 18:21           ` Mark Brown
2026-08-07  7:51             ` Miguel Ojeda
2026-08-06 18:19   ` Gary Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKI2GNME8JEU.27LL7M7GZHZKQ@garyguo.net \
    --to=gary@garyguo.net \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox